[Box Backup-commit] Re: #3: Merge Win32 branch
boxbackup-dev at fluffy.co.uk
boxbackup-dev at fluffy.co.uk
Sat Mar 10 22:26:21 GMT 2007
#3: Merge Win32 branch
-----------------------+----------------------------------------------------
Reporter: chris | Owner: chris
Type: task | Status: new
Priority: normal | Milestone: 0.11
Component: bbackupd | Version: trunk
Resolution: | Keywords: windows win32 merge branch
-----------------------+----------------------------------------------------
Comment (by invisnet):
[1083] An OVERLAPPED struct needs to be cleared before every use when
talking to pipes, not just the first time.
The pipe is in message mode; why would there be more data in the buffer
than is being asked for? Use stream mode if this is supposed to be a
generic class, or provide some way to select the mode.
memcpy() is not guaranteed to work with overlapping buffers (line 288).
Use memmove() instead.
--
Ticket URL: <http://bbdev.fluffy.co.uk/trac/ticket/3#comment:309>
Box Backup <http://www.fluffy.co.uk/boxbackup/>
An open source, completely automatic on-line backup system for UNIX.
More information about the Boxbackup-commit
mailing list