[Box Backup-commit] COMMIT r2907 - box/trunk/bin/bbackupd

[subversion at boxbackup.org]

Author: chris
Date: 2011-04-09 21:12:55 +0100 (Sat, 09 Apr 2011)
New Revision: 2907

Modified:
   box/trunk/bin/bbackupd/BackupDaemon.cpp
   box/trunk/bin/bbackupd/BackupDaemon.h
Log:
Actually try to back up from the VSS snapshot volume.

Clean up VSS resources at end of backup.


Modified: box/trunk/bin/bbackupd/BackupDaemon.cpp
===================================================================
--- box/trunk/bin/bbackupd/BackupDaemon.cpp	2011-04-08 20:43:06 UTC (rev 2906)
+++ box/trunk/bin/bbackupd/BackupDaemon.cpp	2011-04-09 20:12:55 UTC (rev 2907)
@@ -981,10 +981,18 @@
 			(*i)->mpExcludeDirs);
 
 		// Sync the directory
+		std::string locationPath = (*i)->mPath;
+#ifdef ENABLE_VSS
+		if((*i)->mIsSnapshotCreated)
+		{
+			locationPath = (*i)->mSnapshotPath;
+		}
+#endif
+
 		(*i)->mpDirectoryRecord->SyncDirectory(
 			params,
 			BackupProtocolClientListDirectory::RootDirectory,
-			(*i)->mPath, std::string("/") + (*i)->mName);
+			locationPath, std::string("/") + (*i)->mName);
 
 		// Unset exclude lists (just in case)
 		clientContext.SetExcludeLists(0, 0);
@@ -997,7 +1005,11 @@
 
 	// Close any open connection
 	clientContext.CloseAnyOpenConnection();
-	
+
+#ifdef ENABLE_VSS
+	CleanupVssBackupComponents();
+#endif
+
 	// Get the new store marker
 	mClientStoreMarker = clientContext.GetClientStoreMarker();
 	mStorageLimitExceeded = clientContext.StorageLimitExceeded();
@@ -1133,7 +1145,7 @@
 		}
 
 		BOX_ERROR("VSS: Failed to initialize for backup: " << message);
-		goto CreateVssBackupComponents_cleanup_mpVssBackupComponents;
+		return;
 	}
 
 	result = mpVssBackupComponents->SetContext(VSS_CTX_BACKUP);
@@ -1146,7 +1158,7 @@
 	{
 		BOX_ERROR("VSS: Failed to set context to VSS_CTX_BACKUP: " <<
 			GetMsgForHresult(result));
-		goto CreateVssBackupComponents_cleanup_mpVssBackupComponents;
+		return;
 	}
 
 	result = mpVssBackupComponents->SetBackupState(
@@ -1158,7 +1170,7 @@
 	{
 		BOX_ERROR("VSS: Failed to set backup state: " <<
 			GetMsgForHresult(result));
-		goto CreateVssBackupComponents_cleanup_mpVssBackupComponents;
+		return;
 	}
 
 	if(!CallAndWaitForAsync(&IVssBackupComponents::GatherWriterMetadata,
@@ -1187,7 +1199,7 @@
 		{
 			BOX_ERROR("Failed to get VSS metadata from writer " << iWriter <<
 				": " << GetMsgForHresult(result));
-			goto CreateVssBackupComponents_cleanup_WriterMetadata;
+			continue;
 		}
 
 		UINT includeFiles, excludeFiles, numComponents;
@@ -1199,7 +1211,7 @@
 				"writer " << iWriter <<	": " << 
 				GetMsgForHresult(result));
 			pMetadata->Release();
-			goto CreateVssBackupComponents_cleanup_mpVssBackupComponents;
+			continue;
 		}
 
 		for(UINT iComponent = 0; iComponent < numComponents; iComponent++)
@@ -1582,11 +1594,20 @@
 		BOX_ERROR("VSS: Failed to free writer metadata: " <<
 			GetMsgForHresult(result));
 	}
+}
 
-CreateVssBackupComponents_cleanup_mpVssBackupComponents:
+void BackupDaemon::CleanupVssBackupComponents()
+{
+	if(mpVssBackupComponents == NULL)
+	{
+		return;
+	}
+
+	CallAndWaitForAsync(&IVssBackupComponents::BackupComplete,
+		"BackupComplete()");
+
 	mpVssBackupComponents->Release();
 	mpVssBackupComponents = NULL;
-	return;
 }
 #endif
 

Modified: box/trunk/bin/bbackupd/BackupDaemon.h
===================================================================
--- box/trunk/bin/bbackupd/BackupDaemon.h	2011-04-08 20:43:06 UTC (rev 2906)
+++ box/trunk/bin/bbackupd/BackupDaemon.h	2011-04-09 20:12:55 UTC (rev 2907)
@@ -543,6 +543,7 @@
 	typedef HRESULT (__stdcall IVssBackupComponents::*AsyncMethod)(IVssAsync**);
 	bool CallAndWaitForAsync(AsyncMethod method,
 		const std::string& description);
+	void CleanupVssBackupComponents();
 #endif
 };