[Box Backup-commit] COMMIT r3188 - box/trunk/lib/raidfile

[subversion at boxbackup.org]

Author: chris
Date: 2013-09-20 16:16:25 +0100 (Fri, 20 Sep 2013)
New Revision: 3188

Modified:
   box/trunk/lib/raidfile/RaidFileWrite.h
Log:
Add a comment about removing one RaidFileWrite constructor.

Modified: box/trunk/lib/raidfile/RaidFileWrite.h
===================================================================
--- box/trunk/lib/raidfile/RaidFileWrite.h	2013-09-19 23:10:42 UTC (rev 3187)
+++ box/trunk/lib/raidfile/RaidFileWrite.h	2013-09-20 15:16:25 UTC (rev 3188)
@@ -27,7 +27,18 @@
 class RaidFileWrite : public IOStream
 {
 public:
+	// TODO FIXME we should remove this constructor, and ensure that
+	// anyone who writes to a RaidFile knows what the reference count
+	// is before doing so. That requires supporting regenerating the
+	// reference count database in BackupStoreCheck, and using a real
+	// database instead of an in-memory array in HousekeepStoreAccount,
+	// and supporting multiple databases at a time (old and new) in
+	// BackupStoreRefCountDatabase, and I don't have time to make those
+	// changes right now. We may even absolutely need to have a full
+	// reference database, not just reference counts, to implement
+	// snapshots.
 	RaidFileWrite(int SetNumber, const std::string &Filename);
+
 	RaidFileWrite(int SetNumber, const std::string &Filename, int refcount);
 	~RaidFileWrite();
 private: