[Box Backup-commit] COMMIT r3619 - box/trunk/test/bbackupd

subversion at boxbackup.org subversion at boxbackup.org
Fri Aug 7 22:40:13 BST 2015


Author: chris
Date: 2015-08-07 21:40:12 +0000 (Fri, 07 Aug 2015)
New Revision: 3619

Modified:
   box/trunk/test/bbackupd/testbbackupd.cpp
Log:
Fix random failures of testbbackup test_backup_pauses_when_store_is_full.

Stop the client while waiting for housekeeping, to ensure that it doesn't
prevent housekeeping from running and cause the test to fail.

Modified: box/trunk/test/bbackupd/testbbackupd.cpp
===================================================================
--- box/trunk/test/bbackupd/testbbackupd.cpp	2015-08-06 21:25:31 UTC (rev 3618)
+++ box/trunk/test/bbackupd/testbbackupd.cpp	2015-08-07 21:40:12 UTC (rev 3619)
@@ -1816,7 +1816,10 @@
 		TEST_THAT(!TestFileExists("testfiles/notifyran.store-full.2"));
 
 		// We can't guarantee to get in before housekeeping runs, so it's safer
-		// (more reliable) to wait for it to finish.
+		// (more reliable) to wait for it to finish. But we also need to stop the
+		// client first, otherwise it might be connected when housekeeping tries
+		// to run, and that would prevent it from running, causing test to fail.
+		TEST_THAT_OR(StopClient(), FAIL);
 		wait_for_operation(5, "housekeeping to run");
 
 		// BLOCK
@@ -1863,6 +1866,7 @@
 	// Increase the limit again, check that all files are backed up on the
 	// next run.
 	TEST_THAT(change_account_limits("0B", "34B"));
+	TEST_THAT_OR(StartClient(), FAIL);
 	wait_for_sync_end();
 	TEST_COMPARE(Compare_Same);
 




More information about the Boxbackup-commit mailing list