[Box Backup-commit] [boxbackup/boxbackup] 0b509d: Catch and log exceptions in the HousekeepStoreAcco...

GitHub noreply at github.com
Tue Dec 22 21:29:22 GMT 2015


  Branch: refs/heads/appveyor
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 0b509d458b2ef3c5c525b7e5e2e66352285c7d91
      https://github.com/boxbackup/boxbackup/commit/0b509d458b2ef3c5c525b7e5e2e66352285c7d91
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M lib/backupstore/HousekeepStoreAccount.cpp

  Log Message:
  -----------
  Catch and log exceptions in the HousekeepStoreAccount destructor.

Destructors aren't supposed to throw exceptions, and they can be called
while cleaning up from a previous exception, which will terminate the
application, so just log the error and carry on.


  Commit: 509fac53b3ebc5030c6bbff27ecf1c37907fb7ee
      https://github.com/boxbackup/boxbackup/commit/509fac53b3ebc5030c6bbff27ecf1c37907fb7ee
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M lib/server/SocketListen.h

  Log Message:
  -----------
  Don't use close() to close a Winsock socket.

We should always use closesocket() instead, which the Close() method already
does, so just call it instead.


  Commit: 3dcd45ed710132bcaa2fefe5bc2c4753c232b0d0
      https://github.com/boxbackup/boxbackup/commit/3dcd45ed710132bcaa2fefe5bc2c4753c232b0d0
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M test/backupstorefix/testbackupstorefix.cpp

  Log Message:
  -----------
  Check file counts before messing with the store in test/backupstorefix.

Otherwise when the counts differ later, we won't know whether we did the setup
properly in the first place or not.


  Commit: 7ea37ed6e8a4f8ad1b3e9ca7bc75eba524a64648
      https://github.com/boxbackup/boxbackup/commit/7ea37ed6e8a4f8ad1b3e9ca7bc75eba524a64648
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M test/backupstorefix/testfiles/testbackupstorefix.pl.in

  Log Message:
  -----------
  Change a generated filename to avoid creating files called "con".

Con is a special filename on Windows and you just can't create a file with
that name.


  Commit: 9e20521b88d0520908d3194b5bfb9a4249072599
      https://github.com/boxbackup/boxbackup/commit/9e20521b88d0520908d3194b5bfb9a4249072599
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M test/backupstorefix/testbackupstorefix.cpp

  Log Message:
  -----------
  Don't start and stop bbstored on Windows.

StopServer() does a hard terminate on Windows, which can leave temporary files
in place, causing problems later in the test.


Compare: https://github.com/boxbackup/boxbackup/compare/d18f1a336d8c...9e20521b88d0


More information about the Boxbackup-commit mailing list