[Box Backup-commit] [boxbackup/boxbackup] 6115c9: Move BackupStoreAccountsControl into same file as ...

[GitHub]

  Branch: refs/heads/s3_support_merge_5
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 6115c93b455a8625c75231fa112ffca18734c308
      https://github.com/boxbackup/boxbackup/commit/6115c93b455a8625c75231fa112ffca18734c308
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2016-12-06 (Tue, 06 Dec 2016)

  Changed paths:
    M bin/bbstoreaccounts/bbstoreaccounts.cpp
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupAccountControl.h
    M lib/backupstore/BackupStoreAccounts.cpp
    M lib/backupstore/BackupStoreInfo.cpp
    M lib/backupstore/BackupStoreInfo.h
    M lib/backupstore/StoreTestUtils.cpp
    R test/s3store/testfiles/store/subdir/dirs/create-me.txt
    M test/s3store/tests3store.cpp

  Log Message:
  -----------
  Move BackupStoreAccountsControl into same file as BackupAccountControl.

Rename it to BackupStoreAccountControl (without the "s") for consistency.

Change interface so that it's constructed with an account number, so it can
be omitted from each command, which helps us to maintain the same interface
for S3BackupAccountControl.

Refactor bbstoreaccounts to create space for Amazon S3 command implementation.

Fix confusion about URIs and paths in S3 filesystem.  Make it clear (with
parameter names and comments) which functions take paths (relative to the
configured base path), which functions take URIs (complete paths) and which
functions take URLs (hostname, port and URI).

Put all objects (files and directories) in the same "directory" on S3 so that
we can list them all together and easily identify the type of each object (from
its extension). Previously they were separated into "directories" (delimited
prefixes) called "files" and "dirs" (unlike BackupStore filesystems).


  Commit: ef80b5a7f344efcc17d896c5f146b9a59fb2a98a
      https://github.com/boxbackup/boxbackup/commit/ef80b5a7f344efcc17d896c5f146b9a59fb2a98a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2016-12-06 (Tue, 06 Dec 2016)

  Changed paths:
    M infrastructure/m4/boxbackup_tests.m4
    M test/bbackupd/testbbackupd.cpp

  Log Message:
  -----------
  Fix warning that overloaded method hides inherited ones

Make this warning an error to prevent it from happening again.


Compare: https://github.com/boxbackup/boxbackup/compare/edff22c02e48...ef80b5a7f344