[Box Backup-commit] [boxbackup/boxbackup] 416dca: Fix testbackupstorepatch for BackupFileSystem.
GitHub
noreply at github.com
Wed Oct 12 22:23:06 BST 2016
Branch: refs/heads/s3_support
Home: https://github.com/boxbackup/boxbackup
Commit: 416dcacb332297ac9a832cdad6bfa1e6739a52f7
https://github.com/boxbackup/boxbackup/commit/416dcacb332297ac9a832cdad6bfa1e6739a52f7
Author: Chris Wilson <chris+github at qwirx.com>
Date: 2016-10-12 (Wed, 12 Oct 2016)
Changed paths:
M lib/backupstore/BackupFileSystem.cpp
M lib/backupstore/BackupFileSystem.h
M lib/backupstore/HousekeepStoreAccount.cpp
M lib/backupstore/HousekeepStoreAccount.h
M test/backupstorepatch/testbackupstorepatch.cpp
Log Message:
-----------
Fix testbackupstorepatch for BackupFileSystem.
* Make testbackupstorepatch do housekeeping in-process to make debugging easier.
* Check return value of housekeeping to ensure that no errors were detected.
* Initialise and update file size in blocks in patch-combining transactions.
* Take locks in testbackupstorepatch to hopefully prevent race conditions leading to
store corruption and unreliable tests when using housekeeping out-of-process.
* Eliminate some copy-pasted duplicate code in BackupFileSystem and in housekeeping.
* Delay RemoveASAP deletions to avoid false positive mismatches of block and reference
counts being reported as errors during housekeeping.
More information about the Boxbackup-commit
mailing list