[Box Backup-commit] [boxbackup/boxbackup] 85beed: Use pkill to kill running daemons after tests

GitHub noreply at github.com
Mon Dec 4 22:21:26 GMT 2017


  Branch: refs/heads/s3_support_merge
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 85beed59777f33630547b3fa528e45e79c77716a
      https://github.com/boxbackup/boxbackup/commit/85beed59777f33630547b3fa528e45e79c77716a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-12-04 (Mon, 04 Dec 2017)

  Changed paths:
    M infrastructure/cmake/CMakeLists.txt
    M infrastructure/m4/boxbackup_tests.m4
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Use pkill to kill running daemons after tests

Should hopefully fix issues with lingering daemon processes causing buildbot
workers to become unusable.

Automatically detect which pkill command-line options are supported by your
Unix variant in the Perl and CMake buildsystems, and use them.


  Commit: 7a90d7bd08a6414e8ed521954ef9b0e9b70caaa2
      https://github.com/boxbackup/boxbackup/commit/7a90d7bd08a6414e8ed521954ef9b0e9b70caaa2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-12-04 (Mon, 04 Dec 2017)

  Changed paths:
    M lib/win32/getopt_long.cpp

  Log Message:
  -----------
  Only replace getopt on Windows, not any other platform

The preprocessor test was wrong, causing this code to be built (and potentially
replace the system getopt/long) on all platforms. This made it impossible to
build with -Werror=writable-strings on Unix without modifying this file further
to fix its casting of static strings to mutable pointers.


  Commit: 02871a9df74116e6228990aa8e4d73eb5ae1e597
      https://github.com/boxbackup/boxbackup/commit/02871a9df74116e6228990aa8e4d73eb5ae1e597
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-12-04 (Mon, 04 Dec 2017)

  Changed paths:
    M infrastructure/m4/boxbackup_tests.m4
    M lib/common/Utils.cpp

  Log Message:
  -----------
  Enable -Werror=writable-strings and fix one such error


  Commit: a84c436f256fa8792c1d1c50a445197d0b8f7bd5
      https://github.com/boxbackup/boxbackup/commit/a84c436f256fa8792c1d1c50a445197d0b8f7bd5
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-12-04 (Mon, 04 Dec 2017)

  Changed paths:
    M lib/server/makeprotocol.pl.in
    M test/basicserver/TestCommands.cpp
    M test/basicserver/TestProtocol.txt
    M test/basicserver/testbasicserver.cpp

  Log Message:
  -----------
  Fix ProtocolError single-argument (subtype only) constructor

Correctly initialise mType from the ErrorType CONSTANT in the protocol message
definition in this case, instead of leaving it uninitialised. Add test. Also
test that these unexpected errors cause the connection to be closed as
expected.


  Commit: 5039ac3b15d37e0ace58ba2ddb268a96832ab423
      https://github.com/boxbackup/boxbackup/commit/5039ac3b15d37e0ace58ba2ddb268a96832ab423
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-12-04 (Mon, 04 Dec 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Fix build order for targets which depend on auto-generated files

These auto-generated files should always be rebuilt first, and hence must be
listed first in the dependencies. Otherwise, if we add a command to a
Protocol.txt file and also implement that command in the Commands.cpp source
file, we might try to compile Commands.cpp before rebuilding
autogen_Protocol.h, which will fail with a compile error, which prevents Make
from reaching the autogen_Protocol.cpp target which would cause the header file
to be updated as a side effect, which would resolve the compile error.


Compare: https://github.com/boxbackup/boxbackup/compare/02bf94cbc75d...5039ac3b15d3


More information about the Boxbackup-commit mailing list