[Box Backup-commit] [boxbackup/boxbackup] df5a3b: Hopefully fix test/backupstorefix slow performance...
GitHub
noreply at github.com
Sat Feb 4 23:12:41 GMT 2017
Branch: refs/heads/s3_support
Home: https://github.com/boxbackup/boxbackup
Commit: df5a3ba83767c10eaed3f7cdb49c5e832b77bb89
https://github.com/boxbackup/boxbackup/commit/df5a3ba83767c10eaed3f7cdb49c5e832b77bb89
Author: Chris Wilson <chris+github at qwirx.com>
Date: 2017-02-04 (Sat, 04 Feb 2017)
Changed paths:
M lib/backupstore/BackupStoreContext.cpp
M lib/backupstore/BackupStoreContext.h
M lib/backupstore/BackupStoreDirectory.h
M lib/backupstore/StoreTestUtils.h
M test/backupstore/testbackupstore.cpp
Log Message:
-----------
Hopefully fix test/backupstorefix slow performance on Windows
Frequent directory writes, combined with NtClose() being very slow, meant that
the test took 30-120 seconds on Windows (compared to about 5-10 seconds on OSX)
and frequently timed out on Travis.
I've implemented a write cache for directories in BackupStoreContext, and made
the read cache effective in DEBUG builds, to hopefully address this, at the
cost of some extra complexity in tests with multiple sessions.
More information about the Boxbackup-commit
mailing list