[Box Backup-commit] [boxbackup/boxbackup] a159a1: Whitespace and comment cleanup

Thu Jul 27 21:12:48 BST 2017

  Branch: refs/heads/s3_support_merge
  Home:   https://github.com/boxbackup/boxbackup
  Commit: a159a191130f811357f9bc79478269d7d1072397
      https://github.com/boxbackup/boxbackup/commit/a159a191130f811357f9bc79478269d7d1072397
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M bin/bbstoreaccounts/bbstoreaccounts.cpp
    M infrastructure/m4/boxbackup_tests.m4
    M infrastructure/makebuildenv.pl.in
    M infrastructure/travis-build.sh
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupConstants.h
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupProtocol.txt
    M lib/backupstore/BackupStoreAccounts.h
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/BackupStoreCheck.h
    M lib/backupstore/BackupStoreCheck2.cpp
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/BackupStoreContext.h
    M lib/backupstore/BackupStoreException.txt
    M lib/backupstore/BackupStoreFile.cpp
    M lib/backupstore/BackupStoreRefCountDatabase.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp
    M lib/backupstore/StoreTestUtils.cpp
    M lib/backupstore/StoreTestUtils.h
    M lib/bbstored/BackupStoreDaemon.cpp
    M lib/common/CollectInBufferStream.cpp
    M lib/common/CommonException.txt
    M lib/common/NamedLock.cpp
    M lib/httpserver/S3Simulator.cpp
    M runtest.pl.in
    M test/backupstore/testbackupstore.cpp
    M test/backupstorefix/testbackupstorefix.cpp
    M test/backupstorepatch/testbackupstorepatch.cpp
    M test/bbackupd/testbbackupd.cpp
    M test/common/testcommon.cpp
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Whitespace and comment cleanup

  Commit: 67e41ada1eefa46f2a3e313279e07e54de3d8f1d
      https://github.com/boxbackup/boxbackup/commit/67e41ada1eefa46f2a3e313279e07e54de3d8f1d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Custom build system: fix autogen dependencies

Remove useless inclusion of Makefile.extras with paths in subdirs that will
never match anything, and replace those inclusions with recursive Make calls to
build those targets. This allows changes to exception and protocol files to be
detected automatically, and the C++ code regenerated.

  Commit: 9e19ba6329f6a38dc8eaf4abcb7f59b14764c951
      https://github.com/boxbackup/boxbackup/commit/9e19ba6329f6a38dc8eaf4abcb7f59b14764c951
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/backupclient/BackupClientRestore.cpp
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/BackupStoreCheck.h
    M lib/common/Test.cpp
    M lib/common/Utils.cpp
    M lib/common/Utils.h
    M lib/httpserver/S3Simulator.cpp

  Log Message:
  -----------
  Make ObjectExists and BackupStoreCheck use object_exists_t enum

  Commit: 5b78490f5053be282884fdeb842dfa6036866663
      https://github.com/boxbackup/boxbackup/commit/5b78490f5053be282884fdeb842dfa6036866663
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/common/Utils.cpp
    M lib/common/Utils.h

  Log Message:
  -----------
  Add GetTempDirPath() for portability

On Unix, check TEMP, TMP and TMPDIR, and if no env var is set, fall back to
/tmp.  For some reason it's becoming increasingly common for Unixes not to set
TMP* to anything.

  Commit: 27859b5a56b43d2dc54c57afcd6270b979915e98
      https://github.com/boxbackup/boxbackup/commit/27859b5a56b43d2dc54c57afcd6270b979915e98
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Fix include ordering in testcommon.cpp

  Commit: 8495702c8bd3afe4e80bb342b60e2f4c8498da0a
      https://github.com/boxbackup/boxbackup/commit/8495702c8bd3afe4e80bb342b60e2f4c8498da0a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Refactor testcommon to split into independent tests

Remove redundant NamedLock tests.

  Commit: ca92310be4aab2542fa2a219021ea6c8a93a5542
      https://github.com/boxbackup/boxbackup/commit/ca92310be4aab2542fa2a219021ea6c8a93a5542
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/common/Utils.cpp
    M lib/common/Utils.h
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Add force parameter to RemovePrefix and RemoveSuffix

  Commit: 190251241b76d7909fe7e031dabc37aa2210405f
      https://github.com/boxbackup/boxbackup/commit/190251241b76d7909fe7e031dabc37aa2210405f
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/backupstore/BackupCommands.cpp
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/BackupStoreContext.h

  Log Message:
  -----------
  Remove BackupStoreContext::ReceivedFinishCommand

Replace with CleanUp(). We don't need two methods that do almost the same
thing.

  Commit: 76f819921930391ea062c0b5159cb1dd438ea7ef
      https://github.com/boxbackup/boxbackup/commit/76f819921930391ea062c0b5159cb1dd438ea7ef
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/backupstore/BackupProtocol.h
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/BackupStoreContext.h
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Refactor BackupStoreContext::GetBackupStoreInfo

Almost all access to mapStoreInfo is now via GetBackupStoreInfo(Internal), in
preparation for the refactor that will move the main copy of the
BackupStoreInfo to the BackupFileSystem instance instead.

  Commit: 421a3d95b9c7bbb459ae65b3c19eea1f81903d04
      https://github.com/boxbackup/boxbackup/commit/421a3d95b9c7bbb459ae65b3c19eea1f81903d04
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M infrastructure/cmake/CMakeLists.txt
    M infrastructure/m4/boxbackup_tests.m4
    M lib/backupstore/BackupStoreContext.cpp

  Log Message:
  -----------
  Enable C++0x support

We need C++0x features enabled for "auto" to work, and using Boost properly
seems to require this. Use "auto" in a few places to prove that it works.

  Commit: 0fec18454f507e1e5ed7f90a4d551b47ea3b4f74
      https://github.com/boxbackup/boxbackup/commit/0fec18454f507e1e5ed7f90a4d551b47ea3b4f74
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Refactor to create BackupFileSystem::GetBackupStoreInfo

Extract common code from filesystem-specific implementations, and rename them
to GetBackupStoreInfoInternal().

  Commit: 3576bd86d31cda130e56f3079f90646c1e6b22df
      https://github.com/boxbackup/boxbackup/commit/3576bd86d31cda130e56f3079f90646c1e6b22df
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Refactor BackupFileSystem::GetLock()

Call subclass implementations of TryGetLock(), and throw an exception if we
fail to get a lock instead of returning false.

  Commit: 790e60aac5d9d4eeca3e8b22878ab829c8813421
      https://github.com/boxbackup/boxbackup/commit/790e60aac5d9d4eeca3e8b22878ab829c8813421
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/common/Test.cpp
    M lib/common/Utils.cpp
    M lib/common/Utils.h

  Log Message:
  -----------
  Refactor test code into process_is_running()

We need the ability to check whether a process is still running to check for
stale S3 account locks in SimpleDB, so move this code out of Test.cpp and into
Utils.cpp, for use outside of tests.

  Commit: 44ce225108a9e5c4d88c51a8ae76038f9f44690b
      https://github.com/boxbackup/boxbackup/commit/44ce225108a9e5c4d88c51a8ae76038f9f44690b
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/common/Test.cpp
    M lib/common/Test.h
    M lib/common/Utils.cpp
    M lib/common/Utils.h

  Log Message:
  -----------
  Implement compare_lists and test_equal_maps in lib/common/Test.cpp

  Commit: 5263aa3a9f89bc97ba1a13821cf58e149749db3d
      https://github.com/boxbackup/boxbackup/commit/5263aa3a9f89bc97ba1a13821cf58e149749db3d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/httpserver/HTTPQueryDecoder.cpp
    M lib/httpserver/HTTPQueryDecoder.h
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Add static method HTTPQueryDecoder::URLEncode

This will be needed for request parameter encoding and for SimpleDB.

  Commit: a7f3aec96249bccd7e0775989d028fbc956fea86
      https://github.com/boxbackup/boxbackup/commit/a7f3aec96249bccd7e0775989d028fbc956fea86
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/httpserver/HTTPRequest.cpp
    M lib/httpserver/HTTPRequest.h
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Add query parameter editing and encoding to HTTPRequest

  Commit: d18b0d111fb7e6cd15a45d4949c238abe35dfdd0
      https://github.com/boxbackup/boxbackup/commit/d18b0d111fb7e6cd15a45d4949c238abe35dfdd0
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M lib/httpserver/S3Client.cpp
    M lib/httpserver/S3Client.h
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Add support for virtualhost names in S3Client

This is a precondition of support for both S3 and SimpleDB in the S3Simulator,
since otherwise we can't tell the requests apart.

Compare: https://github.com/boxbackup/boxbackup/compare/5401a6b045cd...d18b0d111fb7