[Box Backup-commit] [boxbackup/boxbackup] 98b779: Fix confusion about URIs and paths in S3 filesyste...

GitHub noreply at github.com
Fri Jun 2 22:03:08 BST 2017

  Branch: refs/heads/s3_support_merge
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 98b7796ce9bb83f0fcdf01612fd1c65532459801
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-02 (Fri, 02 Jun 2017)

  Changed paths:
    M lib/backupstore/BackupAccountControl.h
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M test/s3store/tests3store.cpp

  Log Message:
  Fix confusion about URIs and paths in S3 filesystem

* Make it clear (with parameter names and comments) which functions take paths
  (relative to the configured base path), which functions take URIs (complete
  paths) and which functions take URLs (hostname, port and URI).

* Put all objects (files and directories) in the same "directory" tree on S3,
  so that we can list them all together and easily identify the type of each
  object (from its extension). Previously they were separated into "directories"
  (delimited prefixes) called "files" and "dirs" (unlike BackupStore

* Reinstate hierarchical "directories" on S3, similar to BackupStore
  filesystems, since the reasons for doing this in RaidFile may well apply to S3
  and other compatible stores too. However the objects are still named with
  their complete object ID (unlike RaidFile) and a .file or .dir extension.

(cherry picked from commit 3dd21a3028cacea2ecf6ee3de2f32db3c5138589)

  Commit: 2e9c90d3f32c69cc89d01fb64ced9fca80aae985
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-02 (Fri, 02 Jun 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  Fix quoting of CXXFLAGS and LDFLAGS in Makefiles

Previously, it was impossible to include an @ sign in these flags (for example,
to link to support --with-ssl-headers=/usr/local/opt/openssl at 1.1/include/)
because it was interpreted as a list variable name by Perl. Now the variables
are evaluated single-quoted before being substituted into the Makefile output.

Compare: https://github.com/boxbackup/boxbackup/compare/0e2e477cec83...2e9c90d3f32c

More information about the Boxbackup-commit mailing list