[Box Backup-commit] [boxbackup/boxbackup] 750e35: Move BackupStoreAccountControl code to BackupAccou...

GitHub noreply at github.com
Tue Jun 6 21:03:27 BST 2017

  Branch: refs/heads/s3_support_merge
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 750e35a7e499089ab9f3ed2215bfaab84f2f70e2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupAccountControl.h
    M lib/backupstore/BackupStoreAccounts.cpp
    M lib/backupstore/BackupStoreAccounts.h

  Log Message:
  Move BackupStoreAccountControl code to BackupAccountControl file

(cherry picked from commit 2891416b675cdc346713a26c6e357fba302bbc89)

  Commit: f785fa6a3ba9e7e96813f94b7f2baa093e32e34a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M .travis.yml
    M infrastructure/cmake/CMakeLists.txt
    A infrastructure/m4/ax_boost_base.m4
    M infrastructure/m4/boxbackup_tests.m4

  Log Message:
  Add Boost, needed for XML support in S3Simulator and S3Client

Boost will be needed on all platforms for S3 support at least. It's currently
mandatory, but could be made optional if necessary. XML support of some kind is
required both for S3's ListBucket command (which returns XML) and for SimpleDB
support in the S3Simulator, since the SimpleDB API uses XML.

I considered alternative XML libraries to Boost:

* https://stackoverflow.com/questions/170686/what-is-the-best-open-xml-parser-for-c
* https://stackoverflow.com/questions/9387610/what-xml-parser-should-i-use-in-c

The most commonly used one (libxml2) is huge, ugly, slow and hard to use, and
we don't need any of the extra features.  TinyXML would meet our needs, but
Boost is more likely to be available on more platforms, is well respected, and
brings other (unrelated) features that we might want to use in future.

(cherry picked from commit 1a9deec05151281e840b7df5a1244453c0111042)

Compare: https://github.com/boxbackup/boxbackup/compare/91993f38c6b2...f785fa6a3ba9

More information about the Boxbackup-commit mailing list