[Box Backup-commit] [boxbackup/boxbackup] d15593: Normalize all the line endings

GitHub noreply at github.com
Sun Jun 25 20:01:18 BST 2017


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: d15593866c28b2cabd7970fe1f6eb4775fa94ce4
      https://github.com/boxbackup/boxbackup/commit/d15593866c28b2cabd7970fe1f6eb4775fa94ce4
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M infrastructure/cmake/build/bin_bbackupd.vcxproj.user
    M infrastructure/cmake/build/bin_bbstored.vcxproj.user
    M infrastructure/cmake/build/test_backupstore.vcxproj.user
    M infrastructure/cmake/build/test_backupstorefix.vcxproj.user
    M infrastructure/cmake/build/test_bbackupd.vcxproj.user
    M infrastructure/cmake/build/test_common.vcxproj.user
    M infrastructure/cmake/build/test_httpserver.vcxproj.user
    M infrastructure/cmake/build/test_raidfile.vcxproj.user
    M lib/win32/bsd_getopt.h
    M lib/win32/getopt_long.cpp
    M lib/win32/messages.h

  Log Message:
  -----------
  Normalize all the line endings


  Commit: 0e7bee470a1473910b1523c8e3703dce5be8f582
      https://github.com/boxbackup/boxbackup/commit/0e7bee470a1473910b1523c8e3703dce5be8f582
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M .gitattributes

  Log Message:
  -----------
  Tell Git to treat .cpp files as text too.


  Commit: f786bcc36ea371d1f12d0e6c3eb9d09a923bacfa
      https://github.com/boxbackup/boxbackup/commit/f786bcc36ea371d1f12d0e6c3eb9d09a923bacfa
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  Tell Git to ignore some more generated files


  Commit: be46ea2930924be655f2dc5ba59286889a3efc2c
      https://github.com/boxbackup/boxbackup/commit/be46ea2930924be655f2dc5ba59286889a3efc2c
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M .travis.yml
    M infrastructure/travis-build.sh

  Log Message:
  -----------
  Add Boost to Travis build environment, and OSX builds


  Commit: 61930b33d638e073084f30a16e8dbc086bdbdf5e
      https://github.com/boxbackup/boxbackup/commit/61930b33d638e073084f30a16e8dbc086bdbdf5e
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M appveyor.yml
    M infrastructure/cmake/windows/CMakeLists.txt

  Log Message:
  -----------
  Update versions of dependencies for Windows unibuild, add Boost

* Add a variable in appveyor.yml for the CMake out-of-source build tree.
* Update the directory name in commands in appveyor.yml to match new CMake unibuild tree structure.
* Increase build verbosity slightly.
* Disable GUI crash dialogs that cause test hangs.
* Disable the AppVeyor cache that we don't use.


  Commit: edd20503ccd15c58577eba5a609956263c673d85
      https://github.com/boxbackup/boxbackup/commit/edd20503ccd15c58577eba5a609956263c673d85
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M infrastructure/cmake/CMakeLists.txt

  Log Message:
  -----------
  Install executables in test tree after building, not during "make install"


  Commit: 6c0cdc4c08fbf24e9ae7675fd5333ba96141a297
      https://github.com/boxbackup/boxbackup/commit/6c0cdc4c08fbf24e9ae7675fd5333ba96141a297
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M infrastructure/BoxPlatform.pm.in

  Log Message:
  -----------
  Fix build on SmartOS by switching back to GNU Make

I have no idea where I got the idea that there was a "bmake" command on SmartOS
that is BSD make, or why that would be better than gmake (GNU make). I can't
find any reference to the existence of such a thing. So I've just switched back
to using gmake unconditionally.


  Commit: 1e1d7d197f6f23d726b84507fc8c7be0d15d5dbb
      https://github.com/boxbackup/boxbackup/commit/1e1d7d197f6f23d726b84507fc8c7be0d15d5dbb
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M lib/intercept/intercept.cpp

  Log Message:
  -----------
  Hopefully fix test/raidfile on Solaris.

64-bit Solaris has _FILE_OFFSET_BITS defined (to 64), which was wrongly causing
the substitute lseek in lib/intercept to enter the 32-bit branch.


  Commit: 530d2698fafd9b937133e565ca65f568d00a0023
      https://github.com/boxbackup/boxbackup/commit/530d2698fafd9b937133e565ca65f568d00a0023
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M lib/bbackupd/BackupClientDirectoryRecord.cpp
    M lib/win32/emu.cpp
    M lib/win32/emu.h

  Log Message:
  -----------
  Fix emulated readdir() d_type to return DT_FILE or DT_DIR like Unix does

We used to abuse dirent.d_type to store Windows attributes, but we can now just
add a new attribute to store these (win_attrs), so I have.


  Commit: 00c2127e9832591c248fa6eea05dfaf785b8380d
      https://github.com/boxbackup/boxbackup/commit/00c2127e9832591c248fa6eea05dfaf785b8380d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M test/bbackupd/testbbackupd.cpp

  Log Message:
  -----------
  Relax timings on test_changing_client_store_marker_pauses_daemon

Also increase test verbosity to help debug the test if it fails again.


  Commit: 4db4deed3448b9c2b9e885a20cb1a777632464d6
      https://github.com/boxbackup/boxbackup/commit/4db4deed3448b9c2b9e885a20cb1a777632464d6
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    A infrastructure/m4/ax_check_compile_flag.m4
    M infrastructure/m4/boxbackup_tests.m4
    M lib/backupstore/BackupAccountControl.h
    A lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreContext.h
    M lib/server/makeprotocol.pl.in

  Log Message:
  -----------
  Enable compiler error on classes with non-virtual destructors.

I found a serious problem where subclasses didn't clean up their resources
properly when destroyed, if they inherited from a parent class with a
non-virtual destructor. This caused BackupFileSystem's NamedLock not to be
released. This commit:

* fixes the error where it occurred;
* enables static checks for this error when compiled with GCC;
* promotes the resulting warnings to errors, to ensure that this problem
  cannot reoccur.


  Commit: 85fa92694aadc661e995311daa3a71e59eba3d93
      https://github.com/boxbackup/boxbackup/commit/85fa92694aadc661e995311daa3a71e59eba3d93
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-24 (Wed, 24 May 2017)

  Changed paths:
    M bin/bbackupquery/bbackupquery.cpp
    M lib/common/Box.h
    R lib/common/DebugPrintf.cpp
    M lib/server/Daemon.cpp
    M lib/server/ServerStream.h

  Log Message:
  -----------
  Remove unused code: BoxDebugTrace() and BoxDebug_printf()


  Commit: 338989aa8fd91a2480e1beab297ad6f880caa8c7
      https://github.com/boxbackup/boxbackup/commit/338989aa8fd91a2480e1beab297ad6f880caa8c7
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-25 (Thu, 25 May 2017)

  Changed paths:
    M infrastructure/buildenv-testmain-template.cpp
    M lib/common/Test.cpp
    M lib/common/Test.h

  Log Message:
  -----------
  Create a job object during Windows tests to kill abandoned daemons

Should prevent some cases of tests hanging on AppVeyor due to child
process daemons that were started and not stopped.

Delete files between tests using much more similar code (and the same
list) on Windows and Linux, to reduce risk of divergence causing tests
to pass on one and fail on the other.


  Commit: 7949f3f41528cdc30117d441c858276f5a4d2aaa
      https://github.com/boxbackup/boxbackup/commit/7949f3f41528cdc30117d441c858276f5a4d2aaa
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/win32/emu.cpp
    M lib/win32/emu.h
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Add a platform-independent implementation of box_strtoui64

Replaces strtoull(), which doesn't exist on older Windows compilers (MSVC <
12), and in any case doesn't necessarily return a uint64_t, so this is a better
interface.


  Commit: 3eca2a4b91eb8978c8061428fe28b5cb2a4e4f92
      https://github.com/boxbackup/boxbackup/commit/3eca2a4b91eb8978c8061428fe28b5cb2a4e4f92
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupAccountControl.h
    A lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupStoreException.txt
    M lib/backupstore/BackupStoreInfo.h

  Log Message:
  -----------
  Move S3BackupFileSystem class into its own file.

Create BackupFileSystem, an abstract interface for reading and writing
files and directories, abstracting over RaidFile, S3, FTP etc. as a parent
class for S3BackupFileSystem.


  Commit: 7acbeb239194bd8dc3b5cc49d0e224d715c6163c
      https://github.com/boxbackup/boxbackup/commit/7acbeb239194bd8dc3b5cc49d0e224d715c6163c
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/common/BoxException.h
    M lib/common/CollectInBufferStream.h
    M lib/common/makeexception.pl.in
    M lib/httpserver/HTTPException.txt
    M lib/httpserver/HTTPServer.cpp
    M lib/httpserver/S3Client.cpp
    M lib/httpserver/S3Simulator.cpp
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Improve exception handling in S3Simulator, S3Client and HTTPServer.

Centralise error response generation in S3Simulator, driven by throwing and
catching exceptions.

Improve error messages returned by HTTPServer.

Improve exception messages thrown by S3Client.

Add a method to BoxException to quickly check what type of exception it is,
and a macro to make this even shorter.

Show the exception type as well as subtype in GetMessage().


  Commit: 4be4985895d183c8e960d347910c8d440f200f06
      https://github.com/boxbackup/boxbackup/commit/4be4985895d183c8e960d347910c8d440f200f06
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M infrastructure/travis-build.sh

  Log Message:
  -----------
  Travis build script: add extra debugging.

This script can be useful as a shortcut for command-line builds, but not if you
forget to set TEST_TARGET, so now it errors if you do.


  Commit: f268e3d77d820677d272becac51f0fbb69b4a459
      https://github.com/boxbackup/boxbackup/commit/f268e3d77d820677d272becac51f0fbb69b4a459
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/backupstore/BackupStoreFile.cpp
    M lib/backupstore/BackupStoreFile.h
    M lib/server/TcpNice.cpp
    M lib/server/TcpNice.h

  Log Message:
  -----------
  Fix overloaded virtual function warnings.

Revealed by enabling the -Woverloaded-virtual compiler option.


  Commit: 6ab385c1b7d2dfb50910f01daeeac14a6584dd9f
      https://github.com/boxbackup/boxbackup/commit/6ab385c1b7d2dfb50910f01daeeac14a6584dd9f
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/common/Test.h
    M test/s3store/tests3store.cpp

  Log Message:
  -----------
  Refactor test/s3store to make check_new_account_info() reusable.

(cherry picked from commit 2f597e11ccf56129319851f767581de1055da53e)


  Commit: 1ea250b85ef074bd3a4c1802ffb511acb1a52c05
      https://github.com/boxbackup/boxbackup/commit/1ea250b85ef074bd3a4c1802ffb511acb1a52c05
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M bin/bbackupquery/bbackupquery.cpp
    M bin/bbstoreaccounts/bbstoreaccounts.cpp
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupStoreAccounts.cpp
    M lib/backupstore/BackupStoreCheck.h
    M lib/backupstore/BackupStoreRefCountDatabase.cpp
    M lib/backupstore/BackupStoreRefCountDatabase.h
    M lib/backupstore/HousekeepStoreAccount.h
    M lib/bbackupd/BackupClientContext.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp
    M lib/common/Configuration.cpp
    M lib/common/Configuration.h
    M lib/common/IOStream.cpp
    M lib/common/NamedLock.h
    M lib/common/ReadLoggingStream.cpp
    M lib/common/Utils.cpp
    M lib/common/ZeroStream.h
    M lib/httpserver/HTTPRequest.cpp

  Log Message:
  -----------
  Whitespace cleanup

(cherry picked from commit 88f7f4ef025a32680d0545571e0e5bdf9e0d5c3c)


  Commit: ab9d83cb893cef529242ac9296e5b13efe4b6da8
      https://github.com/boxbackup/boxbackup/commit/ab9d83cb893cef529242ac9296e5b13efe4b6da8
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/server/Daemon.cpp

  Log Message:
  -----------
  Fix warning about snprintf() being deprecated on Windows.

(cherry picked from commit eeb2a127fe1410a871f3943651fa363edff943d0)


  Commit: ead150c2057d06f0325d1df11a206d30dc40fdea
      https://github.com/boxbackup/boxbackup/commit/ead150c2057d06f0325d1df11a206d30dc40fdea
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/common/Test.cpp
    A lib/httpserver/HTTPHeaders.cpp
    A lib/httpserver/HTTPHeaders.h
    M lib/httpserver/HTTPQueryDecoder.cpp
    M lib/httpserver/HTTPQueryDecoder.h
    M lib/httpserver/HTTPRequest.cpp
    M lib/httpserver/HTTPRequest.h
    M lib/httpserver/HTTPResponse.cpp
    M lib/httpserver/HTTPResponse.h
    M lib/httpserver/S3Client.cpp
    M lib/httpserver/S3Simulator.cpp
    A test/httpserver/testfiles/dsfdsfs98.fd
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Refactor common HTTP header handling

Move the common code out of HTTPRequest and HTTPResponse into the new
HTTPHeaders class, a container for headers with some sensible HTTP-specific
behaviour.

(cherry picked from commit 546c0d068934e8fc5ba53f32bdf61b3a6841c65b)


  Commit: 1b4d294e3487eec1239b6fb8c6dce3b42ce6c25b
      https://github.com/boxbackup/boxbackup/commit/1b4d294e3487eec1239b6fb8c6dce3b42ce6c25b
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/common/GetLine.cpp
    M test/basicserver/testbasicserver.cpp

  Log Message:
  -----------
  Fix incorrect timeout calculation in GetLine

Attaching a debugger to a process waiting in GetLine would previously cause the
read() to return immediately with EINTR, which we never retried. Now it retries
until the original timeout has expired.

(cherry picked from commit e997d092ad75aac98b5814c1b24d3ac0f8ae8e4a)


  Commit: 50f57e54cfff225933248152e242f4885a28fc9a
      https://github.com/boxbackup/boxbackup/commit/50f57e54cfff225933248152e242f4885a28fc9a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M lib/common/Test.cpp
    A lib/httpserver/HTTPTest.cpp
    A lib/httpserver/HTTPTest.h
    A test/httpserver/testfiles/puppy.jpg
    M test/httpserver/testfiles/s3simulator.conf
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Add tests for S3Simulator and S3Client


  Commit: d627d482ce19d78fa1bbdbfb09a4b7d21f836eae
      https://github.com/boxbackup/boxbackup/commit/d627d482ce19d78fa1bbdbfb09a4b7d21f836eae
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M lib/crypto/MD5Digest.h
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Add MD5DigestStream and test

(cherry picked from commit 3f0538bf1a2115c399f09a1735e7e9f3b426737e)


  Commit: 79f9957b01d6f11153ccbb3303786ba2013c5435
      https://github.com/boxbackup/boxbackup/commit/79f9957b01d6f11153ccbb3303786ba2013c5435
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M lib/httpserver/S3Simulator.cpp
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Refactor S3Simulator to better support merge of SimpleDB support

(cherry picked from commit 35b581b3ac54769f5b343c995435a7c7b15041e7)


  Commit: 4d5027593accf14be6310129fbb592fd865a4d68
      https://github.com/boxbackup/boxbackup/commit/4d5027593accf14be6310129fbb592fd865a4d68
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    R lib/backupclient/BackupStoreObjectDump.cpp
    A lib/backupstore/BackupStoreObjectDump.cpp

  Log Message:
  -----------
  Move BackupStoreObjectDump.cpp to lib/backupstore

It doesn't depend on anything in lib/backupclient, so there's no need for it to
be there.

(cherry picked from commit 85fda42a5164cc574b9a9b0335d0cb14bbb802b0)


  Commit: dedb10ff690159b5090a836bf65b996c06a40a62
      https://github.com/boxbackup/boxbackup/commit/dedb10ff690159b5090a836bf65b996c06a40a62
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M test/bbackupd/testbbackupd.cpp

  Log Message:
  -----------
  Remove unused intercept code from testbbackupd.

(cherry picked from commit 56631b8da4f8f22f291323d640560aca43f32b29)


  Commit: 1e390cc69aa7fcbca0619b83153379acb04c0a7d
      https://github.com/boxbackup/boxbackup/commit/1e390cc69aa7fcbca0619b83153379acb04c0a7d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M lib/backupstore/BackupStoreContext.cpp
    M lib/common/CommonException.txt
    M lib/common/IOStream.cpp
    M lib/common/IOStream.h
    M lib/server/Protocol.cpp

  Log Message:
  -----------
  Make IOStream::CopyStreamTo honour timeout

Throw an exception on network timeout.  This is safer than returning false,
which isn't checked in many places, and allows us to return the number of bytes
copied instead.

(cherry picked from commit e38d3d771ebb303e75e635e618f4d1e41370aa23)


  Commit: 6a997ed7686277a8f44ea2968ce0c51e7b0b71af
      https://github.com/boxbackup/boxbackup/commit/6a997ed7686277a8f44ea2968ce0c51e7b0b71af
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M lib/common/CollectInBufferStream.cpp

  Log Message:
  -----------
  Add an assertion to CollectInBufferStream

Ensure that we don't try to write a negative number of bytes.

(cherry picked from commit 755242a46275384592281878ad6cce8dc7883be7)


  Commit: 5b065e61bfa7ff7f43aca008a127b7a7fb219840
      https://github.com/boxbackup/boxbackup/commit/5b065e61bfa7ff7f43aca008a127b7a7fb219840
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M lib/httpserver/S3Client.cpp

  Log Message:
  -----------
  Remove unwanted prototype for HeadObject()

(cherry picked from commit 71d3d970b00ee85408e8ea5166fe46fdbac82ce1)


  Commit: f7f735cbf0c5753783c953d63093501121e46b32
      https://github.com/boxbackup/boxbackup/commit/f7f735cbf0c5753783c953d63093501121e46b32
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M lib/httpserver/HTTPResponse.cpp
    M lib/httpserver/HTTPResponse.h
    M lib/httpserver/HTTPServer.cpp
    M lib/httpserver/HTTPServer.h

  Log Message:
  -----------
  Allow control of network timeout in HTTPResponse::Send()

(cherry picked from commit aabb13634e2ef79eb2843f8ab2f0cbd7be267c38)


  Commit: ac52f3265bf9c87ad6625f04d2365be37e2306a1
      https://github.com/boxbackup/boxbackup/commit/ac52f3265bf9c87ad6625f04d2365be37e2306a1
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M lib/httpserver/S3Client.cpp

  Log Message:
  -----------
  Log every request made using S3Client (for now)

(cherry picked from commit 699a70598942c1422f568843176542b9b302c1dd)


  Commit: 0bcc72208e1c3a8cc05360f73b27dafc71df3cc0
      https://github.com/boxbackup/boxbackup/commit/0bcc72208e1c3a8cc05360f73b27dafc71df3cc0
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M lib/httpserver/S3Client.cpp

  Log Message:
  -----------
  Add initial (non-functioning) keepalive support in S3Client

(cherry picked from commit 3c62a5be57e0a7b7100b44c41cc8c69c20c92fa9)


  Commit: 98b7796ce9bb83f0fcdf01612fd1c65532459801
      https://github.com/boxbackup/boxbackup/commit/98b7796ce9bb83f0fcdf01612fd1c65532459801
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-02 (Fri, 02 Jun 2017)

  Changed paths:
    M lib/backupstore/BackupAccountControl.h
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M test/s3store/tests3store.cpp

  Log Message:
  -----------
  Fix confusion about URIs and paths in S3 filesystem

* Make it clear (with parameter names and comments) which functions take paths
  (relative to the configured base path), which functions take URIs (complete
  paths) and which functions take URLs (hostname, port and URI).

* Put all objects (files and directories) in the same "directory" tree on S3,
  so that we can list them all together and easily identify the type of each
  object (from its extension). Previously they were separated into "directories"
  (delimited prefixes) called "files" and "dirs" (unlike BackupStore
  filesystems).

* Reinstate hierarchical "directories" on S3, similar to BackupStore
  filesystems, since the reasons for doing this in RaidFile may well apply to S3
  and other compatible stores too. However the objects are still named with
  their complete object ID (unlike RaidFile) and a .file or .dir extension.

(cherry picked from commit 3dd21a3028cacea2ecf6ee3de2f32db3c5138589)


  Commit: 2e9c90d3f32c69cc89d01fb64ced9fca80aae985
      https://github.com/boxbackup/boxbackup/commit/2e9c90d3f32c69cc89d01fb64ced9fca80aae985
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-02 (Fri, 02 Jun 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Fix quoting of CXXFLAGS and LDFLAGS in Makefiles

Previously, it was impossible to include an @ sign in these flags (for example,
to link to support --with-ssl-headers=/usr/local/opt/openssl at 1.1/include/)
because it was interpreted as a list variable name by Perl. Now the variables
are evaluated single-quoted before being substituted into the Makefile output.


  Commit: f449986b68bd12c18d742c91b625779ae75b11a2
      https://github.com/boxbackup/boxbackup/commit/f449986b68bd12c18d742c91b625779ae75b11a2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-03 (Sat, 03 Jun 2017)

  Changed paths:
    M lib/crypto/Random.cpp

  Log Message:
  -----------
  Replace RAND_pseudo_bytes with RAND_bytes

RAND_pseudo_bytes is less secure and is now deprecated.


  Commit: 750e35a7e499089ab9f3ed2215bfaab84f2f70e2
      https://github.com/boxbackup/boxbackup/commit/750e35a7e499089ab9f3ed2215bfaab84f2f70e2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupAccountControl.h
    M lib/backupstore/BackupStoreAccounts.cpp
    M lib/backupstore/BackupStoreAccounts.h

  Log Message:
  -----------
  Move BackupStoreAccountControl code to BackupAccountControl file

(cherry picked from commit 2891416b675cdc346713a26c6e357fba302bbc89)


  Commit: f785fa6a3ba9e7e96813f94b7f2baa093e32e34a
      https://github.com/boxbackup/boxbackup/commit/f785fa6a3ba9e7e96813f94b7f2baa093e32e34a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M .travis.yml
    M infrastructure/cmake/CMakeLists.txt
    A infrastructure/m4/ax_boost_base.m4
    M infrastructure/m4/boxbackup_tests.m4

  Log Message:
  -----------
  Add Boost, needed for XML support in S3Simulator and S3Client

Boost will be needed on all platforms for S3 support at least. It's currently
mandatory, but could be made optional if necessary. XML support of some kind is
required both for S3's ListBucket command (which returns XML) and for SimpleDB
support in the S3Simulator, since the SimpleDB API uses XML.

I considered alternative XML libraries to Boost:

* https://stackoverflow.com/questions/170686/what-is-the-best-open-xml-parser-for-c
* https://stackoverflow.com/questions/9387610/what-xml-parser-should-i-use-in-c

The most commonly used one (libxml2) is huge, ugly, slow and hard to use, and
we don't need any of the extra features.  TinyXML would meet our needs, but
Boost is more likely to be available on more platforms, is well respected, and
brings other (unrelated) features that we might want to use in future.

(cherry picked from commit 1a9deec05151281e840b7df5a1244453c0111042)


  Commit: 992af0c9c7b298827acd2371819c46cfb0b2a676
      https://github.com/boxbackup/boxbackup/commit/992af0c9c7b298827acd2371819c46cfb0b2a676
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M lib/httpserver/cdecode.cpp

  Log Message:
  -----------
  Declare Base64 decoding array as signed char

Need to use "signed char" explicitly to work around char being unsigned by
default on ARM, causing compile errors:
https://stackoverflow.com/a/31635045/648162


  Commit: 3433291fc5bfbbdc87385796c26c44699edf5c0c
      https://github.com/boxbackup/boxbackup/commit/3433291fc5bfbbdc87385796c26c44699edf5c0c
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M infrastructure/m4/boxbackup_tests.m4

  Log Message:
  -----------
  Make narrowing conversions an error

E.g. on ARM64 with unsigned chars, this is a real error, and causes the build
to fail:
https://buildd.debian.org/status/fetch.php?pkg=boxbackup&arch=arm64&ver=0.11.1~r2837-4&stamp=1485057548&raw=0


  Commit: 61a8e7514e01bc05ea3ea77d110c16bff37a50f4
      https://github.com/boxbackup/boxbackup/commit/61a8e7514e01bc05ea3ea77d110c16bff37a50f4
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M lib/common/Logging.h
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Increase logging level and add timestamps in testcommon

Should help to debug frequent test failures such as Condition
[t2.HasExpired()] on OSX hosts on Travis.


  Commit: 8f9d9db0f0bf0f231eb90b0e45b5ef60afd5ed24
      https://github.com/boxbackup/boxbackup/commit/8f9d9db0f0bf0f231eb90b0e45b5ef60afd5ed24
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-24 (Sat, 24 Jun 2017)

  Changed paths:
    M .travis.yml
    M appveyor.yml
    M infrastructure/buildenv-testmain-template.cpp
    M infrastructure/cmake/CMakeLists.txt
    M infrastructure/m4/boxbackup_tests.m4
    M infrastructure/makebuildenv.pl.in
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupAccountControl.h
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupStoreAccounts.cpp
    M lib/backupstore/BackupStoreAccounts.h
    M lib/backupstore/BackupStoreException.txt
    M lib/backupstore/BackupStoreInfo.h
    M lib/common/GetLine.cpp
    M lib/common/Test.cpp
    M lib/crypto/Random.cpp
    M lib/httpserver/HTTPRequest.h
    A lib/httpserver/HTTPTest.cpp
    A lib/httpserver/HTTPTest.h
    M lib/httpserver/cdecode.cpp
    M lib/server/Daemon.cpp
    M lib/server/Protocol.cpp
    M lib/win32/emu.cpp
    M test/basicserver/testbasicserver.cpp
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Merge branch 's3_support_merge' into s3_support


  Commit: ef99b539822d6d4792a0ef647c43bd9f007a3c79
      https://github.com/boxbackup/boxbackup/commit/ef99b539822d6d4792a0ef647c43bd9f007a3c79
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-24 (Sat, 24 Jun 2017)

  Changed paths:
    M infrastructure/cmake/CMakeLists.txt
    M infrastructure/m4/boxbackup_tests.m4
    M lib/intercept/intercept.h

  Log Message:
  -----------
  Merge branch 's3_support' of github.com:boxbackup/boxbackup into s3_support


  Commit: 0cf64c868bfc5027e06bdcf0ea71c13a5528a105
      https://github.com/boxbackup/boxbackup/commit/0cf64c868bfc5027e06bdcf0ea71c13a5528a105
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M infrastructure/m4/ax_check_dirent_d_type.m4

  Log Message:
  -----------
  Fix check for a working struct dirent.d_type

Which I broke in 2007 and never noticed was broken until now. Oops!


  Commit: 2ad9ee9012d4a7354c33ff0272c0768b952a9064
      https://github.com/boxbackup/boxbackup/commit/2ad9ee9012d4a7354c33ff0272c0768b952a9064
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Don't add CXXFLAGS to CFLAGS

Some CXXFLAGS such as enabling C++11 don't make sense for CC and will be
rejected, causing the compile to fail. We don't really test for flags being
compatible with the C compiler anyway, and we don't have enough C files to
care that much.


  Commit: 14cb7cded7157c31e65f106f6043d71b99b97c2e
      https://github.com/boxbackup/boxbackup/commit/14cb7cded7157c31e65f106f6043d71b99b97c2e
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Compile fix for S3BackupFileSystem::GetObjectURI const-ness


  Commit: 1df1e5ff8eba141d550fee1f847c6520705c2912
      https://github.com/boxbackup/boxbackup/commit/1df1e5ff8eba141d550fee1f847c6520705c2912
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M lib/backupstore/BackupStoreFileEncodeStream.cpp
    M lib/backupstore/BackupStoreFileEncodeStream.h

  Log Message:
  -----------
  Compile fix: remove unused private members

This was recently promoted from a warning to an error.


  Commit: c71f02d0aca1bf0f4a98a73c7dffe84388477986
      https://github.com/boxbackup/boxbackup/commit/c71f02d0aca1bf0f4a98a73c7dffe84388477986
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M lib/common/BoxPlatform.h
    M lib/intercept/intercept.h
    M test/raidfile/testraidfile.cpp

  Log Message:
  -----------
  Enable and fix raidfile intercepts on Mac OSX


  Commit: fd0825c0937f64027084a2277157d2505d9509c9
      https://github.com/boxbackup/boxbackup/commit/fd0825c0937f64027084a2277157d2505d9509c9
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M lib/common/Test.cpp
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Fix incorrectly merged changes to make tests pass again


  Commit: 1868268f914eccfa8f2e71fb612520ffed51e4d1
      https://github.com/boxbackup/boxbackup/commit/1868268f914eccfa8f2e71fb612520ffed51e4d1
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M lib/httpserver/S3Client.h

  Log Message:
  -----------
  Add comments to explain the three S3Client constructors


  Commit: 4ad5f2b9c368f3efcd5a522c6c077b49be2b6574
      https://github.com/boxbackup/boxbackup/commit/4ad5f2b9c368f3efcd5a522c6c077b49be2b6574
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-25 (Sun, 25 Jun 2017)

  Changed paths:
    M lib/raidfile/RaidFileRead.cpp
    M lib/raidfile/RaidFileRead.h

  Log Message:
  -----------
  Use a named enum type for DirReadType (RaidFileRead::ReadDirectoryContents)

Allows checking for valid values at compile time, and allows the debugger to
show the symbolic constant instead of just its numeric value.


Compare: https://github.com/boxbackup/boxbackup/compare/a042c9951fab...4ad5f2b9c368


More information about the Boxbackup-commit mailing list