[Box Backup-commit] [boxbackup/boxbackup] 992af0: Declare Base64 decoding array as signed char

GitHub noreply at github.com
Sun Jun 25 20:34:45 BST 2017


  Branch: refs/heads/s3_support_merge
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 992af0c9c7b298827acd2371819c46cfb0b2a676
      https://github.com/boxbackup/boxbackup/commit/992af0c9c7b298827acd2371819c46cfb0b2a676
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M lib/httpserver/cdecode.cpp

  Log Message:
  -----------
  Declare Base64 decoding array as signed char

Need to use "signed char" explicitly to work around char being unsigned by
default on ARM, causing compile errors:
https://stackoverflow.com/a/31635045/648162


  Commit: 3433291fc5bfbbdc87385796c26c44699edf5c0c
      https://github.com/boxbackup/boxbackup/commit/3433291fc5bfbbdc87385796c26c44699edf5c0c
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M infrastructure/m4/boxbackup_tests.m4

  Log Message:
  -----------
  Make narrowing conversions an error

E.g. on ARM64 with unsigned chars, this is a real error, and causes the build
to fail:
https://buildd.debian.org/status/fetch.php?pkg=boxbackup&arch=arm64&ver=0.11.1~r2837-4&stamp=1485057548&raw=0


Compare: https://github.com/boxbackup/boxbackup/compare/f785fa6a3ba9...3433291fc5bf


More information about the Boxbackup-commit mailing list