[Box Backup-commit] [boxbackup/boxbackup] 9b01ec: Backport whitespace and comment fixes from s3_supp...

GitHub noreply at github.com
Fri Nov 10 20:31:27 GMT 2017


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 9b01ec2df907be0b66d6e59c201fec6fa0faf85a
      https://github.com/boxbackup/boxbackup/commit/9b01ec2df907be0b66d6e59c201fec6fa0faf85a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M LICENSE.txt
    M contrib/windows/installer/tools/RestartService.bat
    M contrib/windows/installer/tools/ShowUsage.bat
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp
    M lib/backupstore/StoreTestUtils.cpp
    M lib/backupstore/StoreTestUtils.h
    M lib/bbackupd/BackupClientContext.cpp
    M lib/common/DebugMemLeakFinder.cpp
    M lib/common/Utils.cpp
    M lib/common/Utils.h
    M lib/httpserver/HTTPQueryDecoder.cpp
    M lib/httpserver/S3Client.cpp
    M lib/httpserver/S3Simulator.cpp
    M lib/server/makeprotocol.pl.in
    M runtest.pl.in
    M test/backupstore/testbackupstore.cpp
    M test/backupstorepatch/testbackupstorepatch.cpp

  Log Message:
  -----------
  Backport whitespace and comment fixes from s3_support_merge


  Commit: 63812895e4818eecaa6b6cb999aed0d03f410ce7
      https://github.com/boxbackup/boxbackup/commit/63812895e4818eecaa6b6cb999aed0d03f410ce7
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Test that 100-continue headers are sent and received correctly

This tests that HTTPRequest::SendHeaders includes the "Expect: 100-continue"
header only when expected. A separate test calls HTTPRequest::SendWithStream
which sends these headers, and therefore checks that both sides correctly
handle such exchanges.

(cherry picked from commit 5fad0fd1cb9a1a39756de69ce9348ca692e35bda)


  Commit: 14bf1e0f91471fee46c3e0ba60f0bfbceddcebc3
      https://github.com/boxbackup/boxbackup/commit/14bf1e0f91471fee46c3e0ba60f0bfbceddcebc3
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/common/DebugMemLeakFinder.cpp
    M lib/common/MemLeakFinder.h

  Log Message:
  -----------
  Implement placement operator delete

"If the object is being created as part of a new expression, and an exception
is thrown, the object’s memory is deallocated by calling the appropriate
deallocation function. If the object is being created with a placement new
operator, the corresponding placement delete operator is called—that is, the
delete function that takes the same additional parameters as the placement new
operator. If no matching placement delete is found, no deallocation takes
place."

So to avoid memory leaks, we need to implement placement delete operators that
correspond to our placement new, which we use for leak detection (ironically)
in debug builds.

(cherry picked from commit 40cf96207139a31466b98a93298cef4f436eea6b)


  Commit: 2347ad69136f36eb86651dfef96ce8a94fffecd6
      https://github.com/boxbackup/boxbackup/commit/2347ad69136f36eb86651dfef96ce8a94fffecd6
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupCommands.cpp
    M lib/backupstore/StoreTestUtils.cpp
    M lib/httpserver/S3Client.cpp
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Fix a long-standing bug in the set_refcount() test helper function

Previously it would truncate the expected refcount list at the first zero entry,
instead of just removing zero entries from the end.

Also move some test code to test_server_commands which should have been there,
since they were causing issues with the check for the refcount database in
test_server_housekeeping. It's hard to disentangle these two changes.

Also disconnect from the HTTP server in S3Client if we receive an exception on
reading, since the connection is no longer known to be in a clean state.

(cherry picked from commit 0ab2508cfd01a32dc39ce689d5b6b7e58a460e38)
(cherry picked from commit b91cdf14c5459f03076ee3668ef4a9c2b78f2227)


  Commit: 0d7b68967e7047e407ecc7cc7c39215f71390775
      https://github.com/boxbackup/boxbackup/commit/0d7b68967e7047e407ecc7cc7c39215f71390775
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  Fix rare crash while tearing down S3BackupFileSystem

ReleaseLock() could fail if it can't contact the S3/SimpleDB server, but
destructors aren't allowed to throw exceptions, so catch this case and log
a warning instead (because we failed to release the lock that we were
holding).


  Commit: 59b2200144dafe7323659696e65c0d9fff9e0912
      https://github.com/boxbackup/boxbackup/commit/59b2200144dafe7323659696e65c0d9fff9e0912
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/server/ServerStream.h

  Log Message:
  -----------
  Improve exception handling in single-process servers

Don't allow an uncaught exception to kill the whole server. This makes it
consistent with multi-process servers, where death of a child worker does
not stop the main server process, so it continues to serve requests.

This makes the HTTPServer robust to exceptions (such as the child
disconnecting while the server is streaming a response) on Windows.


  Commit: a4e96ca4fe412a3d3e51e05f37a2155a3cb1f2fd
      https://github.com/boxbackup/boxbackup/commit/a4e96ca4fe412a3d3e51e05f37a2155a3cb1f2fd
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/win32/emu.cpp

  Log Message:
  -----------
  Windows syslog() emulation: improve error messages

If syslog can't log to the Windows event log for some reason, instead of
just printing the log message to the console, include some explanatory
text about what went wrong.


  Commit: 2057c776c97ee5dbe9e8abeec2b44640a6ee5d77
      https://github.com/boxbackup/boxbackup/commit/2057c776c97ee5dbe9e8abeec2b44640a6ee5d77
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M infrastructure/buildenv-testmain-template.cpp

  Log Message:
  -----------
  Completely disable syslog logging in tests


  Commit: 65cb82b4d9b23d7d3b2acb9a1cde7bf3f5f33047
      https://github.com/boxbackup/boxbackup/commit/65cb82b4d9b23d7d3b2acb9a1cde7bf3f5f33047
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h

  Log Message:
  -----------
  Enable overriding log level by category as well as filename

This extends the -L command-line option to allow overriding by
filename/category=level as well as the existing support for overriding by
filename=level.


  Commit: 96c02063785888ff3575ab513f6b772665728127
      https://github.com/boxbackup/boxbackup/commit/96c02063785888ff3575ab513f6b772665728127
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/server/SocketStream.cpp

  Log Message:
  -----------
  SocketStream: use THROW_SOCKET_ERROR for better messages on Windows


  Commit: d3b06885b3f94baf9f1c2aa5b8d7fe45d330555b
      https://github.com/boxbackup/boxbackup/commit/d3b06885b3f94baf9f1c2aa5b8d7fe45d330555b
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/httpserver/S3Client.h

  Log Message:
  -----------
  Increase timeouts in S3Client to help with debugging


  Commit: 04406959c06293632d10131221d6997fba90fcfc
      https://github.com/boxbackup/boxbackup/commit/04406959c06293632d10131221d6997fba90fcfc
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/httpserver/S3Simulator.cpp

  Log Message:
  -----------
  S3Simulator: add some TRACE logging to help debug 100-continue responses


  Commit: c74f77f407faba2e01a041de55ad476859a5f566
      https://github.com/boxbackup/boxbackup/commit/c74f77f407faba2e01a041de55ad476859a5f566
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/server/ServerStream.h
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  ServerStream and test/backupstore: improve comments slightly


  Commit: 24971df3f71874eabdf837daa4e4d6aa2a6718ce
      https://github.com/boxbackup/boxbackup/commit/24971df3f71874eabdf837daa4e4d6aa2a6718ce
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupStoreContext.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp
    M lib/bbstored/BackupStoreDaemon.cpp
    M lib/server/Daemon.cpp
    M lib/server/Daemon.h
    M lib/server/ServerStream.h

  Log Message:
  -----------
  Clear up Daemon command-line arguments -D and -F

By separating their roles (which used to overlap) it's now possible to run a
forking server in the foreground, or a non-forking daemon in the background,
which can be useful for debugging (for example, to more closely simulate how
test daemons work on Windows when running on Unix). -DF is now needed to
have a non-forking server in the foreground.


  Commit: b02eecbd1a9f0c5ebb493237ded190e8d0712263
      https://github.com/boxbackup/boxbackup/commit/b02eecbd1a9f0c5ebb493237ded190e8d0712263
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M lib/httpserver/SimpleDBClient.h

  Log Message:
  -----------
  Fix SimpleDB timeouts: should be in milliseconds, not seconds


Compare: https://github.com/boxbackup/boxbackup/compare/fbdd36ce3e48...b02eecbd1a9f


More information about the Boxbackup-commit mailing list