[Box Backup-commit] [boxbackup/boxbackup] 2111c2: Generalise BackupFileSystem::GetLock and reuse it

GitHub noreply at github.com
Tue Nov 14 22:24:40 GMT 2017


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 2111c2503865e1dcbad0332e2ac61f277b029cf1
      https://github.com/boxbackup/boxbackup/commit/2111c2503865e1dcbad0332e2ac61f277b029cf1
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-14 (Tue, 14 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp

  Log Message:
  -----------
  Generalise BackupFileSystem::GetLock and reuse it

This reduces code duplication (multiple implementations of locking retries) and
also enables centralised logging of locking attempts, which can be more easily
fine-tuned.


  Commit: c5f42ffdca5ccef53ed767d32b07c7a1d5626ed5
      https://github.com/boxbackup/boxbackup/commit/c5f42ffdca5ccef53ed767d32b07c7a1d5626ed5
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-14 (Tue, 14 Nov 2017)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h

  Log Message:
  -----------
  Allow using LogLevelOverrideByFileGuard as a guard

After calling its Install() method, the guard will be installed in the central
logging configuration, and will automatically be uninstalled when the object
goes out of scope and is destroyed.


  Commit: f03fdc9472d6ef803675fe007f9db480486024ff
      https://github.com/boxbackup/boxbackup/commit/f03fdc9472d6ef803675fe007f9db480486024ff
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-14 (Tue, 14 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Add detailed logging of BackupFileSystem locks

This logging is categorised, so it can be enabled with fine-tuning using the -L
command-line option.


  Commit: 958ef9170ddaeee369d3710c20db048be54434f3
      https://github.com/boxbackup/boxbackup/commit/958ef9170ddaeee369d3710c20db048be54434f3
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-14 (Tue, 14 Nov 2017)

  Changed paths:
    M test/backupstorefix/testbackupstorefix.cpp

  Log Message:
  -----------
  Enable detailed logging of locking in test/backupstorefix

This should help diagnose occasional locking problems causing test failures on
AppVeyor.


Compare: https://github.com/boxbackup/boxbackup/compare/01a6f1b9625d...958ef9170dda


More information about the Boxbackup-commit mailing list