[Box Backup-commit] [boxbackup/boxbackup] 3bba78: Refactor GetLine

GitHub noreply at github.com
Fri Nov 17 21:43:12 GMT 2017


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 3bba7804e1868dd56245b5601c4a59acad93c043
      https://github.com/boxbackup/boxbackup/commit/3bba7804e1868dd56245b5601c4a59acad93c043
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M bin/bbackupctl/bbackupctl.cpp
    M bin/bbackupquery/bbackupquery.cpp
    M lib/bbackupd/BackupDaemon.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp
    M lib/common/CommonException.txt
    M lib/common/FdGetLine.cpp
    M lib/common/FdGetLine.h
    R lib/common/GetLine.cpp
    R lib/common/GetLine.h
    M lib/common/IOStream.cpp
    M lib/common/IOStreamGetLine.cpp
    M lib/common/IOStreamGetLine.h
    A lib/common/LineBuffer.cpp
    A lib/common/LineBuffer.h
    M lib/httpserver/HTTPException.txt
    M lib/httpserver/HTTPHeaders.cpp
    M lib/httpserver/HTTPRequest.cpp
    M lib/httpserver/HTTPResponse.cpp
    M lib/httpserver/S3Simulator.cpp
    M lib/httpserver/S3Simulator.h
    M lib/server/ServerControl.cpp
    M lib/server/SocketStream.cpp
    M test/backupstorefix/testbackupstorefix.cpp
    M test/basicserver/testbasicserver.cpp
    M test/bbackupd/testbbackupd.cpp
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Refactor GetLine

The class name was a problem, because the method that we want to call on it is
also called GetLine, which looks too much like a constructor in C++, so I
renamed it to LineBuffer.  I haven't yet renamed the child classes.

Also, it was impossible to distinguish between the different causes of
GetLine() returning false (timeout and signal) and EOF could only be checked by
calling a different function. Now all of these causes throw different
exceptions.

This really fixes the problem with attaching a debugger to a process waiting in
GetLine, which would previously cause the read() to return immediately with
EINTR, which we never retried because it looked like a timeout.

(cherry picked from commit 20ce9cabcdf180d2063f1d40f402289bf0601887)


  Commit: 4fba570127d8d70579e0e36370e58b61a80680c0
      https://github.com/boxbackup/boxbackup/commit/4fba570127d8d70579e0e36370e58b61a80680c0
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Disable test_multiple_uploads for now, to keep Travis green


  Commit: defd9eec04e7f282c9c3cca5257f8b75cdfe1528
      https://github.com/boxbackup/boxbackup/commit/defd9eec04e7f282c9c3cca5257f8b75cdfe1528
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Enable and fix warnings in infrastructure/makebuildenv.pl

(cherry picked from commit 3209e5a9f5b3f379a7b833b304932c77a2deabce)


  Commit: 686816f832a5270400691f66db2431065bb0a53e
      https://github.com/boxbackup/boxbackup/commit/686816f832a5270400691f66db2431065bb0a53e
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Fix Makefile dependency tracking of configured files

This allows protocol files to be regenerated automatically if
makeprotocol.pl.in changes, and similarly exception files and
makeexception.pl.in.

(cherry picked from commit 994526017764f89d7759de30988a81582dcada1d)


  Commit: 0be86e96133cf3eb6f9f7efa155e8790bec6093c
      https://github.com/boxbackup/boxbackup/commit/0be86e96133cf3eb6f9f7efa155e8790bec6093c
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Add full test-case support to testcommon.


  Commit: 74675bbb743a5bb2bd11c03f6da9979c3dcc2fe2
      https://github.com/boxbackup/boxbackup/commit/74675bbb743a5bb2bd11c03f6da9979c3dcc2fe2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Fix 61a8e7514e


  Commit: 20cb7643b0598c89fe315181af5756c4c4fbaaeb
      https://github.com/boxbackup/boxbackup/commit/20cb7643b0598c89fe315181af5756c4c4fbaaeb
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M infrastructure/cmake/CMakeLists.txt
    M infrastructure/m4/boxbackup_tests.m4
    M lib/intercept/intercept.cpp

  Log Message:
  -----------
  Fix incorrect detection of the need to intercept lxstat

For some reason, #if defined __GNUC__ && __GNUC__ >= 2 was true on OSX,
resulting in intercepts not working properly.  It was also broken on MIPS64,
causing test/raidfile to fail with errors like: TEST FAILURE: Condition
[TestGetFileSize(stripe1fn) == fs1] failed at testraidfile.cpp:415

https://buildd.debian.org/status/fetch.php?pkg=boxbackup&arch=mips64el&ver=0.11.1~r2837-4&stamp=1485060478&raw=0

Now we detect when to intercept Linux' lxstat syscall using autoconf macros.
We also detect whether to intercept stat64 (instead of stat) based on whether
the stat64 function exists.

This was originally cherry-picked from commit
a042c9951fabc1fb4f57e6d13d739192dda76025, but additional fixes were made in
784fe4320f70c125f8d24d02f195e30064e09ab3 which I'm hereby backporting to the
s3_support branch to fix the raidfile tests on OSX.


  Commit: d0f88e70f9c841bf2f8baedb89ec28523b2e357d
      https://github.com/boxbackup/boxbackup/commit/d0f88e70f9c841bf2f8baedb89ec28523b2e357d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  Fix compile failure due to unused private field

In CMake release builds, RaidBackupFileSystem::mDiscSet was initialized but
never read, and this was detected by -Werror,-Wunused-private-field.

Now the field is totally compiled out of release builds, and by using the
correct preprocessor define, CMake and the Perl buildsystem now behave the
same.


  Commit: 78d2a5f69cf0318806520b208300a91a5507102d
      https://github.com/boxbackup/boxbackup/commit/78d2a5f69cf0318806520b208300a91a5507102d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/raidfile/RaidFileWrite.cpp

  Log Message:
  -----------
  Use native file locking when opening RaidFiles for writing on Windows


  Commit: ee2ca8af131d8ceeb984c39751b0c21e06d6b7c2
      https://github.com/boxbackup/boxbackup/commit/ee2ca8af131d8ceeb984c39751b0c21e06d6b7c2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Fix test_multiple_uploads(store) failure on Windows

Was due to not releasing a stream sufficiently early, which was keeping
open a file handle to the RaidFile that we were about to rewrite (thus
renaming over it), which therefore failed.


  Commit: 4a751b0a33424855fe3405a611fe2544c95f1eb6
      https://github.com/boxbackup/boxbackup/commit/4a751b0a33424855fe3405a611fe2544c95f1eb6
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M LICENSE.txt
    M contrib/windows/installer/bbackupd.conf.template
    M contrib/windows/installer/tools/InstallService.bat
    M contrib/windows/installer/tools/KillBackupProcess.bat
    M contrib/windows/installer/tools/QueryOutputAll.bat
    M contrib/windows/installer/tools/QueryOutputCurrent.bat
    M contrib/windows/installer/tools/ReloadConfig.bat
    M contrib/windows/installer/tools/RemoveService.bat
    M contrib/windows/installer/tools/RestartService.bat
    M contrib/windows/installer/tools/ShowUsage.bat
    M contrib/windows/installer/tools/StartService.bat
    M contrib/windows/installer/tools/StopService.bat
    M contrib/windows/installer/tools/Sync.bat
    M docs/xsl-generic/highlighting/common.xsl
    M docs/xsl-generic/highlighting/xslthl-config.xml
    M docs/xsl-generic/html/highlight.xsl
    M lib/backupstore/BackupAccountControl.cpp
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp
    M lib/backupstore/StoreTestUtils.cpp
    M lib/backupstore/StoreTestUtils.h
    M lib/bbackupd/BackupClientContext.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp
    M lib/common/DebugMemLeakFinder.cpp
    M lib/common/Utils.cpp
    M lib/common/Utils.h
    M lib/httpserver/HTTPQueryDecoder.cpp
    M lib/httpserver/S3Client.cpp
    M lib/httpserver/S3Simulator.cpp
    M lib/server/makeprotocol.pl.in
    M runtest.pl.in
    M test/backupstore/testbackupstore.cpp
    M test/backupstorepatch/testbackupstorepatch.cpp

  Log Message:
  -----------
  Backport whitespace and comment fixes from s3_support_merge


  Commit: cfb76c5ca96268ada9d1174ae8d7286060c2ba70
      https://github.com/boxbackup/boxbackup/commit/cfb76c5ca96268ada9d1174ae8d7286060c2ba70
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M test/httpserver/testhttpserver.cpp

  Log Message:
  -----------
  Test that 100-continue headers are sent and received correctly

This tests that HTTPRequest::SendHeaders includes the "Expect: 100-continue"
header only when expected. A separate test calls HTTPRequest::SendWithStream
which sends these headers, and therefore checks that both sides correctly
handle such exchanges.

(cherry picked from commit 5fad0fd1cb9a1a39756de69ce9348ca692e35bda)


  Commit: 242fac41c63309f274992825cd0baef9046e1110
      https://github.com/boxbackup/boxbackup/commit/242fac41c63309f274992825cd0baef9046e1110
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/common/DebugMemLeakFinder.cpp
    M lib/common/MemLeakFinder.h

  Log Message:
  -----------
  Implement placement operator delete

"If the object is being created as part of a new expression, and an exception
is thrown, the object’s memory is deallocated by calling the appropriate
deallocation function. If the object is being created with a placement new
operator, the corresponding placement delete operator is called—that is, the
delete function that takes the same additional parameters as the placement new
operator. If no matching placement delete is found, no deallocation takes
place."

So to avoid memory leaks, we need to implement placement delete operators that
correspond to our placement new, which we use for leak detection (ironically)
in debug builds.

(cherry picked from commit 40cf96207139a31466b98a93298cef4f436eea6b)


  Commit: bdf80acc51be67c5bead3ba6b9f1cedee0b82339
      https://github.com/boxbackup/boxbackup/commit/bdf80acc51be67c5bead3ba6b9f1cedee0b82339
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupCommands.cpp
    M lib/backupstore/StoreTestUtils.cpp
    M lib/httpserver/S3Client.cpp
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Fix a long-standing bug in the set_refcount() test helper function

Previously it would truncate the expected refcount list at the first zero entry,
instead of just removing zero entries from the end.

Also move some test code to test_server_commands which should have been there,
since they were causing issues with the check for the refcount database in
test_server_housekeeping. It's hard to disentangle these two changes.

Also disconnect from the HTTP server in S3Client if we receive an exception on
reading, since the connection is no longer known to be in a clean state.

(cherry picked from commit 0ab2508cfd01a32dc39ce689d5b6b7e58a460e38)
(cherry picked from commit b91cdf14c5459f03076ee3668ef4a9c2b78f2227)


  Commit: 36ad612873be57c6795bf694d2626bcf88689345
      https://github.com/boxbackup/boxbackup/commit/36ad612873be57c6795bf694d2626bcf88689345
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  Fix rare crash while tearing down S3BackupFileSystem

ReleaseLock() could fail if it can't contact the S3/SimpleDB server, but
destructors aren't allowed to throw exceptions, so catch this case and log
a warning instead (because we failed to release the lock that we were
holding).


  Commit: 756c14b19630a9aec7bdd8f2f0e62f9ac47d691f
      https://github.com/boxbackup/boxbackup/commit/756c14b19630a9aec7bdd8f2f0e62f9ac47d691f
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/server/ServerStream.h

  Log Message:
  -----------
  Improve exception handling in single-process servers

Don't allow an uncaught exception to kill the whole server. This makes it
consistent with multi-process servers, where death of a child worker does
not stop the main server process, so it continues to serve requests.

This makes the HTTPServer robust to exceptions (such as the child
disconnecting while the server is streaming a response) on Windows.


  Commit: 6431353b0656e4b29ff2be8fa7eaa77496ce20ae
      https://github.com/boxbackup/boxbackup/commit/6431353b0656e4b29ff2be8fa7eaa77496ce20ae
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/win32/emu.cpp

  Log Message:
  -----------
  Windows syslog() emulation: improve error messages

If syslog can't log to the Windows event log for some reason, instead of
just printing the log message to the console, include some explanatory
text about what went wrong.


  Commit: 4872d14e2084b3be033bb225e9cf09057173fb6e
      https://github.com/boxbackup/boxbackup/commit/4872d14e2084b3be033bb225e9cf09057173fb6e
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M infrastructure/buildenv-testmain-template.cpp

  Log Message:
  -----------
  Completely disable syslog logging in tests


  Commit: f3f594f59252fc0437234a953153da384ed53e1a
      https://github.com/boxbackup/boxbackup/commit/f3f594f59252fc0437234a953153da384ed53e1a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h

  Log Message:
  -----------
  Enable overriding log level by category as well as filename

This extends the -L command-line option to allow overriding by
filename/category=level as well as the existing support for overriding by
filename=level.


  Commit: 59c40f62856e486357086767164aa5b0f1c7c0bf
      https://github.com/boxbackup/boxbackup/commit/59c40f62856e486357086767164aa5b0f1c7c0bf
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/server/SocketStream.cpp

  Log Message:
  -----------
  SocketStream: use THROW_SOCKET_ERROR for better messages on Windows


  Commit: e57dfc48697a3a1b023121682608260770931ef6
      https://github.com/boxbackup/boxbackup/commit/e57dfc48697a3a1b023121682608260770931ef6
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/httpserver/S3Client.h

  Log Message:
  -----------
  Increase timeouts in S3Client to help with debugging


  Commit: c922d725359a84745fc48847f6c2815cfd282af8
      https://github.com/boxbackup/boxbackup/commit/c922d725359a84745fc48847f6c2815cfd282af8
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/httpserver/S3Simulator.cpp

  Log Message:
  -----------
  S3Simulator: add some TRACE logging to help debug 100-continue responses


  Commit: 9cea4c31d956be643314cb0e56e03bb094f7a33a
      https://github.com/boxbackup/boxbackup/commit/9cea4c31d956be643314cb0e56e03bb094f7a33a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/server/ServerStream.h
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  ServerStream and test/backupstore: improve comments slightly


  Commit: b31c0e4abd4875bb25ff7a918ed5bc7f7faf595d
      https://github.com/boxbackup/boxbackup/commit/b31c0e4abd4875bb25ff7a918ed5bc7f7faf595d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupStoreContext.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp
    M lib/bbstored/BackupStoreDaemon.cpp
    M lib/server/Daemon.cpp
    M lib/server/Daemon.h
    M lib/server/ServerStream.h

  Log Message:
  -----------
  Clear up Daemon command-line arguments -D and -F

By separating their roles (which used to overlap) it's now possible to run a
forking server in the foreground, or a non-forking daemon in the background,
which can be useful for debugging (for example, to more closely simulate how
test daemons work on Windows when running on Unix). -DF is now needed to
have a non-forking server in the foreground.


  Commit: d4f94f07ae53ba471aa13bc9eeae1df8bffa48b5
      https://github.com/boxbackup/boxbackup/commit/d4f94f07ae53ba471aa13bc9eeae1df8bffa48b5
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/httpserver/SimpleDBClient.h

  Log Message:
  -----------
  Fix SimpleDB timeouts: should be in milliseconds, not seconds


  Commit: be071698961a46b11e9a7db473199f2cd799fa3b
      https://github.com/boxbackup/boxbackup/commit/be071698961a46b11e9a7db473199f2cd799fa3b
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/common/DebugMemLeakFinder.cpp

  Log Message:
  -----------
  Store and log full stack traces for leaked memory allocations

Don't dump stack backtrace when logging memory leaks to a file

Since the backtrace goes to the console instead, it's confusing to have them in
different places.

(cherry picked from commit 6e7df4dfdc06eaff2dd0ef51741df3cf6ba319ea)
(cherry picked from commit 270cd1f16fa8a32b07ae0b9762a417db7b95b82f)
(cherry picked from commit c627e9547fb8a191ea36780b140fd0516a0bffa8)
(cherry picked from commit 336859cb7f499300d4b6e0b6bcd18e275a1f0043)


  Commit: 4847bcdb37269da6e10552b61b3e75f3e8038ab2
      https://github.com/boxbackup/boxbackup/commit/4847bcdb37269da6e10552b61b3e75f3e8038ab2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M infrastructure/cmake/windows/CMakeLists.txt

  Log Message:
  -----------
  Upgrade to OpenSSL 1.0.2l

Run OpenSSL tests after building it for Windows Unibuild

(cherry picked from commit 95b5d8f14f59cf8a887bccfa78c1d0fda0008aba)


  Commit: 1f87f198b4a8e56eef0b28da4685e1c9084883df
      https://github.com/boxbackup/boxbackup/commit/1f87f198b4a8e56eef0b28da4685e1c9084883df
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M infrastructure/cmake/windows/CMakeLists.txt

  Log Message:
  -----------
  Switch PCRE back to an official release

(cherry picked from commit e4d488d1a07bf1db32e96a9526d1fd1ea54f0967)
(cherry picked from commit c3f54004ab6aca059ec259b2b310b0bb3161e191)


  Commit: b59512684a41ac46e734e7369d6a7ad298e2a7f6
      https://github.com/boxbackup/boxbackup/commit/b59512684a41ac46e734e7369d6a7ad298e2a7f6
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M infrastructure/cmake/windows/CMakeLists.txt

  Log Message:
  -----------
  Remove BoxBackup install step from Windows unibuild

We don't need to install anything in C:\Program Files\BoxBackup, and often
don't have permission to do that anyway.

(cherry picked from commit 2d31a3178ba5a39af594c1a0188748f5c8045b18)


  Commit: beefd5c02cbb687debf20a7857edb1b7bb4782b2
      https://github.com/boxbackup/boxbackup/commit/beefd5c02cbb687debf20a7857edb1b7bb4782b2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp

  Log Message:
  -----------
  Generalise BackupFileSystem::GetLock and reuse it

This reduces code duplication (multiple implementations of locking retries) and
also enables centralised logging of locking attempts, which can be more easily
fine-tuned.


  Commit: fac7c23a0a421b6f994448d6c8ee2347fadcfd20
      https://github.com/boxbackup/boxbackup/commit/fac7c23a0a421b6f994448d6c8ee2347fadcfd20
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h

  Log Message:
  -----------
  Allow using LogLevelOverrideByFileGuard as a guard

After calling its Install() method, the guard will be installed in the central
logging configuration, and will automatically be uninstalled when the object
goes out of scope and is destroyed.


  Commit: 8fcecdfc55eae06b4738aeda7df29aa4ed085fdf
      https://github.com/boxbackup/boxbackup/commit/8fcecdfc55eae06b4738aeda7df29aa4ed085fdf
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Add detailed logging of BackupFileSystem locks

This logging is categorised, so it can be enabled with fine-tuning using the -L
command-line option.


  Commit: fd1495a41c7fd39976bca4aa246bef5ec94678c5
      https://github.com/boxbackup/boxbackup/commit/fd1495a41c7fd39976bca4aa246bef5ec94678c5
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M test/backupstorefix/testbackupstorefix.cpp

  Log Message:
  -----------
  Enable detailed logging of locking in test/backupstorefix

This should help diagnose occasional locking problems causing test failures on
AppVeyor.


  Commit: def9f9c5f23675e6db7b132667c9f22a180975e3
      https://github.com/boxbackup/boxbackup/commit/def9f9c5f23675e6db7b132667c9f22a180975e3
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-17 (Fri, 17 Nov 2017)

  Changed paths:
    M lib/bbackupd/BackupDaemon.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp

  Log Message:
  -----------
  Suppress exception messages in LineBuffer::GetLine

These exceptions are used to communicate state to the caller, and should not be
treated as errors in common cases.


Compare: https://github.com/boxbackup/boxbackup/compare/958ef9170dda...def9f9c5f236


More information about the Boxbackup-commit mailing list