[Box Backup-commit] [boxbackup/boxbackup] 83fc65: Generalise BackupFileSystem::GetLock and reuse it

GitHub noreply at github.com
Sun Nov 19 21:57:32 GMT 2017


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 83fc654b6df29ce0a2d7a73819e078b47828cf6a
      https://github.com/boxbackup/boxbackup/commit/83fc654b6df29ce0a2d7a73819e078b47828cf6a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp
    M lib/backupstore/StoreTestUtils.cpp

  Log Message:
  -----------
  Generalise BackupFileSystem::GetLock and reuse it

This reduces code duplication (multiple implementations of locking retries) and
also enables centralised logging of locking attempts, which can be more easily
fine-tuned.


  Commit: ad18c41c5ed0cb6a0449d3afe3fd832f7ff59146
      https://github.com/boxbackup/boxbackup/commit/ad18c41c5ed0cb6a0449d3afe3fd832f7ff59146
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h

  Log Message:
  -----------
  Allow using LogLevelOverrideByFileGuard as a guard

After calling its Install() method, the guard will be installed in the central
logging configuration, and will automatically be uninstalled when the object
goes out of scope and is destroyed.


  Commit: 3bc679f9a226d6859efae640d18507c0f1947a90
      https://github.com/boxbackup/boxbackup/commit/3bc679f9a226d6859efae640d18507c0f1947a90
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Add detailed logging of BackupFileSystem locks

This logging is categorised, so it can be enabled with fine-tuning using the -L
command-line option.


  Commit: d08c655b547aec6e6c0fddfb4596a3548e4669e1
      https://github.com/boxbackup/boxbackup/commit/d08c655b547aec6e6c0fddfb4596a3548e4669e1
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M test/backupstorefix/testbackupstorefix.cpp

  Log Message:
  -----------
  Enable detailed logging of locking in test/backupstorefix

This should help diagnose occasional locking problems causing test failures on
AppVeyor.


  Commit: fcbfc48a169287ce3ddce8d0d7a4b5501a67ace7
      https://github.com/boxbackup/boxbackup/commit/fcbfc48a169287ce3ddce8d0d7a4b5501a67ace7
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M lib/bbackupd/BackupDaemon.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp

  Log Message:
  -----------
  Suppress exception messages in LineBuffer::GetLine

These exceptions are used to communicate state to the caller, and should not be
treated as errors in common cases.


  Commit: 338a41a046e0e439dbecd472c50fceda376659ab
      https://github.com/boxbackup/boxbackup/commit/338a41a046e0e439dbecd472c50fceda376659ab
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  Fix handling of missing BackupStoreInfo in S3 GetAccountIdentifier()


  Commit: 66fc6a97eb725a7c8fa271cc09a86a9eb99176ce
      https://github.com/boxbackup/boxbackup/commit/66fc6a97eb725a7c8fa271cc09a86a9eb99176ce
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Fix cleanup of backupstore specialised tests

In case of exception, ensure that teardown code is always run, to release
filesystem lock before deleting files in standard tearDown().


Compare: https://github.com/boxbackup/boxbackup/compare/def9f9c5f236...66fc6a97eb72


More information about the Boxbackup-commit mailing list