[Box Backup-commit] [boxbackup/boxbackup] 5c69d2: Generalise BackupFileSystem::GetLock and reuse it

GitHub noreply at github.com
Mon Nov 20 20:25:50 GMT 2017


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 5c69d22356a9c250166d03bb73cac0f13f35dfa9
      https://github.com/boxbackup/boxbackup/commit/5c69d22356a9c250166d03bb73cac0f13f35dfa9
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp
    M lib/backupstore/StoreTestUtils.cpp

  Log Message:
  -----------
  Generalise BackupFileSystem::GetLock and reuse it

This reduces code duplication (multiple implementations of locking retries) and
also enables centralised logging of locking attempts, which can be more easily
fine-tuned.


  Commit: 2cc9c74c62a9b20e5877f9c8203463666c51b0ca
      https://github.com/boxbackup/boxbackup/commit/2cc9c74c62a9b20e5877f9c8203463666c51b0ca
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h

  Log Message:
  -----------
  Allow using LogLevelOverrideByFileGuard as a guard

After calling its Install() method, the guard will be installed in the central
logging configuration, and will automatically be uninstalled when the object
goes out of scope and is destroyed.


  Commit: 11e25e4fa6518950bcc97857b46c62fe5fe02d2a
      https://github.com/boxbackup/boxbackup/commit/11e25e4fa6518950bcc97857b46c62fe5fe02d2a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Add detailed logging of BackupFileSystem locks

This logging is categorised, so it can be enabled with fine-tuning using the -L
command-line option.


  Commit: 4746dadeac85044a5148c7800b927d79bfd7d6da
      https://github.com/boxbackup/boxbackup/commit/4746dadeac85044a5148c7800b927d79bfd7d6da
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M test/backupstorefix/testbackupstorefix.cpp

  Log Message:
  -----------
  Enable detailed logging of locking in test/backupstorefix

This should help diagnose occasional locking problems causing test failures on
AppVeyor.


  Commit: 1640ba331570b5af4a045682ec17c99109ba7eb0
      https://github.com/boxbackup/boxbackup/commit/1640ba331570b5af4a045682ec17c99109ba7eb0
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/bbackupd/BackupDaemon.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp

  Log Message:
  -----------
  Suppress exception messages in LineBuffer::GetLine

These exceptions are used to communicate state to the caller, and should not be
treated as errors in common cases.


  Commit: 6d4be7e54b7a63690b7e0ee4315ec78c24e8544a
      https://github.com/boxbackup/boxbackup/commit/6d4be7e54b7a63690b7e0ee4315ec78c24e8544a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  Fix handling of missing BackupStoreInfo in S3 GetAccountIdentifier()


  Commit: 643e1af6ae097f7eb06547c9c49a5ad9afb7425b
      https://github.com/boxbackup/boxbackup/commit/643e1af6ae097f7eb06547c9c49a5ad9afb7425b
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Fix cleanup of backupstore specialised tests

In case of exception, ensure that teardown code is always run, to release
filesystem lock before deleting files in standard tearDown().


Compare: https://github.com/boxbackup/boxbackup/compare/66fc6a97eb72...643e1af6ae09


More information about the Boxbackup-commit mailing list