[Box Backup-commit] [boxbackup/boxbackup] 0469e4: Generalise BackupFileSystem::GetLock and reuse it

GitHub noreply at github.com
Mon Nov 20 20:56:00 GMT 2017


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 0469e4a3bd7318547294ec5309aabffa488fc67f
      https://github.com/boxbackup/boxbackup/commit/0469e4a3bd7318547294ec5309aabffa488fc67f
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/BackupStoreContext.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp
    M lib/backupstore/StoreTestUtils.cpp
    M test/backupstorepatch/testbackupstorepatch.cpp

  Log Message:
  -----------
  Generalise BackupFileSystem::GetLock and reuse it

This reduces code duplication (multiple implementations of locking retries) and
also enables centralised logging of locking attempts, which can be more easily
fine-tuned.


  Commit: 6bc155cacf7ebbfec49d44b7cb155fc949664b16
      https://github.com/boxbackup/boxbackup/commit/6bc155cacf7ebbfec49d44b7cb155fc949664b16
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h

  Log Message:
  -----------
  Allow using LogLevelOverrideByFileGuard as a guard

After calling its Install() method, the guard will be installed in the central
logging configuration, and will automatically be uninstalled when the object
goes out of scope and is destroyed.


  Commit: 78db5833e3c703a12faf2b5a30077e55e4136723
      https://github.com/boxbackup/boxbackup/commit/78db5833e3c703a12faf2b5a30077e55e4136723
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Add detailed logging of BackupFileSystem locks

This logging is categorised, so it can be enabled with fine-tuning using the -L
command-line option.


  Commit: 82a9b34e98a1d5dcdc7b451fa3167ef29e836eb0
      https://github.com/boxbackup/boxbackup/commit/82a9b34e98a1d5dcdc7b451fa3167ef29e836eb0
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M test/backupstorefix/testbackupstorefix.cpp

  Log Message:
  -----------
  Enable detailed logging of locking in test/backupstorefix

This should help diagnose occasional locking problems causing test failures on
AppVeyor.


  Commit: d2b41ed072795a49e243df48d19ba1bbc3beb778
      https://github.com/boxbackup/boxbackup/commit/d2b41ed072795a49e243df48d19ba1bbc3beb778
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/bbackupd/BackupDaemon.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp

  Log Message:
  -----------
  Suppress exception messages in LineBuffer::GetLine

These exceptions are used to communicate state to the caller, and should not be
treated as errors in common cases.


  Commit: 6ef8e5bada155f78819cc005b2048766ef4b5ad2
      https://github.com/boxbackup/boxbackup/commit/6ef8e5bada155f78819cc005b2048766ef4b5ad2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  Fix handling of missing BackupStoreInfo in S3 GetAccountIdentifier()


  Commit: 65df26070d0c293c74be89470af5f72c546ba4a5
      https://github.com/boxbackup/boxbackup/commit/65df26070d0c293c74be89470af5f72c546ba4a5
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Fix cleanup of backupstore specialised tests

In case of exception, ensure that teardown code is always run, to release
filesystem lock before deleting files in standard tearDown().


Compare: https://github.com/boxbackup/boxbackup/compare/643e1af6ae09...65df26070d0c


More information about the Boxbackup-commit mailing list