[Box Backup-commit] [boxbackup/boxbackup] 5f530f: Refactor testcommon to split into independent test...

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 5f530f31e5e628034277c4f537844339f2325633
      https://github.com/boxbackup/boxbackup/commit/5f530f31e5e628034277c4f537844339f2325633
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Refactor testcommon to split into independent tests

Remove redundant NamedLock tests.

(cherry picked from commit 79b46b17d66498b5f30e1272948b078558bd0055)


  Commit: 6c5ee2979124a6cc3da02f4c7558690a2860cced
      https://github.com/boxbackup/boxbackup/commit/6c5ee2979124a6cc3da02f4c7558690a2860cced
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Add force parameter to RemovePrefix and RemoveSuffix

(cherry picked from commit 16a037524df72cc7a173ce8d50080c20e0622281)


  Commit: d47cee8d41b9c5727f8c2c149e29d5f72f17760e
      https://github.com/boxbackup/boxbackup/commit/d47cee8d41b9c5727f8c2c149e29d5f72f17760e
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M bin/bbackupctl/bbackupctl.cpp
    M bin/bbackupquery/bbackupquery.cpp
    M lib/bbackupd/BackupDaemon.cpp
    M lib/bbstored/BBStoreDHousekeeping.cpp
    M lib/common/CommonException.txt
    M lib/common/FdGetLine.cpp
    M lib/common/FdGetLine.h
    R lib/common/GetLine.cpp
    R lib/common/GetLine.h
    M lib/common/IOStream.cpp
    M lib/common/IOStreamGetLine.cpp
    M lib/common/IOStreamGetLine.h
    A lib/common/LineBuffer.cpp
    A lib/common/LineBuffer.h
    M lib/httpserver/HTTPException.txt
    M lib/httpserver/HTTPHeaders.cpp
    M lib/httpserver/HTTPRequest.cpp
    M lib/httpserver/HTTPResponse.cpp
    M lib/httpserver/S3Simulator.cpp
    M lib/httpserver/S3Simulator.h
    M lib/server/ServerControl.cpp
    M lib/server/SocketStream.cpp
    M test/backupstorefix/testbackupstorefix.cpp
    M test/basicserver/testbasicserver.cpp
    M test/bbackupd/testbbackupd.cpp
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Refactor GetLine

The class name was a problem, because the method that we want to call on it is
also called GetLine, which looks too much like a constructor in C++, so I
renamed it to LineBuffer.  I haven't yet renamed the child classes.

Also, it was impossible to distinguish between the different causes of
GetLine() returning false (timeout and signal) and EOF could only be checked by
calling a different function. Now all of these causes throw different
exceptions.

This really fixes the problem with attaching a debugger to a process waiting in
GetLine, which would previously cause the read() to return immediately with
EINTR, which we never retried because it looked like a timeout.

(cherry picked from commit 20ce9cabcdf180d2063f1d40f402289bf0601887)


  Commit: 5de33477983d9e1e0dac01e4792bc528eb87e501
      https://github.com/boxbackup/boxbackup/commit/5de33477983d9e1e0dac01e4792bc528eb87e501
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  Disable test_multiple_uploads for now, to keep Travis green


  Commit: 23baccdb7ac9ee59357d979cda71a691caa202a5
      https://github.com/boxbackup/boxbackup/commit/23baccdb7ac9ee59357d979cda71a691caa202a5
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Enable and fix warnings in infrastructure/makebuildenv.pl

(cherry picked from commit 3209e5a9f5b3f379a7b833b304932c77a2deabce)


  Commit: 452bb6d0af00e378fbc9904e6808b47b0e9461ba
      https://github.com/boxbackup/boxbackup/commit/452bb6d0af00e378fbc9904e6808b47b0e9461ba
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M infrastructure/makebuildenv.pl.in

  Log Message:
  -----------
  Fix Makefile dependency tracking of configured files

This allows protocol files to be regenerated automatically if
makeprotocol.pl.in changes, and similarly exception files and
makeexception.pl.in.

(cherry picked from commit 994526017764f89d7759de30988a81582dcada1d)


  Commit: 3d61a219a2f36399d6905cd65d40f57fc049ca21
      https://github.com/boxbackup/boxbackup/commit/3d61a219a2f36399d6905cd65d40f57fc049ca21
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Add full test-case support to testcommon.


Compare: https://github.com/boxbackup/boxbackup/compare/c227276b2439...3d61a219a2f3