[Box Backup-commit] [boxbackup/boxbackup] 041943: Fix incorrect detection of the need to intercept l...

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 0419437b84c9ffb5677fa31dab739f6caa77c52d
      https://github.com/boxbackup/boxbackup/commit/0419437b84c9ffb5677fa31dab739f6caa77c52d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M infrastructure/cmake/CMakeLists.txt
    M infrastructure/m4/boxbackup_tests.m4
    M lib/intercept/intercept.cpp

  Log Message:
  -----------
  Fix incorrect detection of the need to intercept lxstat

For some reason, #if defined __GNUC__ && __GNUC__ >= 2 was true on OSX,
resulting in intercepts not working properly.  It was also broken on MIPS64,
causing test/raidfile to fail with errors like: TEST FAILURE: Condition
[TestGetFileSize(stripe1fn) == fs1] failed at testraidfile.cpp:415

https://buildd.debian.org/status/fetch.php?pkg=boxbackup&arch=mips64el&ver=0.11.1~r2837-4&stamp=1485060478&raw=0

Now we detect when to intercept Linux' lxstat syscall using autoconf macros.
We also detect whether to intercept stat64 (instead of stat) based on whether
the stat64 function exists.

This was originally cherry-picked from commit
a042c9951fabc1fb4f57e6d13d739192dda76025, but additional fixes were made in
784fe4320f70c125f8d24d02f195e30064e09ab3 which I'm hereby backporting to the
s3_support branch to fix the raidfile tests on OSX.