[Box Backup-commit] [boxbackup/boxbackup] 2e0c58: Fix writeback of refcount databases on BackupFileS...

GitHub noreply at github.com
Mon Sep 4 22:04:10 BST 2017


  Branch: refs/heads/s3_support_merge
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 2e0c588b7b6cea4cd8be94ded87e34e9018e8d48
      https://github.com/boxbackup/boxbackup/commit/2e0c588b7b6cea4cd8be94ded87e34e9018e8d48
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  Fix writeback of refcount databases on BackupFileSystem destruction

Call ReleaseLock in the child destructor (not the parent) to allow the refcount
database to clean itself up (normally involving calling
BackupFileSystem::SaveRefCountDatabase) before the BackupFileSystem is too
destroyed to be able to fulfil the request.


  Commit: a0ad9c890a0f5cbca2ca3e0d88e5454bf376c86f
      https://github.com/boxbackup/boxbackup/commit/a0ad9c890a0f5cbca2ca3e0d88e5454bf376c86f
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M lib/bbstored/BBStoreDHousekeeping.cpp
    M lib/bbstored/BackupStoreDaemon.cpp

  Log Message:
  -----------
  Wait for housekeeping to finish before bbstored exits

Should fix random test failures due to housekeeping process realising that the
master has asked it to terminate, and logging that it has, after the master has
already died and the test finished, confusing the test runner with its extra
output. Should also help make the occasionally-reported housekeeping crashes
more obvious and easier to debug.


Compare: https://github.com/boxbackup/boxbackup/compare/490997dcf865...a0ad9c890a0f


More information about the Boxbackup-commit mailing list