[Box Backup-commit] [boxbackup/boxbackup] b80bee: Refactor GetLine
noreply at github.com
Fri Sep 22 19:23:11 BST 2017
Author: Chris Wilson <chris+github at qwirx.com>
Date: 2017-09-22 (Fri, 22 Sep 2017)
The class name was a problem, because the method that we want to call on it is
also called GetLine, which looks too much like a constructor in C++, so I
renamed it to LineBuffer. I haven't yet renamed the child classes.
Also, it was impossible to distinguish between the different causes of
GetLine() returning false (timeout and signal) and EOF could only be checked by
calling a different function. Now all of these causes throw different
This really fixes the problem with attaching a debugger to a process waiting in
GetLine, which would previously cause the read() to return immediately with
EINTR, which we never retried because it looked like a timeout.
More information about the Boxbackup-commit