From noreply at github.com Sun Apr 1 21:31:46 2018 From: noreply at github.com (GitHub) Date: Sun, 01 Apr 2018 13:31:46 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 9038c0: Mark master branch builds as full releases (not pr... Message-ID: <5ac141b269a60_126a2b1a876b5c0c37732@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/boxbackup/boxbackup Commit: 9038c0bd43fe8f86067be918f6219753bbd9a089 https://github.com/boxbackup/boxbackup/commit/9038c0bd43fe8f86067be918f6219753bbd9a089 Author: Chris Wilson Date: 2017-12-25 (Mon, 25 Dec 2017) Changed paths: M appveyor.yml M infrastructure/cmake/CMakeLists.txt Log Message: ----------- Mark master branch builds as full releases (not pre-releases) on GitHub (cherry picked from commit ca39634eaaef82204fb3b66e5dc4cc517acb515d) Commit: 161ceefc1a622db6d5e296c35de9b0c7af7e3aa6 https://github.com/boxbackup/boxbackup/commit/161ceefc1a622db6d5e296c35de9b0c7af7e3aa6 Author: Chris Wilson Date: 2018-03-26 (Mon, 26 Mar 2018) Changed paths: M appveyor.yml M configure.ac M infrastructure/cmake/CMakeLists.txt M infrastructure/cmake/windows/CMakeLists.txt M infrastructure/m4/ax_check_syscall_lseek.m4 M infrastructure/m4/boxbackup_tests.m4 M infrastructure/makebuildenv.pl.in M infrastructure/travis-build.sh M lib/common/Guards.h M lib/crypto/CipherBlowfish.h M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherException.txt M lib/crypto/Random.cpp M lib/intercept/intercept.cpp M lib/server/TLSContext.cpp M test/backupstore/testbackupstore.cpp A test/backupstore/testfiles/encrypted.dir M test/crypto/testcrypto.cpp A test/crypto/testfiles/bbackupd.keys A test/crypto/testfiles/bfdlink.h A test/crypto/testfiles/bfdlink.h.enc M test/raidfile/testraidfile.cpp Log Message: ----------- Merge branch 'master' into mark_master_builds_as_full_releases Commit: 4d4df5d67da0b13ca3229281ec797d2166c86a7f https://github.com/boxbackup/boxbackup/commit/4d4df5d67da0b13ca3229281ec797d2166c86a7f Author: Chris Wilson Date: 2018-04-01 (Sun, 01 Apr 2018) Changed paths: M appveyor.yml M infrastructure/cmake/CMakeLists.txt Log Message: ----------- Merge pull request #21 from boxbackup/mark_master_builds_as_full_releases Mark master branch builds as full releases (not pre-releases) on GitHub Compare: https://github.com/boxbackup/boxbackup/compare/16a11e868c62...4d4df5d67da0 From noreply at github.com Sun Apr 1 21:32:00 2018 From: noreply at github.com (GitHub) Date: Sun, 01 Apr 2018 13:32:00 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 92d3f3: Refactor Start/StopSimulator out of testbackupstor... Message-ID: <5ac141c099b72_32022ab0c5f99c14475be@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 92d3f329ad1ebd9ce04d18659ea47b14b64e78ba https://github.com/boxbackup/boxbackup/commit/92d3f329ad1ebd9ce04d18659ea47b14b64e78ba Author: Chris Wilson Date: 2018-04-01 (Sun, 01 Apr 2018) Changed paths: M lib/backupstore/StoreTestUtils.cpp M lib/backupstore/StoreTestUtils.h M lib/common/Test.h M test/backupstore/testbackupstore.cpp M test/bbackupd/testbbackupd.cpp Log Message: ----------- Refactor Start/StopSimulator out of testbackupstore To enable reuse by testbackupstorepatch. Commit: 600ff842739e76f2b0dfd0dafd8757700973f7e9 https://github.com/boxbackup/boxbackup/commit/600ff842739e76f2b0dfd0dafd8757700973f7e9 Author: Chris Wilson Date: 2018-04-01 (Sun, 01 Apr 2018) Changed paths: M lib/common/makeexception.pl.in Log Message: ----------- Exception classes should have virtual destructors We don't actually subclass them at the moment, but because they have virtual methods, they should also have virtual destructors for correctness, especially in case anyone did want to subclass them in future. Commit: 151f04e9d77000be88f1994a3819b4052d39bcd3 https://github.com/boxbackup/boxbackup/commit/151f04e9d77000be88f1994a3819b4052d39bcd3 Author: Chris Wilson Date: 2018-04-01 (Sun, 01 Apr 2018) Changed paths: M lib/backupstore/BackupCommands.cpp M lib/backupstore/BackupFileSystem.cpp M lib/backupstore/BackupFileSystem.h M lib/backupstore/BackupProtocol.txt M lib/backupstore/BackupStoreContext.cpp M lib/backupstore/BackupStoreContext.h M lib/backupstore/BackupStoreFile.h M lib/backupstore/BackupStoreFileCmbDiff.cpp M lib/backupstore/BackupStoreFileCombine.cpp M lib/backupstore/HousekeepStoreAccount.cpp M lib/backupstore/HousekeepStoreAccount.h M test/backupstore/testbackupstore.cpp M test/backupstorepatch/testbackupstorepatch.cpp Log Message: ----------- Add support for patch combining in S3 stores This allows housekeeping to reduce the storage required. It's very inefficient, but needed for compatibility with bbstored stores. Convert test/backupstore test_server_housekeeping and test/backupstorepatch to specialised tests, and make them test S3 stores as well. Change the GetBlockIndexByName command to reconstruct the block index when the most recent version of the file is a patch (as it will be on S3 stores). Stop pretending that S3BackupFileSystem cannot merge patches, and stop reporting that it's "hard" to do so for the time being, at least until we have a better way to manage store space (e.g. snapshots). Compare: https://github.com/boxbackup/boxbackup/compare/2f141d2939b3...151f04e9d770 From noreply at github.com Sun Apr 1 21:32:36 2018 From: noreply at github.com (GitHub) Date: Sun, 01 Apr 2018 13:32:36 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] Message-ID: <5ac141e414435_349f2ad2c8d19c08869cd@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/mark_master_builds_as_full_releases Home: https://github.com/boxbackup/boxbackup From noreply at github.com Thu Apr 5 22:30:20 2018 From: noreply at github.com (GitHub) Date: Thu, 05 Apr 2018 14:30:20 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 76fdf8: Add support for patch combining in S3 stores Message-ID: <5ac6956cb04a7_2c5c2aecbd639c0830749@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 76fdf8c21ea79cfbddf7d63cdce5fb4eaf6cae98 https://github.com/boxbackup/boxbackup/commit/76fdf8c21ea79cfbddf7d63cdce5fb4eaf6cae98 Author: Chris Wilson Date: 2018-04-05 (Thu, 05 Apr 2018) Changed paths: M lib/backupstore/BackupCommands.cpp M lib/backupstore/BackupFileSystem.cpp M lib/backupstore/BackupFileSystem.h M lib/backupstore/BackupProtocol.txt M lib/backupstore/BackupStoreContext.cpp M lib/backupstore/BackupStoreContext.h M lib/backupstore/BackupStoreFile.h M lib/backupstore/BackupStoreFileCmbDiff.cpp M lib/backupstore/BackupStoreFileCombine.cpp M lib/backupstore/HousekeepStoreAccount.cpp M lib/backupstore/HousekeepStoreAccount.h M modules.txt M test/backupstore/testbackupstore.cpp M test/backupstorepatch/testbackupstorepatch.cpp Log Message: ----------- Add support for patch combining in S3 stores This allows housekeeping to reduce the storage required. It's very inefficient, but needed for compatibility with bbstored stores. Convert test/backupstore test_server_housekeeping and test/backupstorepatch to specialised tests, and make them test S3 stores as well. Change the GetBlockIndexByName command to reconstruct the block index when the most recent version of the file is a patch (as it will be on S3 stores). Stop pretending that S3BackupFileSystem cannot merge patches, and stop reporting that it's "hard" to do so for the time being, at least until we have a better way to manage store space (e.g. snapshots). Commit: d798866afb99441abe879a8e2098f6399210aa34 https://github.com/boxbackup/boxbackup/commit/d798866afb99441abe879a8e2098f6399210aa34 Author: Chris Wilson Date: 2018-04-05 (Thu, 05 Apr 2018) Changed paths: M lib/server/Socket.cpp M lib/server/Socket.h M lib/server/SocketStream.cpp Log Message: ----------- Factor out code to return a pretty name for a host (hostname and IP address) Compare: https://github.com/boxbackup/boxbackup/compare/151f04e9d770...d798866afb99 From noreply at github.com Fri Apr 6 21:28:03 2018 From: noreply at github.com (GitHub) Date: Fri, 06 Apr 2018 13:28:03 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] ca425d: Add support for patch combining in S3 stores Message-ID: <5ac7d8539adb0_67c32aca684b9bfc2034@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: ca425d9d83ce5a89eb32c505314a809e273f907e https://github.com/boxbackup/boxbackup/commit/ca425d9d83ce5a89eb32c505314a809e273f907e Author: Chris Wilson Date: 2018-04-06 (Fri, 06 Apr 2018) Changed paths: M lib/backupstore/BackupCommands.cpp M lib/backupstore/BackupFileSystem.cpp M lib/backupstore/BackupFileSystem.h M lib/backupstore/BackupProtocol.txt M lib/backupstore/BackupStoreContext.cpp M lib/backupstore/BackupStoreContext.h M lib/backupstore/BackupStoreFile.h M lib/backupstore/BackupStoreFileCmbDiff.cpp M lib/backupstore/BackupStoreFileCombine.cpp M lib/backupstore/HousekeepStoreAccount.cpp M lib/backupstore/HousekeepStoreAccount.h M modules.txt M test/backupstore/testbackupstore.cpp M test/backupstorepatch/testbackupstorepatch.cpp Log Message: ----------- Add support for patch combining in S3 stores This allows housekeeping to reduce the storage required. It's very inefficient, but needed for compatibility with bbstored stores. Convert test/backupstore test_server_housekeeping and test/backupstorepatch to specialised tests, and make them test S3 stores as well. Change the GetBlockIndexByName command to reconstruct the block index when the most recent version of the file is a patch (as it will be on S3 stores). Stop pretending that S3BackupFileSystem cannot merge patches, and stop reporting that it's "hard" to do so for the time being, at least until we have a better way to manage store space (e.g. snapshots). Commit: 0aca783992b7e94cc83dd60d1fad9de36f1fb236 https://github.com/boxbackup/boxbackup/commit/0aca783992b7e94cc83dd60d1fad9de36f1fb236 Author: Chris Wilson Date: 2018-04-06 (Fri, 06 Apr 2018) Changed paths: M lib/server/Socket.cpp M lib/server/Socket.h M lib/server/SocketStream.cpp Log Message: ----------- Factor out code to return a pretty name for a host (hostname and IP address) Commit: 582e9c065b12348acf1e7f878581647a95e73a8c https://github.com/boxbackup/boxbackup/commit/582e9c065b12348acf1e7f878581647a95e73a8c Author: Chris Wilson Date: 2018-04-06 (Fri, 06 Apr 2018) Changed paths: M lib/backupstore/BackupFileSystem.cpp M lib/raidfile/RaidFileWrite.cpp Log Message: ----------- Fix errors reports on Windows console due to opening invalid paths Compare: https://github.com/boxbackup/boxbackup/compare/d798866afb99...582e9c065b12 From noreply at github.com Fri Apr 6 22:19:22 2018 From: noreply at github.com (GitHub) Date: Fri, 06 Apr 2018 14:19:22 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 9b8268: Fix "timeouts" in test/basicserver on FreeBSD Message-ID: <5ac7e45a53f9c_6ee62aab85ecdc087315d@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 9b82683a2cd8058b555419fd0bbcf58b7c14b9ab https://github.com/boxbackup/boxbackup/commit/9b82683a2cd8058b555419fd0bbcf58b7c14b9ab Author: Chris Wilson Date: 2018-04-06 (Fri, 06 Apr 2018) Changed paths: M lib/common/IOStream.h M lib/server/ConnectionException.txt M lib/server/SocketStream.cpp M lib/server/SocketStream.h M test/basicserver/testbasicserver.cpp Log Message: ----------- Fix "timeouts" in test/basicserver on FreeBSD If the death of the server was not detected while sending the Quit message to it, but only later when trying to read the reply (which seems only to happen on FreeBSD), the empty read from the dead socket caused ReadFullBuffer to return false, and this was mis-interpreted as a timeout. Now SocketStream::ReadFullBuffer overrides IOStream::ReadFullBuffer to check the socket status when this happens, and if the socket is closed then it raises a more appropriate exception. test/basicserver now catches this exception too. From noreply at github.com Sat Apr 7 21:17:45 2018 From: noreply at github.com (GitHub) Date: Sat, 07 Apr 2018 13:17:45 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 55b95b: Fix "Network operation started with no timeout" wa... Message-ID: <5ac927695270e_473f2abe82dc1c0062855@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 55b95b1e7879985acf785a9e46222c04af862850 https://github.com/boxbackup/boxbackup/commit/55b95b1e7879985acf785a9e46222c04af862850 Author: Chris Wilson Date: 2018-04-07 (Sat, 07 Apr 2018) Changed paths: M test/basicserver/TestCommands.cpp M test/basicserver/testbasicserver.cpp Log Message: ----------- Fix "Network operation started with no timeout" warnings Was triggered by the test servers run by test/basicserver, but only visible on Windows where we don't detach spawned server processes from the console. Caused about 500 lines of unwanted noise in the AppVeyor test run output. From noreply at github.com Sat Apr 7 23:44:59 2018 From: noreply at github.com (GitHub) Date: Sat, 07 Apr 2018 15:44:59 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] cf8b1d: Cache compiled packages to speed up unibuilds Message-ID: <5ac949eb782d9_5cb2adf67577c1084e3@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: cf8b1d61d0523901bba6e579ebcf2df420b42301 https://github.com/boxbackup/boxbackup/commit/cf8b1d61d0523901bba6e579ebcf2df420b42301 Author: Chris Wilson Date: 2018-04-07 (Sat, 07 Apr 2018) Changed paths: M .travis.yml M appveyor.yml M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Cache compiled packages to speed up unibuilds This is particularly relevant to Windows builds, where ccache is not available, so zlib, openssl and pcre must be compiled from scratch on every build. This process caches the installed files (in the install/ directory) and rebuilds them if the CMakeLists file changes. The cache is cleared on appveyor if CMakeLists.txt changes (which invalidates the old packages anyway) but not on Travis, which may grow to become an issue in future. From noreply at github.com Sat Apr 7 23:47:00 2018 From: noreply at github.com (GitHub) Date: Sat, 07 Apr 2018 15:47:00 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 46a38d: Cache compiled packages to speed up unibuilds Message-ID: <5ac94a643ab91_282b2ae465e97c0c9713a@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 46a38daf5f1984ae72f2431d1dae9ba86b5b7992 https://github.com/boxbackup/boxbackup/commit/46a38daf5f1984ae72f2431d1dae9ba86b5b7992 Author: Chris Wilson Date: 2018-04-07 (Sat, 07 Apr 2018) Changed paths: M .travis.yml M appveyor.yml M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Cache compiled packages to speed up unibuilds This is particularly relevant to Windows builds, where ccache is not available, so zlib, openssl and pcre must be compiled from scratch on every build. This process caches the installed files (in the install/ directory) and rebuilds them if the CMakeLists file changes. The cache is cleared on appveyor if CMakeLists.txt changes (which invalidates the old packages anyway) but not on Travis, which may grow to become an issue in future. From noreply at github.com Sun Apr 8 13:38:09 2018 From: noreply at github.com (GitHub) Date: Sun, 08 Apr 2018 05:38:09 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 19af25: Cache compiled packages to speed up unibuilds Message-ID: <5aca0d31877a8_2da32adc1e9e1c0c52173@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 19af25d5e4fb21608040249d7a0d3b86ef40a732 https://github.com/boxbackup/boxbackup/commit/19af25d5e4fb21608040249d7a0d3b86ef40a732 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M .travis.yml M appveyor.yml M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Cache compiled packages to speed up unibuilds This is particularly relevant to Windows builds, where ccache is not available, so zlib, openssl and pcre must be compiled from scratch on every build. This process caches the installed files (in the install/ directory) and rebuilds them if the CMakeLists file changes. The cache is cleared on appveyor if CMakeLists.txt changes (which invalidates the old packages anyway) but not on Travis, which may grow to become an issue in future. From noreply at github.com Sun Apr 8 16:46:27 2018 From: noreply at github.com (GitHub) Date: Sun, 08 Apr 2018 08:46:27 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 9685a6: Fix download URL for PCRE for Windows superbuilds Message-ID: <5aca3953d8670_7e92b16acb7fc08474ca@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 9685a6af4f3ce6d9515a281e2a96756ec3dce945 https://github.com/boxbackup/boxbackup/commit/9685a6af4f3ce6d9515a281e2a96756ec3dce945 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Fix download URL for PCRE for Windows superbuilds We can no longer access the ftp.csx.cam.ac.uk server using HTTP, only FTP. We might as well use the pcre.org server instead. From noreply at github.com Sun Apr 8 17:58:11 2018 From: noreply at github.com (GitHub) Date: Sun, 08 Apr 2018 09:58:11 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 1e9027: Cache compiled packages to speed up unibuilds Message-ID: <5aca4a239fdc9_2d902ac6f57adc082596b@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 1e9027addf4b004f7d426cb3745f78d377aa1fdb https://github.com/boxbackup/boxbackup/commit/1e9027addf4b004f7d426cb3745f78d377aa1fdb Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M .travis.yml M appveyor.yml M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Cache compiled packages to speed up unibuilds This is particularly relevant to Windows builds, where ccache is not available, so zlib, openssl and pcre must be compiled from scratch on every build. This process caches the installed files (in the install/ directory) and rebuilds them if the CMakeLists file changes. The cache is cleared on appveyor if CMakeLists.txt changes (which invalidates the old packages anyway) but not on Travis, which may grow to become an issue in future. Commit: 0ef71934f6125fbee99dd9784e5508cc312bd876 https://github.com/boxbackup/boxbackup/commit/0ef71934f6125fbee99dd9784e5508cc312bd876 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Fix download URL for PCRE for Windows superbuilds We can no longer access the ftp.csx.cam.ac.uk server using HTTP, only FTP. We might as well use the pcre.org server instead. Compare: https://github.com/boxbackup/boxbackup/compare/9685a6af4f3c...0ef71934f612 From noreply at github.com Sun Apr 8 19:59:16 2018 From: noreply at github.com (GitHub) Date: Sun, 08 Apr 2018 11:59:16 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 8f1028: Cache compiled packages to speed up unibuilds Message-ID: <5aca66846bbd9_6ee62aab85ecdc08761d@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 8f1028a928125c97e5aacaa666fddf55a476523d https://github.com/boxbackup/boxbackup/commit/8f1028a928125c97e5aacaa666fddf55a476523d Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M .travis.yml M appveyor.yml M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Cache compiled packages to speed up unibuilds This is particularly relevant to Windows builds, where ccache is not available, so zlib, openssl and pcre must be compiled from scratch on every build. This process caches the installed files (in the install/ directory) and rebuilds them if the CMakeLists file changes. The cache is cleared on appveyor if CMakeLists.txt changes (which invalidates the old packages anyway) but not on Travis, which may grow to become an issue in future. Commit: b38c3d1906bde7a1600deb8018278688fb002f07 https://github.com/boxbackup/boxbackup/commit/b38c3d1906bde7a1600deb8018278688fb002f07 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Fix download URL for PCRE for Windows superbuilds We can no longer access the ftp.csx.cam.ac.uk server using HTTP, only FTP. We might as well use the pcre.org server instead. Compare: https://github.com/boxbackup/boxbackup/compare/0ef71934f612...b38c3d1906bd From noreply at github.com Sun Apr 8 20:14:59 2018 From: noreply at github.com (GitHub) Date: Sun, 08 Apr 2018 12:14:59 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] e761b1: Fix 8f1028a928125c97e5aacaa666fddf55a476523d Message-ID: <5aca6a33228cf_430b2abf1fa09c14307bb@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: e761b1fe338c534a75fb4afde8f0ede77d6e76c6 https://github.com/boxbackup/boxbackup/commit/e761b1fe338c534a75fb4afde8f0ede77d6e76c6 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M appveyor.yml Log Message: ----------- Fix 8f1028a928125c97e5aacaa666fddf55a476523d From noreply at github.com Sun Apr 8 20:55:51 2018 From: noreply at github.com (GitHub) Date: Sun, 08 Apr 2018 12:55:51 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] a2c5b7: Fix 8f1028a928125c97e5aacaa666fddf55a476523d (2) Message-ID: <5aca73c7618e0_6b162ab7d8f87c0c85319@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: a2c5b730c5830616cabe8f3f904ae6b51ccaecf4 https://github.com/boxbackup/boxbackup/commit/a2c5b730c5830616cabe8f3f904ae6b51ccaecf4 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M appveyor.yml Log Message: ----------- Fix 8f1028a928125c97e5aacaa666fddf55a476523d (2) The cache should not be invalidated if appveyor.yml changes, but the Windows Superbuild CMakeLists.txt instead. From noreply at github.com Sun Apr 8 21:25:40 2018 From: noreply at github.com (GitHub) Date: Sun, 08 Apr 2018 13:25:40 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 629e30: Convert test/backupstore test_store_info to a spec... Message-ID: <5aca7ac4f3ce7_63452ab0c8ed7c108754@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 629e307bfeecf462e1f6e110eab2e16cb8344684 https://github.com/boxbackup/boxbackup/commit/629e307bfeecf462e1f6e110eab2e16cb8344684 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M test/backupstore/testbackupstore.cpp Log Message: ----------- Convert test/backupstore test_store_info to a specialised test Commit: eb4bfd482604fca83ef1bf25e810d599a3598000 https://github.com/boxbackup/boxbackup/commit/eb4bfd482604fca83ef1bf25e810d599a3598000 Author: Chris Wilson Date: 2018-04-08 (Sun, 08 Apr 2018) Changed paths: M test/backupstore/testbackupstore.cpp Log Message: ----------- Remove delete_account() from end of test_housekeeping_deletes_files The block count mismatch which originally caused the account check to fail has already been fixed by some other code change, so we don't need to delete the account to stop it being checked any more. Compare: https://github.com/boxbackup/boxbackup/compare/a2c5b730c583...eb4bfd482604 From noreply at github.com Mon Apr 9 23:00:43 2018 From: noreply at github.com (GitHub) Date: Mon, 09 Apr 2018 15:00:43 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 8f8de3: Use a macro to reduce code duplication in test/bac... Message-ID: <5acbe28bd2d5b_1f4322af9e6d37c185292@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 8f8de36e667a7b3f4f75214b7229610641c8fc02 https://github.com/boxbackup/boxbackup/commit/8f8de36e667a7b3f4f75214b7229610641c8fc02 Author: Chris Wilson Date: 2018-04-09 (Mon, 09 Apr 2018) Changed paths: M test/backupstore/testbackupstore.cpp Log Message: ----------- Use a macro to reduce code duplication in test/backupstore specialised tests From noreply at github.com Mon Apr 9 23:01:46 2018 From: noreply at github.com (GitHub) Date: Mon, 09 Apr 2018 15:01:46 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 92021e: Name the ProtocolPhase enum, and use the name to h... Message-ID: <5acbe2ca245f6_7c152adbcd8e1c0495180@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 92021e4d1d235bb1e8eb924c0e41086080282cc1 https://github.com/boxbackup/boxbackup/commit/92021e4d1d235bb1e8eb924c0e41086080282cc1 Author: Chris Wilson Date: 2018-04-09 (Mon, 09 Apr 2018) Changed paths: M lib/backupstore/BackupStoreContext.h Log Message: ----------- Name the ProtocolPhase enum, and use the name to help debuggers From noreply at github.com Mon Apr 9 23:02:26 2018 From: noreply at github.com (GitHub) Date: Mon, 09 Apr 2018 15:02:26 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 1ebbb3: Make test_cannot_open_multiple_writable_connection... Message-ID: <5acbe2f251450_1f3802ae7daeadc14899e8@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 1ebbb336bad82b1ad204805e2b2f4a29ad1096fb https://github.com/boxbackup/boxbackup/commit/1ebbb336bad82b1ad204805e2b2f4a29ad1096fb Author: Chris Wilson Date: 2018-04-09 (Mon, 09 Apr 2018) Changed paths: M lib/backupstore/BackupProtocol.h M lib/common/Configuration.h M lib/common/Test.cpp M test/backupstore/testbackupstore.cpp Log Message: ----------- Make test_cannot_open_multiple_writable_connections a specialised test From noreply at github.com Tue Apr 10 23:14:49 2018 From: noreply at github.com (GitHub) Date: Tue, 10 Apr 2018 15:14:49 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] a84fd8: Speed up test_continuously_updated_file by reducin... Message-ID: <5acd37596fd83_758c2aad14ed5c10433a3@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: a84fd89db9b933039f28975f359acbcc45ca16fc https://github.com/boxbackup/boxbackup/commit/a84fd89db9b933039f28975f359acbcc45ca16fc Author: Chris Wilson Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M test/bbackupd/testbbackupd.cpp M test/bbackupd/testfiles/bbackupd.conf.in Log Message: ----------- Speed up test_continuously_updated_file by reducing waiting times Commit: 1490299706c2307ffa124ae42c56fd982ab1d902 https://github.com/boxbackup/boxbackup/commit/1490299706c2307ffa124ae42c56fd982ab1d902 Author: Chris Wilson Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M lib/common/Test.cpp M lib/server/ServerControl.cpp Log Message: ----------- Speed up tests by removing unnecessary delays in starting daemons Commit: 5cf8bad939937fb35e2cd4d1e8a6580c61b07d9a https://github.com/boxbackup/boxbackup/commit/5cf8bad939937fb35e2cd4d1e8a6580c61b07d9a Author: Chris Wilson Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M test/bbackupd/testbbackupd.cpp Log Message: ----------- Rename test/bbackupd compare macros for readability, and add logging Commit: 4be7719a09e08d092a1cb15bfb08072d69e780b9 https://github.com/boxbackup/boxbackup/commit/4be7719a09e08d092a1cb15bfb08072d69e780b9 Author: Chris Wilson Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M test/bbackupd/testbbackupd.cpp Log Message: ----------- Speed up test/bbackupd by completely skipping Windows-only tests on Unix Compare: https://github.com/boxbackup/boxbackup/compare/1ebbb336bad8...4be7719a09e0 From noreply at github.com Wed Apr 11 20:55:35 2018 From: noreply at github.com (GitHub) Date: Wed, 11 Apr 2018 12:55:35 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 54f8e4: Fix test/backupstorefix races by locking account b... Message-ID: <5ace6837d1c13_5ed12ad53b44bc1490c9@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 54f8e4c403e0445271d03f1e4d8d322ecbfa3b60 https://github.com/boxbackup/boxbackup/commit/54f8e4c403e0445271d03f1e4d8d322ecbfa3b60 Author: Chris Wilson Date: 2018-04-11 (Wed, 11 Apr 2018) Changed paths: M test/backupstorefix/testbackupstorefix.cpp Log Message: ----------- Fix test/backupstorefix races by locking account before corrupting Commit: 23edfb2e16cb176e89f5f9a0943c28100ec38dbd https://github.com/boxbackup/boxbackup/commit/23edfb2e16cb176e89f5f9a0943c28100ec38dbd Author: Chris Wilson Date: 2018-04-11 (Wed, 11 Apr 2018) Changed paths: M infrastructure/m4/boxbackup_tests.m4 Log Message: ----------- Silence -Wunused-command-line-argument warnings from Clang Compare: https://github.com/boxbackup/boxbackup/compare/4be7719a09e0...23edfb2e16cb From noreply at github.com Wed Apr 11 22:22:47 2018 From: noreply at github.com (GitHub) Date: Wed, 11 Apr 2018 14:22:47 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 5f585e: Add extra checks that daemons are really ready to ... Message-ID: <5ace7ca7d28e6_18862ad985471c04799fa@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 5f585ed8cca0a8c9560d0c4bb94251408df66aa2 https://github.com/boxbackup/boxbackup/commit/5f585ed8cca0a8c9560d0c4bb94251408df66aa2 Author: Chris Wilson Date: 2018-04-11 (Wed, 11 Apr 2018) Changed paths: M lib/backupstore/StoreTestUtils.cpp M lib/common/Test.cpp M lib/common/Test.h M lib/server/ServerControl.cpp M lib/server/ServerControl.h M test/backupstore/testbackupstore.cpp M test/basicserver/testbasicserver.cpp Log Message: ----------- Add extra checks that daemons are really ready to serve in tests Removing some sleeps has exposed race conditions where daemons write a PID file before they are actually ready to accept connections, and sometimes we would hit that in tests. Now we pass a port or UNIX socket (or both) to LaunchServer, and it waits for them to start accepting connections before returning. From noreply at github.com Sat Apr 14 18:57:56 2018 From: noreply at github.com (GitHub) Date: Sat, 14 Apr 2018 10:57:56 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 2fc646: Improve logging of command socket connections/wait... Message-ID: <5ad24124b33aa_16172aad3791dc1410215a@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 2fc646de5242efd3fc9777493efd2d90f1e832e8 https://github.com/boxbackup/boxbackup/commit/2fc646de5242efd3fc9777493efd2d90f1e832e8 Author: Chris Wilson Date: 2018-04-14 (Sat, 14 Apr 2018) Changed paths: M lib/bbackupd/BackupDaemon.cpp Log Message: ----------- Improve logging of command socket connections/waits in BackupDaemon Commit: 6eea469df58871107ade7e9507ac53bc90b1635b https://github.com/boxbackup/boxbackup/commit/6eea469df58871107ade7e9507ac53bc90b1635b Author: Chris Wilson Date: 2018-04-14 (Sat, 14 Apr 2018) Changed paths: M lib/server/ServerControl.cpp Log Message: ----------- Improve logging and error handling in ServerControl Commit: 66b1e786eb1dadd404c30e24220adb1b73936f06 https://github.com/boxbackup/boxbackup/commit/66b1e786eb1dadd404c30e24220adb1b73936f06 Author: Chris Wilson Date: 2018-04-14 (Sat, 14 Apr 2018) Changed paths: M test/bbackupd/testbbackupd.cpp Log Message: ----------- Enable timestamp logging by default in test_continuously_updated_file Compare: https://github.com/boxbackup/boxbackup/compare/5f585ed8cca0...66b1e786eb1d From noreply at github.com Tue Apr 24 22:02:31 2018 From: noreply at github.com (GitHub) Date: Tue, 24 Apr 2018 14:02:31 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] aec39c: WaitForServerStartup: fix disturbance due to conne... Message-ID: <5adf9b676ff01_7d062acfb9611c104339c@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: aec39c47f9da45bd0b6f5f0aff00fb5a5ccac767 https://github.com/boxbackup/boxbackup/commit/aec39c47f9da45bd0b6f5f0aff00fb5a5ccac767 Author: Chris Wilson Date: 2018-04-24 (Tue, 24 Apr 2018) Changed paths: M lib/common/FileStream.h M lib/server/Daemon.cpp M lib/server/Daemon.h M lib/server/ServerControl.cpp M lib/server/ServerStream.h Log Message: ----------- WaitForServerStartup: fix disturbance due to connecting to sockets Attempting a connection to the daemon's server socket seems to upset it, making it unable to accept connections for some seconds afterwards, which defeats the point of the test. Instead, we have modified the server (Daemon) to not finish writing the PID file until it is completely ready to serve requests. From noreply at github.com Wed Apr 25 21:24:24 2018 From: noreply at github.com (GitHub) Date: Wed, 25 Apr 2018 13:24:24 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] ab2f18: WaitForServerStartup: fix disturbance due to conne... Message-ID: <5ae0e3f8e76a3_206c2afd876d3bfc915f4@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: ab2f18a3d191f11036ae17fa5912054d8ac4e628 https://github.com/boxbackup/boxbackup/commit/ab2f18a3d191f11036ae17fa5912054d8ac4e628 Author: Chris Wilson Date: 2018-04-25 (Wed, 25 Apr 2018) Changed paths: M lib/common/FileStream.h M lib/server/Daemon.cpp M lib/server/Daemon.h M lib/server/ServerControl.cpp M lib/server/ServerStream.h Log Message: ----------- WaitForServerStartup: fix disturbance due to connecting to sockets Attempting a connection to the daemon's server socket seems to upset it, making it unable to accept connections for some seconds afterwards, which defeats the point of the test. Instead, we have modified the server (Daemon) to not finish writing the PID file until it is completely ready to serve requests. From noreply at github.com Sun Apr 29 19:46:14 2018 From: noreply at github.com (GitHub) Date: Sun, 29 Apr 2018 11:46:14 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 990adb: Add extra checks that daemons are really ready to ... Message-ID: <5ae612f69c39d_49de2af2fa717c04173fd@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 990adb77bd0264d5125c32ed8bb1b66eb4bb326d https://github.com/boxbackup/boxbackup/commit/990adb77bd0264d5125c32ed8bb1b66eb4bb326d Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/backupstore/StoreTestUtils.cpp M lib/common/Test.cpp M lib/common/Test.h M lib/server/ServerControl.cpp M lib/server/ServerControl.h M test/backupstore/testbackupstore.cpp M test/basicserver/testbasicserver.cpp Log Message: ----------- Add extra checks that daemons are really ready to serve in tests Removing some sleeps has exposed race conditions where daemons write a PID file before they are actually ready to accept connections, and sometimes we would hit that in tests. Now we pass a port or UNIX socket (or both) to LaunchServer, and it waits for them to start accepting connections before returning. Commit: fb907e844a25f4932af07fddea60bccb3b554bbf https://github.com/boxbackup/boxbackup/commit/fb907e844a25f4932af07fddea60bccb3b554bbf Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/bbackupd/BackupDaemon.cpp Log Message: ----------- Improve logging of command socket connections/waits in BackupDaemon Commit: 10a352ecb0d28faee741bd4973aa359c8e0b6320 https://github.com/boxbackup/boxbackup/commit/10a352ecb0d28faee741bd4973aa359c8e0b6320 Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/server/ServerControl.cpp Log Message: ----------- Improve logging and error handling in ServerControl Commit: ae2cf00409bf3d522988c67c2ed761a788457d07 https://github.com/boxbackup/boxbackup/commit/ae2cf00409bf3d522988c67c2ed761a788457d07 Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M test/bbackupd/testbbackupd.cpp Log Message: ----------- Enable timestamp logging by default in test_continuously_updated_file Commit: a26fb74e4c3513edef01d029b648129e62f9db6a https://github.com/boxbackup/boxbackup/commit/a26fb74e4c3513edef01d029b648129e62f9db6a Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/common/FileStream.h M lib/server/Daemon.cpp M lib/server/Daemon.h M lib/server/ServerControl.cpp M lib/server/ServerStream.h Log Message: ----------- WaitForServerStartup: fix disturbance due to connecting to sockets Attempting a connection to the daemon's server socket seems to upset it, making it unable to accept connections for some seconds afterwards, which defeats the point of the test. Instead, we have modified the server (Daemon) to not finish writing the PID file until it is completely ready to serve requests. Compare: https://github.com/boxbackup/boxbackup/compare/ab2f18a3d191...a26fb74e4c35 From noreply at github.com Sun Apr 29 20:31:59 2018 From: noreply at github.com (GitHub) Date: Sun, 29 Apr 2018 12:31:59 -0700 Subject: [Box Backup-commit] [boxbackup/boxbackup] 6fb95a: Add extra checks that daemons are really ready to ... Message-ID: <5ae61dafa495e_3a082ad738319c0c202a0@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 6fb95aeacd92f6c90f07659545227bd95cf4f815 https://github.com/boxbackup/boxbackup/commit/6fb95aeacd92f6c90f07659545227bd95cf4f815 Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/backupstore/StoreTestUtils.cpp M lib/common/Test.cpp M lib/common/Test.h M lib/server/ServerControl.cpp M lib/server/ServerControl.h M test/backupstore/testbackupstore.cpp M test/basicserver/testbasicserver.cpp Log Message: ----------- Add extra checks that daemons are really ready to serve in tests Removing some sleeps has exposed race conditions where daemons write a PID file before they are actually ready to accept connections, and sometimes we would hit that in tests. Now we pass a port or UNIX socket (or both) to LaunchServer, and it waits for them to start accepting connections before returning. Commit: f0f843b4a4587d6464904473e310772d6c8ba374 https://github.com/boxbackup/boxbackup/commit/f0f843b4a4587d6464904473e310772d6c8ba374 Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/bbackupd/BackupDaemon.cpp Log Message: ----------- Improve logging of command socket connections/waits in BackupDaemon Commit: c326cb3e337a73f0c559519212b6173f6e489426 https://github.com/boxbackup/boxbackup/commit/c326cb3e337a73f0c559519212b6173f6e489426 Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/server/ServerControl.cpp Log Message: ----------- Improve logging and error handling in ServerControl Commit: a1fda5cf7e0aa7df2df00a33401ac1e5e4eb9f78 https://github.com/boxbackup/boxbackup/commit/a1fda5cf7e0aa7df2df00a33401ac1e5e4eb9f78 Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M test/bbackupd/testbbackupd.cpp Log Message: ----------- Enable timestamp logging by default in test_continuously_updated_file Commit: 00f7a546b427a1c7ef830ec4106bcc0e659a6b4b https://github.com/boxbackup/boxbackup/commit/00f7a546b427a1c7ef830ec4106bcc0e659a6b4b Author: Chris Wilson Date: 2018-04-29 (Sun, 29 Apr 2018) Changed paths: M lib/common/FileStream.h M lib/server/Daemon.cpp M lib/server/Daemon.h M lib/server/ServerControl.cpp M lib/server/ServerStream.h Log Message: ----------- WaitForServerStartup: fix disturbance due to connecting to sockets Attempting a connection to the daemon's server socket seems to upset it, making it unable to accept connections for some seconds afterwards, which defeats the point of the test. Instead, we have modified the server (Daemon) to not finish writing the PID file until it is completely ready to serve requests. Compare: https://github.com/boxbackup/boxbackup/compare/a26fb74e4c35...00f7a546b427