[Box Backup-commit] [boxbackup/boxbackup] 5f585e: Add extra checks that daemons are really ready to ...

GitHub noreply at github.com
Wed Apr 11 22:22:47 BST 2018

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 5f585ed8cca0a8c9560d0c4bb94251408df66aa2
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M lib/backupstore/StoreTestUtils.cpp
    M lib/common/Test.cpp
    M lib/common/Test.h
    M lib/server/ServerControl.cpp
    M lib/server/ServerControl.h
    M test/backupstore/testbackupstore.cpp
    M test/basicserver/testbasicserver.cpp

  Log Message:
  Add extra checks that daemons are really ready to serve in tests

Removing some sleeps has exposed race conditions where daemons write a PID file
before they are actually ready to accept connections, and sometimes we would
hit that in tests. Now we pass a port or UNIX socket (or both) to LaunchServer,
and it waits for them to start accepting connections before returning.

More information about the Boxbackup-commit mailing list