[Box Backup-commit] [boxbackup/boxbackup] 990adb: Add extra checks that daemons are really ready to ...

GitHub noreply at github.com
Sun Apr 29 19:46:14 BST 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 990adb77bd0264d5125c32ed8bb1b66eb4bb326d
      https://github.com/boxbackup/boxbackup/commit/990adb77bd0264d5125c32ed8bb1b66eb4bb326d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/backupstore/StoreTestUtils.cpp
    M lib/common/Test.cpp
    M lib/common/Test.h
    M lib/server/ServerControl.cpp
    M lib/server/ServerControl.h
    M test/backupstore/testbackupstore.cpp
    M test/basicserver/testbasicserver.cpp

  Log Message:
  -----------
  Add extra checks that daemons are really ready to serve in tests

Removing some sleeps has exposed race conditions where daemons write a PID file
before they are actually ready to accept connections, and sometimes we would
hit that in tests. Now we pass a port or UNIX socket (or both) to LaunchServer,
and it waits for them to start accepting connections before returning.


  Commit: fb907e844a25f4932af07fddea60bccb3b554bbf
      https://github.com/boxbackup/boxbackup/commit/fb907e844a25f4932af07fddea60bccb3b554bbf
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/bbackupd/BackupDaemon.cpp

  Log Message:
  -----------
  Improve logging of command socket connections/waits in BackupDaemon


  Commit: 10a352ecb0d28faee741bd4973aa359c8e0b6320
      https://github.com/boxbackup/boxbackup/commit/10a352ecb0d28faee741bd4973aa359c8e0b6320
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/server/ServerControl.cpp

  Log Message:
  -----------
  Improve logging and error handling in ServerControl


  Commit: ae2cf00409bf3d522988c67c2ed761a788457d07
      https://github.com/boxbackup/boxbackup/commit/ae2cf00409bf3d522988c67c2ed761a788457d07
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M test/bbackupd/testbbackupd.cpp

  Log Message:
  -----------
  Enable timestamp logging by default in test_continuously_updated_file


  Commit: a26fb74e4c3513edef01d029b648129e62f9db6a
      https://github.com/boxbackup/boxbackup/commit/a26fb74e4c3513edef01d029b648129e62f9db6a
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/common/FileStream.h
    M lib/server/Daemon.cpp
    M lib/server/Daemon.h
    M lib/server/ServerControl.cpp
    M lib/server/ServerStream.h

  Log Message:
  -----------
  WaitForServerStartup: fix disturbance due to connecting to sockets

Attempting a connection to the daemon's server socket seems to upset it, making
it unable to accept connections for some seconds afterwards, which defeats the
point of the test.

Instead, we have modified the server (Daemon) to not finish writing the PID
file until it is completely ready to serve requests.


Compare: https://github.com/boxbackup/boxbackup/compare/ab2f18a3d191...a26fb74e4c35


More information about the Boxbackup-commit mailing list