[Box Backup-commit] [boxbackup/boxbackup] 6fb95a: Add extra checks that daemons are really ready to ...

GitHub noreply at github.com
Sun Apr 29 20:31:59 BST 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 6fb95aeacd92f6c90f07659545227bd95cf4f815
      https://github.com/boxbackup/boxbackup/commit/6fb95aeacd92f6c90f07659545227bd95cf4f815
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/backupstore/StoreTestUtils.cpp
    M lib/common/Test.cpp
    M lib/common/Test.h
    M lib/server/ServerControl.cpp
    M lib/server/ServerControl.h
    M test/backupstore/testbackupstore.cpp
    M test/basicserver/testbasicserver.cpp

  Log Message:
  -----------
  Add extra checks that daemons are really ready to serve in tests

Removing some sleeps has exposed race conditions where daemons write a PID file
before they are actually ready to accept connections, and sometimes we would
hit that in tests. Now we pass a port or UNIX socket (or both) to LaunchServer,
and it waits for them to start accepting connections before returning.


  Commit: f0f843b4a4587d6464904473e310772d6c8ba374
      https://github.com/boxbackup/boxbackup/commit/f0f843b4a4587d6464904473e310772d6c8ba374
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/bbackupd/BackupDaemon.cpp

  Log Message:
  -----------
  Improve logging of command socket connections/waits in BackupDaemon


  Commit: c326cb3e337a73f0c559519212b6173f6e489426
      https://github.com/boxbackup/boxbackup/commit/c326cb3e337a73f0c559519212b6173f6e489426
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/server/ServerControl.cpp

  Log Message:
  -----------
  Improve logging and error handling in ServerControl


  Commit: a1fda5cf7e0aa7df2df00a33401ac1e5e4eb9f78
      https://github.com/boxbackup/boxbackup/commit/a1fda5cf7e0aa7df2df00a33401ac1e5e4eb9f78
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M test/bbackupd/testbbackupd.cpp

  Log Message:
  -----------
  Enable timestamp logging by default in test_continuously_updated_file


  Commit: 00f7a546b427a1c7ef830ec4106bcc0e659a6b4b
      https://github.com/boxbackup/boxbackup/commit/00f7a546b427a1c7ef830ec4106bcc0e659a6b4b
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M lib/common/FileStream.h
    M lib/server/Daemon.cpp
    M lib/server/Daemon.h
    M lib/server/ServerControl.cpp
    M lib/server/ServerStream.h

  Log Message:
  -----------
  WaitForServerStartup: fix disturbance due to connecting to sockets

Attempting a connection to the daemon's server socket seems to upset it, making
it unable to accept connections for some seconds afterwards, which defeats the
point of the test.

Instead, we have modified the server (Daemon) to not finish writing the PID
file until it is completely ready to serve requests.


Compare: https://github.com/boxbackup/boxbackup/compare/a26fb74e4c35...00f7a546b427


More information about the Boxbackup-commit mailing list