[Box Backup-commit] [boxbackup/boxbackup] a8665d: FileStream: implement real file locking on Windows

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: a8665d53f9e20c6ab63363be3bd2bd589e3078de
      https://github.com/boxbackup/boxbackup/commit/a8665d53f9e20c6ab63363be3bd2bd589e3078de
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M lib/common/FileStream.cpp
    M lib/common/FileStream.h

  Log Message:
  -----------
  FileStream: implement real file locking on Windows

Previously we just used dwShareMode, but that doesn't give us a way
to wait for a lock, while LockFileEx does. Unfortunately LockFileEx
is mandatory locking, so you can't write to a file that is open in
SHARED mode, so change the default locking mode to NONE for
compatibility, without having to add EXCLUSIVE locks to all files
opened for writing.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.