[Box Backup-commit] [boxbackup/boxbackup] e9fbe0: BackupStoreRefCountDatabaseWrapper: don't save in ...

GitHub noreply at github.com
Sat Aug 4 11:00:50 BST 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: e9fbe0cc4f286ca2abfada6ece50eb4878b2ba81
      https://github.com/boxbackup/boxbackup/commit/e9fbe0cc4f286ca2abfada6ece50eb4878b2ba81
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-08-04 (Sat, 04 Aug 2018)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  BackupStoreRefCountDatabaseWrapper: don't save in destructor

The database should already have been committed or discarded, and it's
too late to call BackupFileSystem::OnCommit. Just leave it alone.


  Commit: c8db650613bcd1c16da61f3404ff63146a22347b
      https://github.com/boxbackup/boxbackup/commit/c8db650613bcd1c16da61f3404ff63146a22347b
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-08-04 (Sat, 04 Aug 2018)

  Changed paths:
    M lib/backupstore/BackupFileSystem.h

  Log Message:
  -----------
  BackupStoreRefCountDatabaseWrapper: Close DB before trying to Save it

This is needed to release the lock on the file, and is probably good
practice anyway.


Compare: https://github.com/boxbackup/boxbackup/compare/e4553cb5eab9...c8db650613bc
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Boxbackup-commit mailing list