[Box Backup-commit] [boxbackup/boxbackup] 5dda9b: Cleanup stale PID files only in testbasicserver

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 5dda9bc5aee7701bbe1bd03e3e9483d7938d2cdf
      https://github.com/boxbackup/boxbackup/commit/5dda9bc5aee7701bbe1bd03e3e9483d7938d2cdf
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-08-04 (Sat, 04 Aug 2018)

  Changed paths:
    M lib/common/Test.cpp
    M lib/common/Test.h
    M test/basicserver/testbasicserver.cpp

  Log Message:
  -----------
  Cleanup stale PID files only in testbasicserver

Other tests don't start random servers, and have better cleanup
mechanisms for well-known ones, which ensure that the server is not
running and hence not holding a lock on its PID file.


  Commit: 0be53f144c73616b397b8e781d098ec4c37938e9
      https://github.com/boxbackup/boxbackup/commit/0be53f144c73616b397b8e781d098ec4c37938e9
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-08-04 (Sat, 04 Aug 2018)

  Changed paths:
    M lib/common/Utils.cpp

  Log Message:
  -----------
  Utils: improve error message when failed to check for existence of file


  Commit: c7ed7e8de6eb3e1cd8bb258ed742ebfd56e61fef
      https://github.com/boxbackup/boxbackup/commit/c7ed7e8de6eb3e1cd8bb258ed742ebfd56e61fef
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-08-04 (Sat, 04 Aug 2018)

  Changed paths:
    M lib/server/ServerControl.cpp

  Log Message:
  -----------
  ServerControl: allow stopping server even if PID file existed before

Don't fail to return the new PID if the PID file already existed, but
with an old PID inside.


Compare: https://github.com/boxbackup/boxbackup/compare/c8db650613bc...c7ed7e8de6eb
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.