[Box Backup-commit] [boxbackup/boxbackup] 4d8f77: SocketStream: retry connect() if interrupted by a ...

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 4d8f77db443913dd04064be61c65dc25854c4380
      https://github.com/boxbackup/boxbackup/commit/4d8f77db443913dd04064be61c65dc25854c4380
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-08-27 (Mon, 27 Aug 2018)

  Changed paths:
    M lib/common/Logging.h
    M lib/server/SocketStream.cpp
    M lib/server/SocketStream.h
    M lib/server/SocketStreamTLS.cpp
    M lib/server/SocketStreamTLS.h
    M test/basicserver/testbasicserver.cpp

  Log Message:
  -----------
  SocketStream: retry connect() if interrupted by a signal, with a timeout

Until this was implemented, S3 calls would quite often fail randomly, because
the S3 client establishes many connections (because HTTP Connection: keep-alive
is not implemented) and we use signals for alarms (timeouts, diffing timers,
etc) in the backup client.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.