[Box Backup-commit] [boxbackup/boxbackup] 190991: SocketStream: retry connect() if interrupted by a ...
GitHub
noreply at github.com
Tue Aug 28 19:17:20 BST 2018
Branch: refs/heads/s3_support
Home: https://github.com/boxbackup/boxbackup
Commit: 190991c8748bb3866a709f9954b856b8cea656c7
https://github.com/boxbackup/boxbackup/commit/190991c8748bb3866a709f9954b856b8cea656c7
Author: Chris Wilson <chris+github at qwirx.com>
Date: 2018-08-28 (Tue, 28 Aug 2018)
Changed paths:
M lib/backupclient/ConfiguredBackupClient.cpp
M lib/backupstore/StoreTestUtils.h
M lib/common/Logging.h
M lib/httpserver/S3Client.cpp
M lib/httpserver/SimpleDBClient.cpp
M lib/server/SocketStream.cpp
M lib/server/SocketStream.h
M lib/server/SocketStreamTLS.cpp
M lib/server/SocketStreamTLS.h
M test/basicserver/testbasicserver.cpp
Log Message:
-----------
SocketStream: retry connect() if interrupted by a signal, with a timeout
Until this was implemented, S3 calls would quite often fail randomly, because
the S3 client establishes many connections (because HTTP Connection: keep-alive
is not implemented) and we use signals for alarms (timeouts, diffing timers,
etc) in the backup client.
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
More information about the Boxbackup-commit
mailing list