[Box Backup-commit] [boxbackup/boxbackup] 5a6825: Fix failing test_backup_hardlinked_files

GitHub noreply at github.com
Fri Dec 28 22:10:21 GMT 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 5a68258dea8459a8f91760e2e2e881a3d38fa52d
      https://github.com/boxbackup/boxbackup/commit/5a68258dea8459a8f91760e2e2e881a3d38fa52d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-12-28 (Fri, 28 Dec 2018)

  Changed paths:
    M lib/bbackupd/BackupClientDirectoryRecord.cpp
    M lib/bbackupd/BackupClientDirectoryRecord.h
    M lib/bbackupd/BackupDaemon.cpp
    M lib/bbackupd/BackupDaemon.h
    M test/bbackupd/testbbackupd.cpp

  Log Message:
  -----------
  Fix failing test_backup_hardlinked_files

Remove assertion that inode numbers were not reused, which was incompatible
with hard links and violated under certain circumstances. Add a test that
reproduces those circumstances.


  Commit: a033e6cc0a71cce8493795d407d1938ed31d52ef
      https://github.com/boxbackup/boxbackup/commit/a033e6cc0a71cce8493795d407d1938ed31d52ef
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-12-28 (Fri, 28 Dec 2018)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp
    M lib/backupstore/BackupFileSystem.h
    M lib/backupstore/BackupStoreCheck.cpp
    M lib/backupstore/HousekeepStoreAccount.cpp
    M lib/common/Logging.cpp
    M lib/common/Logging.h
    M lib/common/Test.cpp

  Log Message:
  -----------
  Improve handling of exceptions in destructors

Destructors are not allowed to throw exceptions, and although we log a warning
if we catch one, it was easy to miss in automated tests. Now the exception is
recorded and causes a test failure during tearDown() instead.


Compare: https://github.com/boxbackup/boxbackup/compare/8ba44fb823d5...a033e6cc0a71
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Boxbackup-commit mailing list