From noreply at github.com Mon Feb 5 22:41:43 2018 From: noreply at github.com (GitHub) Date: Mon, 05 Feb 2018 14:41:43 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 026c10: Add CreateTemporaryFile support to FileStream Message-ID: <5a78dda7cbe3e_591e2ae356255c10435b2@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 026c1025bcbb0091fb7b0d9f869d45e6e606751f https://github.com/boxbackup/boxbackup/commit/026c1025bcbb0091fb7b0d9f869d45e6e606751f Author: Chris Wilson Date: 2017-12-28 (Thu, 28 Dec 2017) Changed paths: M lib/backupstore/BackupStoreCheck.cpp M lib/backupstore/BackupStoreException.txt M lib/common/CommonException.txt M lib/common/FileStream.cpp M lib/common/FileStream.h R lib/common/InvisibleTempFileStream.cpp M lib/common/InvisibleTempFileStream.h Log Message: ----------- Add CreateTemporaryFile support to FileStream InvisibleTempFileStream becomes a trivial wrapper around this. Commit: 2076349c9c8412a890c6887cc6fe675fd385d951 https://github.com/boxbackup/boxbackup/commit/2076349c9c8412a890c6887cc6fe675fd385d951 Author: Chris Wilson Date: 2017-12-28 (Thu, 28 Dec 2017) Changed paths: M lib/backupstore/BackupStoreCheck2.cpp M lib/backupstore/BackupStoreContext.cpp M lib/backupstore/BackupStoreDirectory.cpp M lib/backupstore/BackupStoreDirectory.h M lib/backupstore/BackupStoreObjectDump.cpp M lib/backupstore/HousekeepStoreAccount.cpp M test/backupstore/testbackupstore.cpp M test/backupstorefix/testbackupstorefix.cpp M test/backupstorepatch/testbackupstorepatch.cpp Log Message: ----------- Rename Depends{Older,Newer} to DependsOn and RequiredBy This will make the code clearer when implementing support for patches in S3BackupFileSystem, where DependsNewer and DependsOlder have a very different meaning, and also for RaidBackupFileSystem where DependsOlder does not mean that we depend on the old file at all, but that it depends on us. Commit: c28c1bcc2349e27fbd6e099f561fe1a176a5c6ed https://github.com/boxbackup/boxbackup/commit/c28c1bcc2349e27fbd6e099f561fe1a176a5c6ed Author: Chris Wilson Date: 2017-12-28 (Thu, 28 Dec 2017) Changed paths: M lib/backupstore/BackupFileSystem.cpp M lib/backupstore/BackupFileSystem.h M lib/backupstore/BackupStoreContext.cpp M lib/backupstore/BackupStoreFile.cpp M test/backupstore/testbackupstore.cpp Log Message: ----------- Add support for merging patches in S3BackupFileSystem Enable test_multiple_uploads(s3) which requires this. Compare: https://github.com/boxbackup/boxbackup/compare/6df32f038e77...c28c1bcc2349 From noreply at github.com Tue Feb 6 22:19:21 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 14:19:21 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 90e10f: Add CreateTemporaryFile support to FileStream Message-ID: <5a7a29e97c33e_2b00a2aafbe111c1c97851@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 90e10fe6ca1661cd580ff071b44c6ce67c031407 https://github.com/boxbackup/boxbackup/commit/90e10fe6ca1661cd580ff071b44c6ce67c031407 Author: Chris Wilson Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/backupstore/BackupStoreCheck.cpp M lib/backupstore/BackupStoreException.txt M lib/common/CommonException.txt M lib/common/FileStream.cpp M lib/common/FileStream.h R lib/common/InvisibleTempFileStream.cpp M lib/common/InvisibleTempFileStream.h Log Message: ----------- Add CreateTemporaryFile support to FileStream InvisibleTempFileStream becomes a trivial wrapper around this. Commit: 4ef8945c2750133fcb608d37f3e9d990b36eaf22 https://github.com/boxbackup/boxbackup/commit/4ef8945c2750133fcb608d37f3e9d990b36eaf22 Author: Chris Wilson Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/backupstore/BackupStoreCheck2.cpp M lib/backupstore/BackupStoreContext.cpp M lib/backupstore/BackupStoreDirectory.cpp M lib/backupstore/BackupStoreDirectory.h M lib/backupstore/BackupStoreObjectDump.cpp M lib/backupstore/HousekeepStoreAccount.cpp M test/backupstore/testbackupstore.cpp M test/backupstorefix/testbackupstorefix.cpp M test/backupstorepatch/testbackupstorepatch.cpp Log Message: ----------- Rename Depends{Older,Newer} to DependsOn and RequiredBy This will make the code clearer when implementing support for patches in S3BackupFileSystem, where DependsNewer and DependsOlder have a very different meaning, and also for RaidBackupFileSystem where DependsOlder does not mean that we depend on the old file at all, but that it depends on us. Commit: acd8fab5393c21705883dcce976223707972ef2c https://github.com/boxbackup/boxbackup/commit/acd8fab5393c21705883dcce976223707972ef2c Author: Chris Wilson Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/backupstore/BackupFileSystem.cpp M lib/backupstore/BackupFileSystem.h M lib/backupstore/BackupStoreContext.cpp M lib/backupstore/BackupStoreFile.cpp M test/backupstore/testbackupstore.cpp Log Message: ----------- Add support for merging patches in S3BackupFileSystem Enable test_multiple_uploads(s3) which requires this. Compare: https://github.com/boxbackup/boxbackup/compare/c28c1bcc2349...acd8fab5393c From noreply at github.com Wed Feb 7 22:26:58 2018 From: noreply at github.com (GitHub) Date: Wed, 07 Feb 2018 14:26:58 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] c1449b: Fix erroneous deletion of incomplete type Message-ID: <5a7b7d3260f38_28502b2677d11c1c7432d@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: c1449bea26fd0a831603dd8e9e7b8cef856f4674 https://github.com/boxbackup/boxbackup/commit/c1449bea26fd0a831603dd8e9e7b8cef856f4674 Author: Chris Wilson Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M infrastructure/cmake/CMakeLists.txt M lib/backupstore/BackupFileSystem.h Log Message: ----------- Fix erroneous deletion of incomplete type From noreply at github.com Wed Feb 7 22:33:09 2018 From: noreply at github.com (GitHub) Date: Wed, 07 Feb 2018 14:33:09 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 844c54: Reduce verbosity of Windows superbuild, OpenSSL st... Message-ID: <5a7b7ea5e6f54_71b52b18e0b33c141219f6@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 844c545548ee73ded0dec3441aa77c027a0fee74 https://github.com/boxbackup/boxbackup/commit/844c545548ee73ded0dec3441aa77c027a0fee74 Author: Chris Wilson Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- Reduce verbosity of Windows superbuild, OpenSSL step From noreply at github.com Thu Feb 8 22:46:43 2018 From: noreply at github.com (GitHub) Date: Thu, 08 Feb 2018 14:46:43 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 426d04: Disable MS linker warning LNK4221 Message-ID: <5a7cd353aed9a_6a6a2b2583ea5c08495c4@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 426d04e016cc7f4cccd1aad34c148edfd8220990 https://github.com/boxbackup/boxbackup/commit/426d04e016cc7f4cccd1aad34c148edfd8220990 Author: Chris Wilson Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M infrastructure/cmake/CMakeLists.txt Log Message: ----------- Disable MS linker warning LNK4221 This warns us that some object files do not define any symbols. In our case, this happens because all code in the file is excluded by preprocessor directives, which is deliberate and not an error, so it's not useful. From noreply at github.com Thu Feb 8 22:50:34 2018 From: noreply at github.com (GitHub) Date: Thu, 08 Feb 2018 14:50:34 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 07d452: CMake superbuild: reduce verbosity of OpenSSL buil... Message-ID: <5a7cd43ade0c1_44722aee5361fc081040fe@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 07d452202cf453f73846e4360d152503bf626280 https://github.com/boxbackup/boxbackup/commit/07d452202cf453f73846e4360d152503bf626280 Author: Chris Wilson Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- CMake superbuild: reduce verbosity of OpenSSL build and install steps on Windows. Commit: 57dc29fa044a692696e69ff0a1f93af4c1c2917c https://github.com/boxbackup/boxbackup/commit/57dc29fa044a692696e69ff0a1f93af4c1c2917c Author: Chris Wilson Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M infrastructure/cmake/CMakeLists.txt Log Message: ----------- Disable MS linker warning LNK4221 This warns us that some object files do not define any symbols. In our case, this happens because all code in the file is excluded by preprocessor directives, which is deliberate and not an error, so it's not useful. Commit: a1762fc586d27c8468b1fe809a844bb01920a2c6 https://github.com/boxbackup/boxbackup/commit/a1762fc586d27c8468b1fe809a844bb01920a2c6 Author: Chris Wilson Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M appveyor.yml Log Message: ----------- Appveyor config: recommend users to install vim-tux instead of vim Vim-tux seems to work much better on Windows: faster, and with multiple tab support. Compare: https://github.com/boxbackup/boxbackup/compare/426d04e016cc...a1762fc586d2 From noreply at github.com Fri Feb 9 21:59:11 2018 From: noreply at github.com (GitHub) Date: Fri, 09 Feb 2018 13:59:11 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 5193f3: CMake Windows Superbuild: disable parts of PCRE th... Message-ID: <5a7e19af5377_7c492b2146a03c04795a3@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 5193f33e0c3dfdfb9ded1bf0aaba5a91cc32fc57 https://github.com/boxbackup/boxbackup/commit/5193f33e0c3dfdfb9ded1bf0aaba5a91cc32fc57 Author: Chris Wilson Date: 2018-02-09 (Fri, 09 Feb 2018) Changed paths: M infrastructure/cmake/windows/CMakeLists.txt Log Message: ----------- CMake Windows Superbuild: disable parts of PCRE that we don't need Commit: da722d3a427bfca7035ca2bb53a54305453f9d10 https://github.com/boxbackup/boxbackup/commit/da722d3a427bfca7035ca2bb53a54305453f9d10 Author: Chris Wilson Date: 2018-02-09 (Fri, 09 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- GetTempDirPath(): remove any trailing directory separator Compare: https://github.com/boxbackup/boxbackup/compare/a1762fc586d2...da722d3a427b From noreply at github.com Mon Feb 12 20:54:15 2018 From: noreply at github.com (GitHub) Date: Mon, 12 Feb 2018 12:54:15 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] a1e427: Refactor headers to reduce coupling Message-ID: <5a81fef793b6_39012ac891f13c0c13032c@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: a1e42748e03616c5a5f6b4d8344a8fc185f2347c https://github.com/boxbackup/boxbackup/commit/a1e42748e03616c5a5f6b4d8344a8fc185f2347c Author: Chris Wilson Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MemLeakFindOn.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. From noreply at github.com Mon Feb 12 21:25:48 2018 From: noreply at github.com (GitHub) Date: Mon, 12 Feb 2018 13:25:48 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 329ab3: Refactor headers to reduce coupling Message-ID: <5a82065cab6f1_2b2ec2ac856cdfc001234ed@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 329ab3780bc41cd732e849e1ce8cd58b01f4fa12 https://github.com/boxbackup/boxbackup/commit/329ab3780bc41cd732e849e1ce8cd58b01f4fa12 Author: Chris Wilson Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MemLeakFindOn.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. From noreply at github.com Mon Feb 12 21:27:11 2018 From: noreply at github.com (GitHub) Date: Mon, 12 Feb 2018 13:27:11 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 4c7c58: Refactor headers to reduce coupling Message-ID: <5a8206afa74c8_24b12ae076d8dc14414e8@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 4c7c5842bc6a0b8516efcf100e5efee84b4d909d https://github.com/boxbackup/boxbackup/commit/4c7c5842bc6a0b8516efcf100e5efee84b4d909d Author: Chris Wilson Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MemLeakFindOn.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. From noreply at github.com Mon Feb 12 21:58:34 2018 From: noreply at github.com (GitHub) Date: Mon, 12 Feb 2018 13:58:34 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] eae8e3: LineBuffer.h: update header comment and #include g... Message-ID: <5a820e0ab690c_6c7f2add87dc5c141022a@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: eae8e3fe3b536110d3ae90bfe7c13830b63e57a2 https://github.com/boxbackup/boxbackup/commit/eae8e3fe3b536110d3ae90bfe7c13830b63e57a2 Author: Chris Wilson Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: aa6e521dca6ae849e885bc1545133995425f5f8f https://github.com/boxbackup/boxbackup/commit/aa6e521dca6ae849e885bc1545133995425f5f8f Author: Chris Wilson Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: f4ddaa24193c3114e907a3f3afaf6b6a7e4308aa https://github.com/boxbackup/boxbackup/commit/f4ddaa24193c3114e907a3f3afaf6b6a7e4308aa Author: Chris Wilson Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Compare: https://github.com/boxbackup/boxbackup/compare/4c7c5842bc6a...f4ddaa24193c From noreply at github.com Thu Feb 15 22:15:12 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 14:15:12 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] ad810d: Logging: improve performance by not generating mes... Message-ID: <5a860670ca780_3002b0e32289c0c8604@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: ad810df3cae4cca09e71a51d8cb40c112f51410f https://github.com/boxbackup/boxbackup/commit/ad810df3cae4cca09e71a51d8cb40c112f51410f Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: c094e0c28656da4125ab75d2e6ce831f335f5cff https://github.com/boxbackup/boxbackup/commit/c094e0c28656da4125ab75d2e6ce831f335f5cff Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Compare: https://github.com/boxbackup/boxbackup/compare/f4ddaa24193c...c094e0c28656 From noreply at github.com Thu Feb 15 22:17:13 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 14:17:13 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 40e0bc: Refactor headers to reduce coupling Message-ID: <5a8606e97edfa_33882abaa755fc08818c5@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 40e0bc0d05ef752a4cfd8adc330e9635afec1da0 https://github.com/boxbackup/boxbackup/commit/40e0bc0d05ef752a4cfd8adc330e9635afec1da0 Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemLeakFindOn.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: e2bf36214128a83b07cbd968ca2b51453685eb1a https://github.com/boxbackup/boxbackup/commit/e2bf36214128a83b07cbd968ca2b51453685eb1a Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: 8026fd52e439a592ff0dd250b8981e74048c88d2 https://github.com/boxbackup/boxbackup/commit/8026fd52e439a592ff0dd250b8981e74048c88d2 Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: 991748f20cff34e140190320b83c0638e13bfc58 https://github.com/boxbackup/boxbackup/commit/991748f20cff34e140190320b83c0638e13bfc58 Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Compare: https://github.com/boxbackup/boxbackup/compare/c094e0c28656...991748f20cff From noreply at github.com Thu Feb 15 22:47:27 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 14:47:27 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 346d97: Refactor headers to reduce coupling Message-ID: <5a860dffa1b9f_30192af3c98b9c04732c3@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 346d970b2ae2f7ebf9c13fb13b788f999a50975e https://github.com/boxbackup/boxbackup/commit/346d970b2ae2f7ebf9c13fb13b788f999a50975e Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemLeakFindOn.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: 67c2b4ec8afdf09b00dbe4003aadac5f042f4b30 https://github.com/boxbackup/boxbackup/commit/67c2b4ec8afdf09b00dbe4003aadac5f042f4b30 Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: c18c0be7cb064249e801fa5ab4a29b55393799c5 https://github.com/boxbackup/boxbackup/commit/c18c0be7cb064249e801fa5ab4a29b55393799c5 Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: 1d77b48201ea32bec6e08e0a543f36ec4ab85bad https://github.com/boxbackup/boxbackup/commit/1d77b48201ea32bec6e08e0a543f36ec4ab85bad Author: Chris Wilson Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Compare: https://github.com/boxbackup/boxbackup/compare/991748f20cff...1d77b48201ea From noreply at github.com Sat Feb 17 22:45:09 2018 From: noreply at github.com (GitHub) Date: Sat, 17 Feb 2018 14:45:09 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 9088ee: Logging: improve performance by not generating mes... Message-ID: <5a88b07554f96_39082ab8b7b29c0c113557@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 9088ee4e2eb4363ba7cafd2db152753d99d6605f https://github.com/boxbackup/boxbackup/commit/9088ee4e2eb4363ba7cafd2db152753d99d6605f Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: 9f594f619646b85b369d58dded78124d7e37c6e9 https://github.com/boxbackup/boxbackup/commit/9f594f619646b85b369d58dded78124d7e37c6e9 Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Compare: https://github.com/boxbackup/boxbackup/compare/1d77b48201ea...9f594f619646 From noreply at github.com Sat Feb 17 23:03:40 2018 From: noreply at github.com (GitHub) Date: Sat, 17 Feb 2018 15:03:40 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 97edbe: RemovePrefix/Suffix should leave original string u... Message-ID: <5a88b4cc8efe3_559b2ab111457c1080172@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 97edbe32766d0954931ae898909d5d275dcd63eb https://github.com/boxbackup/boxbackup/commit/97edbe32766d0954931ae898909d5d275dcd63eb Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/common/Utils.cpp M test/common/testcommon.cpp Log Message: ----------- RemovePrefix/Suffix should leave original string unchanged if no match Commit: a7d554c71715d85ca83aa421a5dc12fc86379150 https://github.com/boxbackup/boxbackup/commit/a7d554c71715d85ca83aa421a5dc12fc86379150 Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- GetTempDirPath(): remove any trailing directory separator Commit: ca033e9a127da1985cdfcd5a7dd954c9b4af75f5 https://github.com/boxbackup/boxbackup/commit/ca033e9a127da1985cdfcd5a7dd954c9b4af75f5 Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemLeakFindOn.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: da6176f3c476ca23a45154173b7b21f121751ace https://github.com/boxbackup/boxbackup/commit/da6176f3c476ca23a45154173b7b21f121751ace Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: 329016535706acdfc6c5b93b38894202e1defcb3 https://github.com/boxbackup/boxbackup/commit/329016535706acdfc6c5b93b38894202e1defcb3 Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: 6d7dc9868adaed6f7f28b7a0598f558ab0be573b https://github.com/boxbackup/boxbackup/commit/6d7dc9868adaed6f7f28b7a0598f558ab0be573b Author: Chris Wilson Date: 2018-02-17 (Sat, 17 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Compare: https://github.com/boxbackup/boxbackup/compare/9f594f619646...6d7dc9868ada From noreply at github.com Sun Feb 18 17:04:43 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 09:04:43 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 46bede: Allow RemovePrefix/Suffix to return an arbitrary s... Message-ID: <5a89b22b5f339_6c6c2acee40d7c0c131150@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 46bede60dff293f847f16af5f5aefb812d2b4a67 https://github.com/boxbackup/boxbackup/commit/46bede60dff293f847f16af5f5aefb812d2b4a67 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp M lib/common/Utils.h M lib/httpserver/S3Simulator.cpp M test/common/testcommon.cpp Log Message: ----------- Allow RemovePrefix/Suffix to return an arbitrary string if prefix/suffix not found Commit: 8272be49ce5e5e38d38d73060f575d3c17823be6 https://github.com/boxbackup/boxbackup/commit/8272be49ce5e5e38d38d73060f575d3c17823be6 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- GetTempDirPath(): remove any trailing directory separator Commit: 4ad6b6af13e771056f43a1965643f868cf8271fa https://github.com/boxbackup/boxbackup/commit/4ad6b6af13e771056f43a1965643f868cf8271fa Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemLeakFindOn.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: 301df33037a33700d735c7de5427c276503f0b83 https://github.com/boxbackup/boxbackup/commit/301df33037a33700d735c7de5427c276503f0b83 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: f4addab2e34ed2916fef0aeb7680b31b421fa308 https://github.com/boxbackup/boxbackup/commit/f4addab2e34ed2916fef0aeb7680b31b421fa308 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: e77571da594d668e69ee9d38bb581a447729b184 https://github.com/boxbackup/boxbackup/commit/e77571da594d668e69ee9d38bb581a447729b184 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Compare: https://github.com/boxbackup/boxbackup/compare/6d7dc9868ada...e77571da594d From noreply at github.com Sun Feb 18 17:06:15 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 09:06:15 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] a673aa: Fix incorrect use of abi::__cxa_demangle Message-ID: <5a89b287fc53_7cbd2aba25f13c04735e3@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: a673aa1019222568b3d380c3471a625deb944171 https://github.com/boxbackup/boxbackup/commit/a673aa1019222568b3d380c3471a625deb944171 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- Fix incorrect use of abi::__cxa_demangle The buffer, if passed, should be allocated with malloc, not statically. In this case we don't need to allocate one first, we can use the default behaviour where abi::__cxa_demangle allocates one for us. From noreply at github.com Sun Feb 18 18:03:51 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 10:03:51 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 5c86ae: Refactor headers to reduce coupling Message-ID: <5a89c007ee113_797f2adb75499c08398c7@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 5c86aea2a87aefbf0f89c39782c1491056c58e32 https://github.com/boxbackup/boxbackup/commit/5c86aea2a87aefbf0f89c39782c1491056c58e32 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemLeakFindOn.h M lib/common/MemLeakFinder.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: f51c8e0de16395f99fbb293b5a2da91b74737dfb https://github.com/boxbackup/boxbackup/commit/f51c8e0de16395f99fbb293b5a2da91b74737dfb Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: fd6a094173b880f38952e49720c6e3182d3138b3 https://github.com/boxbackup/boxbackup/commit/fd6a094173b880f38952e49720c6e3182d3138b3 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: 04a9f4c9a45b17b56742762b30c379697972d6ac https://github.com/boxbackup/boxbackup/commit/04a9f4c9a45b17b56742762b30c379697972d6ac Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Commit: 68af0c450af84377f95b96b636ff501cf91dce1e https://github.com/boxbackup/boxbackup/commit/68af0c450af84377f95b96b636ff501cf91dce1e Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- Fix incorrect use of abi::__cxa_demangle The buffer, if passed, should be allocated with malloc, not statically. In this case we don't need to allocate one first, we can use the default behaviour where abi::__cxa_demangle allocates one for us. Compare: https://github.com/boxbackup/boxbackup/compare/a673aa101922...68af0c450af8 From noreply at github.com Sun Feb 18 18:06:43 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 10:06:43 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 5e5066: Refactor headers to reduce coupling Message-ID: <5a89c0b3c5bc1_72da2b17c4277c141233cd@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 5e506665e5fd65b0a0e775f03dc2ba6ddb4d200f https://github.com/boxbackup/boxbackup/commit/5e506665e5fd65b0a0e775f03dc2ba6ddb4d200f Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemLeakFindOn.h M lib/common/MemLeakFinder.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/CryptoUtils.h M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: b4507a6a903d038c9399d1f0565a4227596ddc24 https://github.com/boxbackup/boxbackup/commit/b4507a6a903d038c9399d1f0565a4227596ddc24 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: 0baa2a0c65cc164ba321446aa9be006e6e46a51e https://github.com/boxbackup/boxbackup/commit/0baa2a0c65cc164ba321446aa9be006e6e46a51e Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: 0569184e7476d7e0b638aa1ae577cc1e9d7d0a3e https://github.com/boxbackup/boxbackup/commit/0569184e7476d7e0b638aa1ae577cc1e9d7d0a3e Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Commit: 6e17b14d2848e11d2acda413ecfc1d61a196d1d2 https://github.com/boxbackup/boxbackup/commit/6e17b14d2848e11d2acda413ecfc1d61a196d1d2 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- Fix incorrect use of abi::__cxa_demangle The buffer, if passed, should be allocated with malloc, not statically. In this case we don't need to allocate one first, we can use the default behaviour where abi::__cxa_demangle allocates one for us. Compare: https://github.com/boxbackup/boxbackup/compare/68af0c450af8...6e17b14d2848 From noreply at github.com Sun Feb 18 20:24:37 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 12:24:37 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 949186: Refactor headers to reduce coupling Message-ID: <5a89e1054182f_6e0b2b00048b7c001164f6@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 949186cbaa322cc8925fde86e3276ba6fd94c996 https://github.com/boxbackup/boxbackup/commit/949186cbaa322cc8925fde86e3276ba6fd94c996 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/backupstore/BackupStoreDirectory.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupquery/BoxBackupCompareParams.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BoxTime.h M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemLeakFindOn.h M lib/common/MemLeakFinder.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/CryptoUtils.h M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: 08ec3532b8b08e3214a2a8997083bd449fb609e5 https://github.com/boxbackup/boxbackup/commit/08ec3532b8b08e3214a2a8997083bd449fb609e5 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: 52f62111751df0c3817f790b8cc36563b62ef918 https://github.com/boxbackup/boxbackup/commit/52f62111751df0c3817f790b8cc36563b62ef918 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: 8950f9e88789197bc13cfaf219a6e8020bc798f9 https://github.com/boxbackup/boxbackup/commit/8950f9e88789197bc13cfaf219a6e8020bc798f9 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Commit: ba054ae61205c5658578bab285903272801e1370 https://github.com/boxbackup/boxbackup/commit/ba054ae61205c5658578bab285903272801e1370 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- Fix incorrect use of abi::__cxa_demangle The buffer, if passed, should be allocated with malloc, not statically. In this case we don't need to allocate one first, we can use the default behaviour where abi::__cxa_demangle allocates one for us. Compare: https://github.com/boxbackup/boxbackup/compare/6e17b14d2848...ba054ae61205 From noreply at github.com Sun Feb 18 20:39:45 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 12:39:45 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 64bb71: Add more logging to test/basicserver for FreeBSD t... Message-ID: <5a89e4919f6a4_49862ae53334bc1c15707e@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 64bb71113ebd1772ed843b6f0cd432e9f770d61e https://github.com/boxbackup/boxbackup/commit/64bb71113ebd1772ed843b6f0cd432e9f770d61e Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M test/basicserver/testbasicserver.cpp Log Message: ----------- Add more logging to test/basicserver for FreeBSD timeouts (cherry picked from commit 2bfbf2995a09a6ce62a96c2bc07da6b88e014da6) From noreply at github.com Sun Feb 18 21:31:38 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 13:31:38 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 7ed4fc: Fix incorrect use of abi::__cxa_demangle Message-ID: <5a89f0ba86a41_96c2b216e1c3c1012063d@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 7ed4fcea9d13e5345c199b1375f5d5cf4a35bd54 https://github.com/boxbackup/boxbackup/commit/7ed4fcea9d13e5345c199b1375f5d5cf4a35bd54 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- Fix incorrect use of abi::__cxa_demangle The buffer, if passed, should be allocated with malloc, not statically. In this case we don't need to allocate one first, we can use the default behaviour where abi::__cxa_demangle allocates one for us. Commit: 8c91157e032e193bae7dcaf6854aaadc28480a3e https://github.com/boxbackup/boxbackup/commit/8c91157e032e193bae7dcaf6854aaadc28480a3e Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M test/basicserver/testbasicserver.cpp Log Message: ----------- Add more logging to test/basicserver for FreeBSD timeouts (cherry picked from commit 2bfbf2995a09a6ce62a96c2bc07da6b88e014da6) Compare: https://github.com/boxbackup/boxbackup/compare/64bb71113ebd...8c91157e032e From noreply at github.com Sun Feb 18 22:00:24 2018 From: noreply at github.com (GitHub) Date: Sun, 18 Feb 2018 14:00:24 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 0eb532: Refactor headers to reduce coupling Message-ID: <5a89f778a31df_2ef52aad205d7c109408e@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 0eb53246065c01f6e5ca74296f955b09f1ea8eaf https://github.com/boxbackup/boxbackup/commit/0eb53246065c01f6e5ca74296f955b09f1ea8eaf Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/backupclient/BackupClientCryptoKeys.cpp M lib/backupstore/BackupStoreCheck2.cpp M lib/backupstore/BackupStoreDirectory.h M lib/backupstore/BackupStoreFile.cpp M lib/backupstore/BackupStoreFileDiff.cpp M lib/backupstore/BackupStoreFileEncodeStream.cpp M lib/backupstore/BackupStoreFilenameClear.cpp M lib/backupstore/BackupStoreObjectDump.cpp M lib/backupstore/StoreTestUtils.cpp M lib/bbackupd/BackupClientDeleteList.cpp M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupquery/BoxBackupCompareParams.h M lib/bbackupquery/CommandCompletion.cpp M lib/bbstored/BBStoreDHousekeeping.cpp M lib/bbstored/BackupStoreDaemon.cpp M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BoxTime.h M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStream.cpp M lib/common/IOStreamGetLine.cpp M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/MainHelper.cpp M lib/common/MemBlockStream.cpp M lib/common/MemLeakFindOn.h M lib/common/MemLeakFinder.h M lib/common/NamedLock.cpp M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Timer.cpp M lib/common/UnixUser.cpp M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/CryptoUtils.h M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/httpserver/HTTPQueryDecoder.cpp M lib/httpserver/HTTPServer.cpp M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileRead.cpp M lib/raidfile/RaidFileUtil.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/Message.cpp M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/ServerControl.cpp M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeStream.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: 745f6b5cb8222310ea9f21ae087fded3d22a6917 https://github.com/boxbackup/boxbackup/commit/745f6b5cb8222310ea9f21ae087fded3d22a6917 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: adc054b129ed9067b2d7341975b5d671a6b17e0c https://github.com/boxbackup/boxbackup/commit/adc054b129ed9067b2d7341975b5d671a6b17e0c Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: a6ff6bc77a0d4ba6f7d6a440a9438a4f954baa73 https://github.com/boxbackup/boxbackup/commit/a6ff6bc77a0d4ba6f7d6a440a9438a4f954baa73 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Commit: 833fa4aa3d152ba060a9cbbbb9ee2b9d3ee50484 https://github.com/boxbackup/boxbackup/commit/833fa4aa3d152ba060a9cbbbb9ee2b9d3ee50484 Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- Fix incorrect use of abi::__cxa_demangle The buffer, if passed, should be allocated with malloc, not statically. In this case we don't need to allocate one first, we can use the default behaviour where abi::__cxa_demangle allocates one for us. Commit: 6bb9951143d58bceb2ac1b12bd7efc04ba7ace0a https://github.com/boxbackup/boxbackup/commit/6bb9951143d58bceb2ac1b12bd7efc04ba7ace0a Author: Chris Wilson Date: 2018-02-18 (Sun, 18 Feb 2018) Changed paths: M test/basicserver/testbasicserver.cpp Log Message: ----------- Add more logging to test/basicserver for FreeBSD timeouts (cherry picked from commit 2bfbf2995a09a6ce62a96c2bc07da6b88e014da6) Compare: https://github.com/boxbackup/boxbackup/compare/8c91157e032e...6bb9951143d5 From noreply at github.com Mon Feb 19 16:47:56 2018 From: noreply at github.com (GitHub) Date: Mon, 19 Feb 2018 08:47:56 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 974c8b: Refactor headers to reduce coupling Message-ID: <5a8affbc9d6a0_2b61e2acf47c31c0c773b2@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/s3_support Home: https://github.com/boxbackup/boxbackup Commit: 974c8b8924ded346b4c58754ba6b530d128afdb7 https://github.com/boxbackup/boxbackup/commit/974c8b8924ded346b4c58754ba6b530d128afdb7 Author: Chris Wilson Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M lib/backupclient/BackupClientCryptoKeys.cpp M lib/backupclient/BackupClientCryptoKeys.h M lib/backupclient/BackupClientRestore.h M lib/backupstore/BackupProtocol.h M lib/backupstore/BackupStoreAccountDatabase.h M lib/backupstore/BackupStoreCheck2.cpp M lib/backupstore/BackupStoreDirectory.h M lib/backupstore/BackupStoreFile.cpp M lib/backupstore/BackupStoreFile.h M lib/backupstore/BackupStoreFileDiff.cpp M lib/backupstore/BackupStoreFileEncodeStream.cpp M lib/backupstore/BackupStoreFileEncodeStream.h M lib/backupstore/BackupStoreFilenameClear.cpp M lib/backupstore/BackupStoreFilenameClear.h M lib/backupstore/BackupStoreObjectDump.cpp M lib/backupstore/StoreTestUtils.cpp M lib/backupstore/StoreTestUtils.h M lib/bbackupd/BackupClientDeleteList.cpp M lib/bbackupd/BackupClientDeleteList.h M lib/bbackupd/BackupClientInodeToIDMap.h M lib/bbackupd/BackupDaemonInterface.h M lib/bbackupd/Win32ServiceFunctions.cpp M lib/bbackupd/Win32ServiceFunctions.h M lib/bbackupquery/BoxBackupCompareParams.h M lib/bbackupquery/CommandCompletion.cpp M lib/bbstored/BBStoreDHousekeeping.cpp M lib/bbstored/BackupStoreDaemon.cpp M lib/bbstored/BackupStoreDaemon.h M lib/common/Box.h M lib/common/BoxException.h M lib/common/BoxTime.cpp M lib/common/BoxTime.h M lib/common/BufferedStream.cpp M lib/common/BufferedStream.h M lib/common/BufferedWriteStream.cpp M lib/common/Configuration.h M lib/common/ConversionString.cpp M lib/common/DebugMemLeakFinder.cpp A lib/common/Exception.h M lib/common/FdGetLine.cpp M lib/common/FileStream.cpp M lib/common/FileStream.h M lib/common/Guards.h M lib/common/IOStream.cpp M lib/common/IOStream.h M lib/common/IOStreamGetLine.cpp M lib/common/InvisibleTempFileStream.h M lib/common/LineBuffer.cpp M lib/common/LineBuffer.h M lib/common/Logging.cpp M lib/common/Logging.h M lib/common/MainHelper.cpp M lib/common/MemBlockStream.cpp M lib/common/MemBlockStream.h M lib/common/MemLeakFindOn.h M lib/common/MemLeakFinder.h M lib/common/NamedLock.cpp M lib/common/NamedLock.h M lib/common/PartialReadStream.cpp M lib/common/RateLimitingStream.cpp M lib/common/ReadGatherStream.cpp M lib/common/ReadLoggingStream.cpp M lib/common/StreamableMemBlock.cpp M lib/common/Test.cpp M lib/common/Test.h M lib/common/Timer.cpp M lib/common/Timer.h M lib/common/UnixUser.cpp M lib/common/UnixUser.h M lib/common/Utils.cpp M lib/common/WaitForEvent.cpp M lib/common/ZeroStream.cpp M lib/common/makeexception.pl.in M lib/compress/Compress.h M lib/compress/CompressStream.cpp M lib/crypto/CipherAES.cpp M lib/crypto/CipherAES.h M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherDescription.h M lib/crypto/CryptoUtils.cpp M lib/crypto/CryptoUtils.h M lib/crypto/MD5Digest.h M lib/crypto/Random.cpp M lib/httpserver/HTTPHeaders.cpp M lib/httpserver/HTTPQueryDecoder.cpp M lib/httpserver/HTTPQueryDecoder.h M lib/httpserver/HTTPServer.cpp M lib/httpserver/HTTPServer.h M lib/httpserver/S3Simulator.h M lib/httpserver/decode.h M lib/httpserver/encode.h M lib/intercept/intercept.cpp M lib/raidfile/RaidFileController.cpp M lib/raidfile/RaidFileRead.cpp M lib/raidfile/RaidFileRead.h M lib/raidfile/RaidFileUtil.cpp M lib/raidfile/RaidFileUtil.h M lib/server/LocalProcessStream.cpp M lib/server/LocalProcessStream.h M lib/server/Message.cpp M lib/server/Message.h M lib/server/Protocol.cpp M lib/server/ProtocolUncertainStream.cpp M lib/server/SSLLib.cpp M lib/server/ServerControl.cpp M lib/server/ServerControl.h M lib/server/ServerStream.h M lib/server/ServerTLS.h M lib/server/Socket.cpp M lib/server/SocketListen.h M lib/server/SocketStream.cpp M lib/server/SocketStream.h M lib/server/SocketStreamTLS.cpp M lib/server/TLSContext.cpp M lib/server/WinNamedPipeListener.h M lib/server/WinNamedPipeStream.cpp M lib/server/WinNamedPipeStream.h M lib/server/makeprotocol.pl.in Log Message: ----------- Refactor headers to reduce coupling Remove Logging and BoxException dependencies, ASSERT and THROW_* macros from Box.h, move them into a new header, Exception.h (not to be confused with BoxException.h, which just declares the BoxException class). This unfortunately means that a lot of C++ files now need to include Exception.h, and many more that silently depended on being imported now need to import it themselves, or just forward-declare it if they don't need a definition. Also simplify the logic for enabling memory leak detection. It's now always on in debug builds unless disabled by defining PLATFORM_DISABLE_MEM_LEAK_TESTING (which only Windows does) and always off in release builds. Commit: 39b45a4f6f9f90f7557865910f20cd5edd5d6f89 https://github.com/boxbackup/boxbackup/commit/39b45a4f6f9f90f7557865910f20cd5edd5d6f89 Author: Chris Wilson Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M lib/common/LineBuffer.h Log Message: ----------- LineBuffer.h: update header comment and #include guard for new filename Commit: 301ccbbadbd7cd8e292c4c87ad37b51bfe26a26e https://github.com/boxbackup/boxbackup/commit/301ccbbadbd7cd8e292c4c87ad37b51bfe26a26e Author: Chris Wilson Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M lib/common/Logging.cpp M lib/common/Logging.h M test/common/testcommon.cpp Log Message: ----------- Logging: improve performance by not generating message unnecessarily Avoid building an ostringstream, writing all logged values to it and converting it to a string, for log messages that no logger is currently interested in (e.g. TRACE logging most of the time). Cache this "lowest common log level" and update it when any logger is reconfigured, added or removed. Commit: fc62ef3fffc9cb0b82ee7c66bee633099d97b76a https://github.com/boxbackup/boxbackup/commit/fc62ef3fffc9cb0b82ee7c66bee633099d97b76a Author: Chris Wilson Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M lib/httpserver/HTTPQueryDecoder.cpp Log Message: ----------- HTTPQueryDecoder::URLEncode: speed up by processing larger chunks Scan the string for characters which need URL-encoding and append the substring before that in one go. If the entire string does not need URL-encoding, just return it without any further processing. Commit: d0396c2941e39fa3785133a4f6deb47afddd8c16 https://github.com/boxbackup/boxbackup/commit/d0396c2941e39fa3785133a4f6deb47afddd8c16 Author: Chris Wilson Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M lib/common/Utils.cpp Log Message: ----------- Fix incorrect use of abi::__cxa_demangle The buffer, if passed, should be allocated with malloc, not statically. In this case we don't need to allocate one first, we can use the default behaviour where abi::__cxa_demangle allocates one for us. Commit: d48cae211f4ae1153a0e4811ce57bd23c674507f https://github.com/boxbackup/boxbackup/commit/d48cae211f4ae1153a0e4811ce57bd23c674507f Author: Chris Wilson Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M test/basicserver/testbasicserver.cpp Log Message: ----------- Add more logging to test/basicserver for FreeBSD timeouts (cherry picked from commit 2bfbf2995a09a6ce62a96c2bc07da6b88e014da6) Compare: https://github.com/boxbackup/boxbackup/compare/6bb9951143d5...d48cae211f4a From noreply at github.com Sat Feb 24 14:09:17 2018 From: noreply at github.com (GitHub) Date: Sat, 24 Feb 2018 06:09:17 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] 923dca: Fix raidfile tests on 32-bit Linux Message-ID: <5a91720dc36e9_70c42b06ab6f5c0c14143f@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/fix_raidfile_i386 Home: https://github.com/boxbackup/boxbackup Commit: 923dcaab581b84ca73a031b0f0af255e31a2043b https://github.com/boxbackup/boxbackup/commit/923dcaab581b84ca73a031b0f0af255e31a2043b Author: Chris Wilson Date: 2018-02-24 (Sat, 24 Feb 2018) Changed paths: M lib/intercept/intercept.cpp Log Message: ----------- Fix raidfile tests on 32-bit Linux A recent fix for Solaris (commit 81e9aa6545f7f19124c9f5e88982b867d8732965) broke support for 32-bit Linux (which wasn't spotted because we didn't have any 32-bit builders). Try a different approach: use llseek where possible. From noreply at github.com Sat Feb 24 14:40:26 2018 From: noreply at github.com (GitHub) Date: Sat, 24 Feb 2018 06:40:26 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] ce86f1: Fix raidfile tests on 32-bit Linux Message-ID: <5a91795a3ab43_70fd2abd2fa9bc00244b4@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/fix_raidfile_i386 Home: https://github.com/boxbackup/boxbackup Commit: ce86f16b6e3fb979ac21f7e0e70ff8a1c4af651c https://github.com/boxbackup/boxbackup/commit/ce86f16b6e3fb979ac21f7e0e70ff8a1c4af651c Author: Chris Wilson Date: 2018-02-24 (Sat, 24 Feb 2018) Changed paths: M infrastructure/m4/ax_check_syscall_lseek.m4 M lib/intercept/intercept.cpp M test/raidfile/testraidfile.cpp Log Message: ----------- Fix raidfile tests on 32-bit Linux A recent fix for Solaris (commit 81e9aa6545f7f19124c9f5e88982b867d8732965) broke support for 32-bit Linux (which wasn't spotted because we didn't have any 32-bit builders). Try a different approach: use llseek where possible. Commit: fe282e4b8058002536669ec2c3fa4c2dc231074b https://github.com/boxbackup/boxbackup/commit/fe282e4b8058002536669ec2c3fa4c2dc231074b Author: Chris Wilson Date: 2018-02-24 (Sat, 24 Feb 2018) Changed paths: M configure.ac M infrastructure/makebuildenv.pl.in Log Message: ----------- Fix error in t-gdb when no debugger is detected Compare: https://github.com/boxbackup/boxbackup/compare/923dcaab581b...fe282e4b8058 From noreply at github.com Sun Feb 25 08:19:09 2018 From: noreply at github.com (GitHub) Date: Sun, 25 Feb 2018 00:19:09 -0800 Subject: [Box Backup-commit] [boxbackup/boxbackup] bc48be: Revert "Add support for OpenSSL 1.1 and replace de... Message-ID: <5a92717d58671_441e2b07894d7c0c178460@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/revert_openssl_1_1 Home: https://github.com/boxbackup/boxbackup Commit: bc48bec97b65534966da74a07ed3edb3f13f6263 https://github.com/boxbackup/boxbackup/commit/bc48bec97b65534966da74a07ed3edb3f13f6263 Author: Chris Wilson Date: 2018-02-25 (Sun, 25 Feb 2018) Changed paths: M appveyor.yml M infrastructure/cmake/CMakeLists.txt M infrastructure/cmake/windows/CMakeLists.txt M lib/crypto/CipherBlowfish.cpp M lib/crypto/CipherContext.cpp M lib/crypto/CipherContext.h M lib/crypto/CipherException.txt M lib/server/TLSContext.cpp M test/crypto/testcrypto.cpp Log Message: ----------- Revert "Add support for OpenSSL 1.1 and replace deprecated function calls" Until shown to be safe. See message from Johann Glaser to the mailing list. This reverts commit 85e7efc3fa0477f60318d2cd2144503a9ea8feb9.