[Box Backup-commit] [boxbackup/boxbackup] 9088ee: Logging: improve performance by not generating mes...

GitHub noreply at github.com
Sat Feb 17 22:45:09 GMT 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 9088ee4e2eb4363ba7cafd2db152753d99d6605f
      https://github.com/boxbackup/boxbackup/commit/9088ee4e2eb4363ba7cafd2db152753d99d6605f
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M lib/common/Logging.cpp
    M lib/common/Logging.h
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Logging: improve performance by not generating message unnecessarily

Avoid building an ostringstream, writing all logged values to it and converting
it to a string, for log messages that no logger is currently interested in
(e.g. TRACE logging most of the time). Cache this "lowest common log level" and
update it when any logger is reconfigured, added or removed.


  Commit: 9f594f619646b85b369d58dded78124d7e37c6e9
      https://github.com/boxbackup/boxbackup/commit/9f594f619646b85b369d58dded78124d7e37c6e9
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M lib/httpserver/HTTPQueryDecoder.cpp

  Log Message:
  -----------
  HTTPQueryDecoder::URLEncode: speed up by processing larger chunks

Scan the string for characters which need URL-encoding and append the substring
before that in one go. If the entire string does not need URL-encoding, just
return it without any further processing.


Compare: https://github.com/boxbackup/boxbackup/compare/1d77b48201ea...9f594f619646


More information about the Boxbackup-commit mailing list