[Box Backup-commit] [boxbackup/boxbackup] 24386d: Remove MEMLEAKFINDER_NOT_A_LEAK from FileStream

GitHub noreply at github.com
Sun Jan 21 12:51:46 GMT 2018


  Branch: refs/heads/s3_support_merge
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 24386d968c3fd9a9c486e42c24e2844e9ff713ad
      https://github.com/boxbackup/boxbackup/commit/24386d968c3fd9a9c486e42c24e2844e9ff713ad
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2017-12-17 (Sun, 17 Dec 2017)

  Changed paths:
    M lib/common/FileStream.cpp

  Log Message:
  -----------
  Remove MEMLEAKFINDER_NOT_A_LEAK from FileStream

It's not clear why we need to tell the memory leak tracking system to ignore
FileStream objects if they raise an exception in their constructors. The
objects should still be destroyed normally. Additionally, now that we
allocate more of them on the heap (for NamedLock), this can cause later
allocations to be silently ignored as not-leaks, which is causing
test_memory_leak_detection to fail.




More information about the Boxbackup-commit mailing list