[Box Backup-commit] [boxbackup/boxbackup] 4ed9c6: Convert RaidFileWrite to use FileStream to write s...

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 4ed9c6e52a993b6223c48431bb479a9efb2a415c
      https://github.com/boxbackup/boxbackup/commit/4ed9c6e52a993b6223c48431bb479a9efb2a415c
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-01-21 (Sun, 21 Jan 2018)

  Changed paths:
    M lib/common/CommonException.txt
    M lib/common/FileStream.cpp
    M lib/common/NamedLock.cpp
    M lib/raidfile/RaidFileWrite.cpp

  Log Message:
  -----------
  Convert RaidFileWrite to use FileStream to write stripes

Enable exclusive locking of stripe files on all platforms, not just Windows and
O_EXLOCK.

(cherry picked from commit d6714507bd965b4b37a335328e9ce07dfad21fbb)


  Commit: cabec10f08fdfe56ad89fe4cb026577516c32ec0
      https://github.com/boxbackup/boxbackup/commit/cabec10f08fdfe56ad89fe4cb026577516c32ec0
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-01-21 (Sun, 21 Jan 2018)

  Changed paths:
    M lib/common/FileStream.cpp

  Log Message:
  -----------
  Remove MEMLEAKFINDER_NOT_A_LEAK from FileStream

It's not clear why we need to tell the memory leak tracking system to ignore
FileStream objects if they raise an exception in their constructors. The
objects should still be destroyed normally. Additionally, now that we
allocate more of them on the heap (for NamedLock), this can cause later
allocations to be silently ignored as not-leaks, which is causing
test_memory_leak_detection to fail.

(cherry picked from commit 24386d968c3fd9a9c486e42c24e2844e9ff713ad)


  Commit: 716a3a9fb15cc2ed71b680dfcb7f529172c326e3
      https://github.com/boxbackup/boxbackup/commit/716a3a9fb15cc2ed71b680dfcb7f529172c326e3
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-01-21 (Sun, 21 Jan 2018)

  Changed paths:
    M test/common/testcommon.cpp

  Log Message:
  -----------
  Compile out test_memory_leak_detection if leak detection is disabled

(cherry picked from commit 616ad76d22f6360e9b53cc682028c0e87f1ea66c)


Compare: https://github.com/boxbackup/boxbackup/compare/18e1948fb243...716a3a9fb15c