[Box Backup-commit] [boxbackup/boxbackup] efb63e: S3BackupFileSystem::ReleaseLock: flush refcount DB...

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: efb63e85b0a5eb07b2c32c430fca550bd7f60225
      https://github.com/boxbackup/boxbackup/commit/efb63e85b0a5eb07b2c32c430fca550bd7f60225
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  S3BackupFileSystem::ReleaseLock: flush refcount DB back to S3 storage

We shouldn't have to destroy the S3BackupFileSystem to flush the refcount DB.
Keeping it cached while not holding a lock on the store is also probably a bad
idea.


  Commit: a1a270f1a26a35a8373b820840209d71a3ef55da
      https://github.com/boxbackup/boxbackup/commit/a1a270f1a26a35a8373b820840209d71a3ef55da
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/backupstore/BackupStoreCheck2.cpp

  Log Message:
  -----------
  BackupStoreCheck: improve log messages during checks, and code comments


  Commit: 3d5bf1e41e9fca1dade5429fdc80bb14f267da35
      https://github.com/boxbackup/boxbackup/commit/3d5bf1e41e9fca1dade5429fdc80bb14f267da35
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/backupstore/BackupStoreRefCountDatabase.cpp
    M lib/backupstore/BackupStoreRefCountDatabase.h

  Log Message:
  -----------
  BackupStoreRefCountDatabase: improve comments, add an assertion


  Commit: c1d756079108a29add27d0705c1d082a29bbf162
      https://github.com/boxbackup/boxbackup/commit/c1d756079108a29add27d0705c1d082a29bbf162
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/backupstore/BackupStoreRefCountDatabase.cpp
    M lib/common/FileStream.cpp
    M lib/common/FileStream.h

  Log Message:
  -----------
  BackupStoreRefCountDatabase: truncate on save

Avoids leaving stale data after the last used object ID. It's probably not
important, but it makes the tests happy.


  Commit: 9ad2a48d158389a6f1a260041995de139caf30a6
      https://github.com/boxbackup/boxbackup/commit/9ad2a48d158389a6f1a260041995de139caf30a6
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/common/FileStream.cpp

  Log Message:
  -----------
  Fix ff3a57cf5b: FileStream: check for invalid lock modes


  Commit: 839b21b1ee7879a8ba31ac43cc92aba5397a3ded
      https://github.com/boxbackup/boxbackup/commit/839b21b1ee7879a8ba31ac43cc92aba5397a3ded
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/backupstore/BackupStoreContext.cpp

  Log Message:
  -----------
  BackupStoreContext::AddDirectory: write parent directory immediately

This reduces the risk of losing whole directories and many files because we
don't know where to attach them, because the parent directory was never
uploaded, and the child doesn't record its parent ID.


  Commit: 17ba9113ae8bb3f384203c06b7d65dc5fe05b6b4
      https://github.com/boxbackup/boxbackup/commit/17ba9113ae8bb3f384203c06b7d65dc5fe05b6b4
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/bbackupd/BackupClientContext.cpp

  Log Message:
  -----------
  BackupClientContext::CloseAnyOpenConnection: don't silently ignore errors

Now that we can do significant writeback work during connection cleanup, it's
not appropriate to silently ignore and swallow errors. Really we should retry
this work, but I'm not yet sure what the best retry policy would be.


  Commit: 8b9eb4a10593c65610cc7e7b330cad08c4e66be1
      https://github.com/boxbackup/boxbackup/commit/8b9eb4a10593c65610cc7e7b330cad08c4e66be1
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M lib/bbackupd/BackupClientDirectoryRecord.cpp

  Log Message:
  -----------
  BackupClientDirectoryRecord::UpdateItems: retry on EINTR

Receiving an EINTR usually means that the process received a signal. Depending
on the signal, that might mean that we need to stop, or simply that a timer
expired and we need to send a heartbeat at the next opportunity.

If we haven't been asked to stop, retry the same upload an arbitrary number of
times.  If the keepalive time is too short, we will still fail after 10 times,
but at least now we will log a more helpful error message.


Compare: https://github.com/boxbackup/boxbackup/compare/2f4d722ea93c...8b9eb4a10593
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.