[Box Backup-commit] [boxbackup/boxbackup] 8f737c: BackupStoreContext::AddDirectory: write parent dir...

GitHub noreply at github.com
Sat Jul 14 22:03:21 BST 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 8f737cb28f70561370731990d2c38a6d81443813
      https://github.com/boxbackup/boxbackup/commit/8f737cb28f70561370731990d2c38a6d81443813
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M lib/backupstore/BackupStoreContext.cpp
    M test/backupstore/testbackupstore.cpp

  Log Message:
  -----------
  BackupStoreContext::AddDirectory: write parent directory immediately

This reduces the risk of losing whole directories and many files because we
don't know where to attach them, because the parent directory was never
uploaded, and the child doesn't record its parent ID.


  Commit: 765d5e500eadb9ce7455c6dd18d452d858b42b37
      https://github.com/boxbackup/boxbackup/commit/765d5e500eadb9ce7455c6dd18d452d858b42b37
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M lib/bbackupd/BackupClientContext.cpp

  Log Message:
  -----------
  BackupClientContext::CloseAnyOpenConnection: don't silently ignore errors

Now that we can do significant writeback work during connection cleanup, it's
not appropriate to silently ignore and swallow errors. Really we should retry
this work, but I'm not yet sure what the best retry policy would be.


  Commit: 25f7b741b7209cbc23956a5efc48ba88374deafd
      https://github.com/boxbackup/boxbackup/commit/25f7b741b7209cbc23956a5efc48ba88374deafd
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M lib/bbackupd/BackupClientDirectoryRecord.cpp

  Log Message:
  -----------
  BackupClientDirectoryRecord::UpdateItems: retry on EINTR

Receiving an EINTR usually means that the process received a signal. Depending
on the signal, that might mean that we need to stop, or simply that a timer
expired and we need to send a heartbeat at the next opportunity.

If we haven't been asked to stop, retry the same upload an arbitrary number of
times.  If the keepalive time is too short, we will still fail after 10 times,
but at least now we will log a more helpful error message.


  Commit: 93a055f7f10dd7c1805b297471bfc53dc9fa77bf
      https://github.com/boxbackup/boxbackup/commit/93a055f7f10dd7c1805b297471bfc53dc9fa77bf
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M lib/backupstore/BackupStoreDirectory.cpp

  Log Message:
  -----------
  BackupStoreDirectory::Entry: fix loss of mInvalidated on copy


  Commit: 8a2cf5475182773c0d0378d9cc353f621ad513b5
      https://github.com/boxbackup/boxbackup/commit/8a2cf5475182773c0d0378d9cc353f621ad513b5
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M lib/common/FileStream.cpp
    M lib/common/FileStream.h

  Log Message:
  -----------
  FileStream: add support for blocking locks (wait_for_lock)


  Commit: 80d73647849706e6680c6e2a874baee6ac1fa35f
      https://github.com/boxbackup/boxbackup/commit/80d73647849706e6680c6e2a874baee6ac1fa35f
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M lib/server/Daemon.cpp
    M lib/server/Daemon.h

  Log Message:
  -----------
  Daemon::WritePidFile: release exclusive lock after writing

Reopen the file with a shared lock, so that readers can open it for reading.


Compare: https://github.com/boxbackup/boxbackup/compare/6213f5430425...80d736478497
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Boxbackup-commit mailing list