[Box Backup-commit] [boxbackup/boxbackup] b2a508: Change emu_rename semantics to allow renaming over...

GitHub noreply at github.com
Sun Jun 3 21:41:13 BST 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: b2a50862c4149f02e1ab727d45a277c0c22308c9
      https://github.com/boxbackup/boxbackup/commit/b2a50862c4149f02e1ab727d45a277c0c22308c9
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-06-03 (Sun, 03 Jun 2018)

  Changed paths:
    M lib/backupstore/BackupStoreRefCountDatabase.cpp
    M lib/win32/emu.cpp

  Log Message:
  -----------
  Change emu_rename semantics to allow renaming over existing files

Remove explicit deletion before rename in
BackupStoreRefCountDatabase::Commit. It seems that this sometimes isn't
atomic for release builds on Windows, or at least it would explain the
random test failures on AppVeyor. The new semantics better match UNIX,
and the improved emulation should allow the removal of plenty of
conditional compatibility code.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Boxbackup-commit mailing list