[Box Backup-commit] [boxbackup/boxbackup] ed36ac: Loosen timing tolerance by reducing MaxUploadWait

[GitHub]

  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: ed36ac71bc96cc6fc4a1947bcf5178fa6ad9bd8d
      https://github.com/boxbackup/boxbackup/commit/ed36ac71bc96cc6fc4a1947bcf5178fa6ad9bd8d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M lib/bbackupd/BackupClientDirectoryRecord.cpp
    M lib/bbackupd/BackupDaemon.cpp
    M lib/common/BoxTime.cpp
    M lib/common/BoxTime.h
    M test/bbackupd/testbbackupd.cpp
    M test/bbackupd/testfiles/bbackupd.conf.in

  Log Message:
  -----------
  Loosen timing tolerance by reducing MaxUploadWait

Before, we only had 1 second tolerance (we stopped updating the file 1 second
before bbackupd would run to back it up) and if bbackupd ran at the wrong time
(just before a second boundary) and lost time so that it went over that second
boundary, then it would backup the file one run earlier than the test expected.

Increasing the tolerance by 1 second should make that really unlikely.

Also increase some INFO log messages to NOTICE, because they (and their
timestamps) are essential to debugging the test when it fails, even in release
mode. And 4 extra lines of test output is not a high price to pay.

Also stop "adjusting" MaxUploadWait so that it actually means what it appears
to mean: the time between when a file was first seen, and when it will be
uploaded, even if it continues to be modified in the mean time.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.