[Box Backup-commit] [boxbackup/boxbackup] 7023bf: S3BackupFileSystem: reduce scope for exception mis...

GitHub noreply at github.com
Wed Nov 7 23:05:54 GMT 2018


  Branch: refs/heads/s3_support
  Home:   https://github.com/boxbackup/boxbackup
  Commit: 7023bff62beb118a020d6b7194adc0ceddec7a09
      https://github.com/boxbackup/boxbackup/commit/7023bff62beb118a020d6b7194adc0ceddec7a09
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M lib/backupstore/BackupFileSystem.cpp

  Log Message:
  -----------
  S3BackupFileSystem: reduce scope for exception misinterpretation

SimpleDBItemNotFound exceptions were caught over a larger section of code than
necessary, which could result in exceptions thrown by that code being regarded
as lock conflicts when in fact they had unrelated causes.


  Commit: 58a63e7f4bbadbd830b09cc7f70cd06571afa2b1
      https://github.com/boxbackup/boxbackup/commit/58a63e7f4bbadbd830b09cc7f70cd06571afa2b1
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M lib/backupstore/BackupStoreContext.cpp

  Log Message:
  -----------
  BackupStoreContext: do not leave mpRefCount uninitialised

Add an assertion to check that the filesystem has a current refcount DB when we
expect it to (when mpRefCount is not NULL).


  Commit: ea45587fb4977fe815cda82758bc1e10d9e92345
      https://github.com/boxbackup/boxbackup/commit/ea45587fb4977fe815cda82758bc1e10d9e92345
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M lib/bbackupd/BackupDaemon.cpp

  Log Message:
  -----------
  BackupDaemon: failure to create remote directory is not a local issue

We treated exceptions raised while trying to create the remote directory for a
location as though they meant that we didn't have permission to access the
local directory, resulting in confusing error messages.


  Commit: 623064dd5baf1257a002410f6fe3d89aaf579e0e
      https://github.com/boxbackup/boxbackup/commit/623064dd5baf1257a002410f6fe3d89aaf579e0e
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M lib/httpserver/S3Simulator.cpp

  Log Message:
  -----------
  S3Simulator: log HTTP requests at TRACE level, not NOTICE

We don't want to see all of them! They are no longer high priority messages.


  Commit: 49d3da02d7e85e86a09bf3575d44afe28ce3cb57
      https://github.com/boxbackup/boxbackup/commit/49d3da02d7e85e86a09bf3575d44afe28ce3cb57
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M lib/server/ServerControl.cpp

  Log Message:
  -----------
  WaitForServerStartup: don't require the pidFile parameter

Add support for waiting for a server to start even if it doesn't write PID
files (e.g. forked local daemons in test/bbackupd). In this case we know the
PID from the fork() return code, so we don't need a PID file to determine it.


  Commit: 422dbf86d38bb08ac4c9a6f3875b6690a58726e4
      https://github.com/boxbackup/boxbackup/commit/422dbf86d38bb08ac4c9a6f3875b6690a58726e4
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M lib/backupstore/StoreTestUtils.cpp
    M lib/backupstore/StoreTestUtils.h

  Log Message:
  -----------
  StopSimulator: add a wait_for_process argument

Useful for waiting for a forked simulator daemon in test/bbackupd to shut down.


  Commit: fd7d207c36c79adfdcab691a67e2d2fe6682c40d
      https://github.com/boxbackup/boxbackup/commit/fd7d207c36c79adfdcab691a67e2d2fe6682c40d
  Author: Chris Wilson <chris+github at qwirx.com>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M .gitignore
    M configure.ac
    M infrastructure/cmake/CMakeLists.txt
    M lib/httpserver/HTTPException.txt
    M lib/httpserver/HTTPServer.cpp
    M lib/httpserver/S3Client.h
    M lib/httpserver/S3Simulator.cpp
    M test/bbackupd/testbbackupd.cpp
    A test/bbackupd/testfiles/bbackupd-snapshot.s3.conf.in

  Log Message:
  -----------
  test/bbackupd: add specialised versions of some tests for S3

Not all tests are specialised because many are quite slow, and would behave in
the same way, not expected to exercise any additional S3-related code paths
that are not covered by the tests that have been implemented.


Compare: https://github.com/boxbackup/boxbackup/compare/b5b5048f1821...fd7d207c36c7
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Boxbackup-commit mailing list