[Box Backup-dev] COMMIT r255 - in box/chris/win32/vc2005-compile-fixes/lib: common compress server win32

Chris Wilson boxbackup-dev at fluffy.co.uk
Wed Dec 21 00:10:17 GMT 2005


Hi Martin,

>> -#include <unistd.h>
>> +#ifndef WIN32
>> +#include <unistd.h>
>> +#endif
>
> Please don't use a platform check for header files. Please add a
> configure test (AC_CHECK_HEADERS) and use its define.

Even though configure doesn't run on win32?

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |




More information about the Boxbackup-dev mailing list