[Box Backup-dev] COMMIT r255 - in box/chris/win32/vc2005-compile-fixes/lib: common compress server win32

Ben Summers boxbackup-dev at fluffy.co.uk
Wed Dec 21 10:16:30 GMT 2005


On 21 Dec 2005, at 00:08, Chris Wilson wrote:

>
>> I deliberately used int for sizes in IOStream functions, as I  
>> thought these frequently used functions should use arithmetic on  
>> the most natural integer size for the platform.
>
> I don't understand why you used a signed rather than an unsigned  
> type for things which don't seem to make any sense as negatives,  
> like buffer sizes.

To be consistent with the seek arguments, and to mess with the mind  
of anyone else working on the code.

> But I could use IOStream::pos_type instead if you prefer, or even  
> make everything use signed integers if you insist.

I'm not sure quite what's best here. What's the underlying reason for  
this change? Why does VC need it? Why didn't Nick have this problem?

Ben







More information about the Boxbackup-dev mailing list