[Box Backup-dev] Where to put my bug fixes?

[Chris Wilson]

Hi Martin,

> I agree that we should do this through svn. As to several revisions to a 
> change, that's no problem, just list each related revision together as a 
> group, which is what I was suggesting.

Please could you give an example? I'm confused as to exactly what 
information I should be giving.

> Ok, I understand what you did now. I can work with that. I've still got 
> the patches in my mailbox so I'll go back and look over them.

If you do, please note that some of the patches should be updated, but 
weren't because nobody seemed interested in the patches I posted. So 
please would you consider reviewing all the changes between trunk and 
general in those files, instead of just the changes given in the 
posted patch file?

> One thing I'm concerned about is that when this is all merged into trunk 
> that the revision history there is ok to follow. ie. Unrelated changes 
> should preferably be merged into trunk in their own commits with 
> sensible comments. Related or larger changes on a branch by themselves 
> could be merged in one go as long as they only come from one branch. 
> It's ok to see a branch merge and go and check the history of the 
> branch, but doesn't work well if the branches have been copied around 
> and partially merged, makes it time consuming to see what happened 
> where.

I definitely agree that commits to trunk should be atomic, minimal and 
well commented. I don't want all changes in the merge branch to be 
committed at once, or with the same log message.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |