[Box Backup-dev] COMMIT r779 - box/chris/general/test/backupdiff

Charles Lecklider boxbackup-dev at fluffy.co.uk
Sat Aug 19 17:50:27 BST 2006


Chris Wilson wrote:
> Hi Charles,
> 
> On Sat, 19 Aug 2006, Charles Lecklider wrote:
> 
>> OK, I know this is debug code, but....
> [...]
>> Sorry to jump on this, but it's indicative of the first round of
>> compiler warnings I'm still trying to find time to trawl through and fix
>> before I get started on the real work. No-one likes Microsoft for
>> inconsistent use of INVALID_HANDLE_VALUE and NULL, or BOOL, or any
>> number of other things, but that's the way it is....
> 
> Thanks for spotting these. In fact the test code works fine on Windows
> as it is (probably because everything is cast down to bool), but I've
> made the changes you suggested and will commit them if all tests still
> pass.

I've no doubt it works, but that doesn't mean it's right :-)

There are similar problems in #782 too.

-C




More information about the Boxbackup-dev mailing list