[Box Backup-dev] Moving trunk to release

Ben Summers boxbackup-dev at fluffy.co.uk
Tue Jan 17 21:56:15 GMT 2006


On 17 Jan 2006, at 21:48, Chris Wilson wrote:

> Hi Gary,
>
>> I think there are two patches off 0.09 floating around for both  
>> the state-save and keep-alive, possibly from the Win32 port. Nick?
>
> I haven't heard from Nick since December at least - I don't know  
> what happened to him, I hope he's OK.
>
> Working from the tarball you supplied for me, boxbackup-0.09- 
> gary.tar.gz, and the released bb 0.09 tarball, I can generate a  
> patch for your modifications. If you like, I can upload a patched  
> copy to SVN for the other developers to browse.

That might be handy!

>
>> I can probably make the state-save into a patch as it is, but the  
>> keep-alive keeds a rework of the main diffing loop. The way I have  
>> done this through an interrupt handler call is probably not the  
>> way to go for a release-grade.
>
> No comments except that I guess it's working fine for you and  
> Nick :-) Do you remember anything about the location of the code in  
> question, so that I can have a look in more detail?

There was lots of and lots of stuff happening in a signal handler!  
There is only a small number of things which are supposed to work  
inside a signal handler. And I doubt that OpenSSL would like being  
called reentrantly for the same connection.

Obviously this will tend to be fine because most of the time it'll be  
running the algorithm which hardly uses syscalls, but when it does go  
wrong it will go bang in mysterious ways.

Ben






More information about the Boxbackup-dev mailing list