[Box Backup-dev] Moving trunk to release

Ben Summers boxbackup-dev at fluffy.co.uk
Sat Jan 28 10:02:28 GMT 2006


On 27 Jan 2006, at 21:38, Chris Wilson wrote:
>
>> 2. Windows specific fixes:
>>>    svn diff
>>> http: //bbdev.fluffy.co.uk/svn/box/chris/win32/type-changes
>>> http: //bbdev.fluffy.co.uk/svn/box/chris/win32/vc2005-compile-fixes
>>
>> Looking at this one, all the windows specific stuff looks fine.  
>> There are a large number of casts in here as well though, which I  
>> don't really think should be necessary.
>
> They're not absolutely required, but each case generates a warning  
> on MSVC that I would like to avoid, as the warnings could easily  
> obscure real problems.
>
> Although the casts may look a bit ugly in the code, they serve the  
> function of reminding developers that a type change is happening  
> that would otherwise be silently done by the compiler. This may  
> help to spot obscure problems in future, but I guess that if you  
> can't see any problems now with your eagle eye, the existing code  
> is probably correct :-)

As long as everyone agrees that these are actually just explicitly  
stating the actual intention of the code, then I wouldn't object.

My only fear is that the necessity for casts is showing up problems.



>> 4. Save state for restart
>>
>> Am I right in thinking this one is not yet in svn?
>
> Not yet in SVN, no.
>
> Please also consider applying the (pretty trivial) fixes that I  
> made before releasing the 0.10 RC 0.1, and in response to a bug  
> report for that version:
>
> svn diff http://bbdev.fluffy.co.uk/svn/box/trunk@327 \
>   http://bbdev.fluffy.co.uk/svn/box/chris/ 
> boxbackup-0.10_rc0.2_win32 at 335
>
> The timestamp fixes here are probably duplicated in the VS2005 fixes.

I am happy for that to be applied.

Ben








More information about the Boxbackup-dev mailing list