[Box Backup-dev] COMMIT r348 - in box/chris/bb-save-state: . bin/bbackupd lib/common lib/server

Chris Wilson boxbackup-dev at fluffy.co.uk
Sun Jan 29 22:33:15 GMT 2006


Hi Ben,

On Sun, 29 Jan 2006, Ben Summers wrote:

> I would have removed the operator overloading from Archive, and 
> personally would have just required that classes derived from Archive 
> only provide Read(void*,int length) and Write(void*,int length) 
> functions, rather than doing absolutely everything, and made base class 
> Get and Put inline functions which call those.

I considered doing that, but I didn't want to introduce too many changes 
at once.

As you spotted, I didn't remove all the operator overloading, only in 
BackupDaemon.cpp.

> bin/bbackupd/BackupClientDirectoryRecord.h
> bin/bbackupd/BackupDaemon.h
> lib/common/ExcludeList.h
> 	-- #include "Archive.h" -> class Archive;  ?

Sorry, I don't understand what's wrong.

> As I understand it, I just need to adjust the infrastructure building to 
> run ./bootstrap, and then include all the new files from SVN in the 
> root, along with the generated configure?

Seems reasonable to me.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |




More information about the Boxbackup-dev mailing list